(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T300201

1.38.0-wmf.25 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
brennen
Release Version
1.38.0-wmf.25
Release Date
Mar 7 2022, 12:00 AM

2022 week 10 1.38-wmf.25 Changes wmf/1.38.0-wmf.25

This MediaWiki Train Deployment is scheduled for the week of Monday, March 7th:

Monday March 7thTuesday, March 8thWednesday, March 9thThursday, March 10thFriday
Backports only.Branch wmf.25 and deploy to Group 0 Wikis.Deploy wmf.25 to Group 1 Wikis.Deploy wmf.25 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.25 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.38.0-wmf.24
Next: 1.38.0-wmf.26

Related Objects
Search...

Event Timeline

thcipriani created this task.Jan 26 2022, 9:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2022, 9:01 PM
thcipriani assigned this task to dancy.Feb 18 2022, 12:14 AM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: brennen.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Next).
matmarex added a subtask: T298638: Make modifications to Pager HTML to add heading separators to support Minerva skinning.Mar 1 2022, 6:06 PM
dom_walden added a subtask: T303033: Revision history not showing.Mar 4 2022, 9:40 AM
Ammarpad removed a subtask: T303033: Revision history not showing.Mar 4 2022, 2:48 PM
RhinosF1 subscribed.Mar 5 2022, 1:18 PM

Conductor: Please be aware of T303092: quibble-vendor-mysql-php72-noselenium-docker fails for a noop PageTriage patch, I'm not sure on impact but it may be worth looking out for when we roll to production if not resolved.

AlexisJazz subscribed.Mar 7 2022, 11:07 AM

API broken. T303165
If I got it wrong task please copy to the right deployment blockers thingy.

• kostajh added a subtask: T303251: Error: exception of type Error: Cannot unpack array with string keys.Mar 8 2022, 10:48 AM
• kostajh removed a subtask: T303251: Error: exception of type Error: Cannot unpack array with string keys.Mar 8 2022, 11:27 AM
Jdlrobson removed a subtask: T298638: Make modifications to Pager HTML to add heading separators to support Minerva skinning.Mar 8 2022, 4:08 PM
brennen subscribed.Mar 8 2022, 4:53 PM
AlexisJazz unsubscribed.Mar 8 2022, 5:16 PM
gerritbot added a comment.Mar 8 2022, 7:31 PM

Change 769100 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/mediawiki-config@master] testwikis wikis to 1.38.0-wmf.25 refs T300201

https://gerrit.wikimedia.org/r/769100

gerritbot added a project: Patch-For-Review.Mar 8 2022, 7:31 PM

Change 769100 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.38.0-wmf.25 refs T300201

https://gerrit.wikimedia.org/r/769100

Stashbot added a comment.Mar 8 2022, 7:32 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-08T19:32:25Z] <dancy@deploy1002> Started scap: testwikis wikis to 1.38.0-wmf.25 refs T300201

Stashbot added a comment.Mar 8 2022, 8:27 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-08T20:27:33Z] <dancy@deploy1002> Started scap: testwikis wikis to 1.38.0-wmf.25 refs T300201

Stashbot added a comment.Mar 8 2022, 8:59 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-08T20:59:46Z] <dancy@deploy1002> Finished scap: testwikis wikis to 1.38.0-wmf.25 refs T300201 (duration: 32m 13s)

gerritbot added a comment.Mar 8 2022, 10:22 PM

Change 769126 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.25 refs T300201

https://gerrit.wikimedia.org/r/769126

gerritbot added a comment.Mar 8 2022, 10:23 PM

Change 769126 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.38.0-wmf.25 refs T300201

https://gerrit.wikimedia.org/r/769126

Stashbot added a comment.Mar 8 2022, 10:24 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-08T22:24:35Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.38.0-wmf.25 refs T300201

bd808 added a subtask: T303360: TypeError: Argument 3 passed to MediaWiki\Parser\RemexRemoveTagHandler::__construct() must be of the type array, null given, called in /srv/mediawiki/php-1.38.0-wmf.25/includes/parser/Sanitizer.php on line 367.Mar 9 2022, 12:30 AM
bd808 mentioned this in T303360: TypeError: Argument 3 passed to MediaWiki\Parser\RemexRemoveTagHandler::__construct() must be of the type array, null given, called in /srv/mediawiki/php-1.38.0-wmf.25/includes/parser/Sanitizer.php on line 367.
Ladsgroup subscribed.Mar 9 2022, 11:57 AM
Nikerabbit subscribed.Mar 9 2022, 1:37 PM

Train conductor: please be aware of T303391: Flag-day change (cached values incompatible) in Gadgets extension brought translatewiki.net down. I'm not marking it as a blocker, but it might be an issue for WMF production if the train needs to be rolled back.

Zabe subscribed.Mar 9 2022, 1:39 PM
Zabe added a subtask: T303391: Flag-day change (cached values incompatible) in Gadgets extension brought translatewiki.net down.EditedMar 9 2022, 2:33 PM
In T300201#7763648, @Nikerabbit wrote:

Train conductor: please be aware of T303391: Flag-day change (cached values incompatible) in Gadgets extension brought translatewiki.net down. I'm not marking it as a blocker, but it might be an issue for WMF production if the train needs to be rolled back.

Boldly marked as one. Not being capable of rolling back without the risk of causing an outage is not good.

Zabe closed subtask T303391: Flag-day change (cached values incompatible) in Gadgets extension brought translatewiki.net down as Resolved.Mar 9 2022, 3:17 PM
Krinkle added a subtask: T303404: ArgumentCountError: Too few arguments to function MediaWiki\Extension\OATHAuth\OATHUserRepository::remove(), 2 passed in /srv/mediawiki/php-1.38.0-wmf.25/extensions/WebAuthn/src/HTMLForm/WebAuthnDisableForm.php on line 114 and exactly 3 expected.Mar 9 2022, 4:42 PM
Zabe removed a subtask: T303404: ArgumentCountError: Too few arguments to function MediaWiki\Extension\OATHAuth\OATHUserRepository::remove(), 2 passed in /srv/mediawiki/php-1.38.0-wmf.25/extensions/WebAuthn/src/HTMLForm/WebAuthnDisableForm.php on line 114 and exactly 3 expected.Mar 9 2022, 6:38 PM
gerritbot added a comment.Mar 9 2022, 7:04 PM

Change 769490 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.25 refs T300201

https://gerrit.wikimedia.org/r/769490

gerritbot added a comment.Mar 9 2022, 7:04 PM

Change 769490 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.25 refs T300201

https://gerrit.wikimedia.org/r/769490

brennen removed a subtask: T303360: TypeError: Argument 3 passed to MediaWiki\Parser\RemexRemoveTagHandler::__construct() must be of the type array, null given, called in /srv/mediawiki/php-1.38.0-wmf.25/includes/parser/Sanitizer.php on line 367.Mar 9 2022, 7:05 PM
Stashbot added a comment.Mar 9 2022, 7:06 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-09T19:06:15Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.38.0-wmf.25 refs T300201

Stashbot added a comment.Mar 9 2022, 7:07 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-09T19:07:05Z] <dancy@deploy1002> Synchronized php: group1 wikis to 1.38.0-wmf.25 refs T300201 (duration: 00m 49s)

Sjoerddebruin subscribed.Mar 9 2022, 7:15 PM

I think the above just broke gadgets on the upgraded wiki's.

gerritbot added a comment.Mar 9 2022, 7:17 PM

Change 769495 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.24 refs T300201

https://gerrit.wikimedia.org/r/769495

dancy added a comment.Mar 9 2022, 7:18 PM
In T300201#7765164, @Sjoerddebruin wrote:

I think the above just broke gadgets on the upgraded wiki's.

Thanks for the report. I'll file a task.

gerritbot added a comment.Mar 9 2022, 7:19 PM

Change 769495 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.24 refs T300201

https://gerrit.wikimedia.org/r/769495

Epidosis mentioned this in T303454: All gadgets enabled in Preferences don't work on Wikidata.Mar 9 2022, 7:19 PM
Stashbot added a comment.Mar 9 2022, 7:20 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-09T19:20:16Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.38.0-wmf.24 refs T300201

dancy added a subtask: T303455: TypeError: Argument 1 passed to MediaWiki\Extension\Gadgets\GadgetRepo::getGadgetDefinitionTitle() must be of the type string, null given, called in /srv/mediawiki/php-1.38.0-wmf.25/extensions/Gadgets/includes/SpecialGadgets.php on line 114.Mar 9 2022, 7:20 PM
Stashbot added a comment.Mar 9 2022, 7:21 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-09T19:21:06Z] <dancy@deploy1002> Synchronized php: group1 wikis to 1.38.0-wmf.24 refs T300201 (duration: 00m 50s)

• ssastry removed a subtask: T303469: VE should preserve .mw-file-description class in Parsoid HTML.Mar 9 2022, 11:03 PM
gerritbot added a comment.Mar 9 2022, 11:05 PM

Change 769573 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.25 refs T300201

https://gerrit.wikimedia.org/r/769573

gerritbot added a comment.Mar 9 2022, 11:07 PM

Change 769573 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.38.0-wmf.25 refs T300201

https://gerrit.wikimedia.org/r/769573

Stashbot added a comment.Mar 9 2022, 11:08 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-09T23:08:23Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.38.0-wmf.25 refs T300201

Stashbot added a comment.Mar 9 2022, 11:09 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-09T23:09:13Z] <dancy@deploy1002> Synchronized php: group1 wikis to 1.38.0-wmf.25 refs T300201 (duration: 00m 49s)

Zabe closed subtask T303455: TypeError: Argument 1 passed to MediaWiki\Extension\Gadgets\GadgetRepo::getGadgetDefinitionTitle() must be of the type string, null given, called in /srv/mediawiki/php-1.38.0-wmf.25/extensions/Gadgets/includes/SpecialGadgets.php on line 114 as Resolved.Mar 9 2022, 11:10 PM
brennen mentioned this in T288646: PHP Notice: Exception doing lazy updates: Exception: Thread::splitIncrementFromSubject: thread subject has no increment: Comments:.Mar 9 2022, 11:29 PM
Xiplus added a subtask: T303509: HTML entities in "comma-separator" is not rendered in edit tags.Mar 10 2022, 12:13 PM
brennen mentioned this in T303469: VE should preserve .mw-file-description class in Parsoid HTML.Mar 10 2022, 7:31 PM
dancy removed a subtask: T303509: HTML entities in "comma-separator" is not rendered in edit tags.Mar 10 2022, 7:41 PM
gerritbot added a comment.Mar 10 2022, 7:43 PM

Change 769768 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[operations/mediawiki-config@master] group2 wikis to 1.38.0-wmf.25 refs T300201

https://gerrit.wikimedia.org/r/769768

gerritbot added a comment.Mar 10 2022, 7:43 PM

Change 769768 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.38.0-wmf.25 refs T300201

https://gerrit.wikimedia.org/r/769768

Stashbot added a comment.Mar 10 2022, 7:44 PM

Mentioned in SAL (#wikimedia-operations) [2022-03-10T19:44:58Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.38.0-wmf.25 refs T300201

thcipriani closed this task as Resolved.Mar 16 2022, 5:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL