(Go: >> BACK << -|- >> HOME <<)

Page MenuHomePhabricator

matmarex (Bartosz Dziewoński)
Software Engineer

Projects (48)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 17 2014, 6:53 PM (505 w, 2 d)
Availability
Available
IRC Nick
MatmaRex
LDAP User
Bartosz Dziewoński
MediaWiki User
Matma Rex [ Global Accounts ]

Recent Activity

Today

Jack_who_built_the_house awarded T366095: Deploy comment thanking to all wikis a Like token.
Mon, Jun 24, 12:37 AM · Editing-team (Deployments)

Yesterday

matmarex added a comment to T367982: Vector 2022 talk page tab is a blue link even if the talk doesn't exist, should be a red link (but it turns red when clicked).

I've noticed this a couple of times in Timeless, too, so it's not limited to Vector.

Sun, Jun 23, 8:59 PM · Web-Team-Backlog (FY2024-25 Q1 Sprint 1), Desktop Improvements (Vector 2022)

Sat, Jun 22

Sjoerddebruin awarded T367982: Vector 2022 talk page tab is a blue link even if the talk doesn't exist, should be a red link (but it turns red when clicked) a The World Burns token.
Sat, Jun 22, 10:29 AM · Web-Team-Backlog (FY2024-25 Q1 Sprint 1), Desktop Improvements (Vector 2022)

Fri, Jun 21

matmarex created T368179: VisualEditor warning about blocked external link can be skipped too easily (even accidentally).
Fri, Jun 21, 10:24 PM · Patch-For-Review, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
matmarex added a comment to T237244: OOUI buttons with large labels breaks width of several special pages in mobile view.
Fri, Jun 21, 10:13 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), User-TheDJ, Web-Team-Backlog (Needs Prioritization (Tech)), OOUI, Advanced Mobile Contributions
matmarex added a comment to T282893: Various CI jobs failing after "mkdir: cannot create directory ‘log’: Permission denied".

A build on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1048488 failed with "T282893: Expected host directory /srv/jenkins/workspace/quibble-vendor-mysql-php82-noselenium/log to exist but it does not."

Fri, Jun 21, 9:51 PM · Patch-For-Review, Upstream, Jenkins, Release-Engineering-Team (Priority Backlog 📥), ci-test-error, Continuous-Integration-Infrastructure
matmarex closed T322492: Remove wgDiscussionToolsABTest config setting as Resolved.
Fri, Jun 21, 9:49 PM · Technical-Debt, DiscussionTools
matmarex closed T322492: Remove wgDiscussionToolsABTest config setting, a subtask of T294592: [EPIC] Ensure Talk Pages Project "Phase 1" work is easy to maintain, build upon, and learn from, as Resolved.
Fri, Jun 21, 9:49 PM · TPP-Scaling, DiscussionTools, Editing-team
matmarex added a comment to T367843: Can't save changes in DiscussionTools when temp accounts are enabled: "You are no longer logged out, so the action could not be completed.".

Oh, interesting, it looks like it only happens when a CAPTCHA from the ConfirmEdit extension is enabled. So in Wikimedia production, this will affect users who add an external link in their first edit.

Fri, Jun 21, 9:45 PM · Trust and Safety Product Team, Temporary accounts, DiscussionTools
matmarex claimed T367092: Inconsistent views for contents within <dl> tag between desktop and mobile view.
Fri, Jun 21, 9:38 PM · Patch-For-Review, DiscussionTools, MinervaNeue
matmarex added a comment to T367092: Inconsistent views for contents within <dl> tag between desktop and mobile view.

The problem is more clearly visible in various glossary articles, for example:

Fri, Jun 21, 9:31 PM · Patch-For-Review, DiscussionTools, MinervaNeue
matmarex closed T130322: [regression wmf.9] 'Edit title' pencil icon displayed as protected unnecessarily when viewing Flow page in MobileFrontend as Resolved.

I can't reproduce this today.

Fri, Jun 21, 9:25 PM · Growth-Team-Filtering, Growth-Team, Regression, Contributors-Team, StructuredDiscussions, MobileFrontend
matmarex closed T367842: Can't save changes in VE when temp accounts are enabled: jQuery.Deferred exception: matchPatterns is null as Resolved.

Fixed by the changes in subtask.

Fri, Jun 21, 9:14 PM · Trust and Safety Product Team, Temporary accounts, VisualEditor-MediaWiki, VisualEditor
matmarex added a comment to T368102: jquery.textSelection behavior changed when given `undefined` in command options.

My code is following a documentation of .textSelection(encapsulateSelection) maintained since about 2010, meanwhile deleted, in mw:ResourceLoader/Core modules now pointing to doc.wikimedia.org which tells 404.

Therefore no proof and no valid documentation is available, what the contract on using textSelection did contain and what has been promised for a decade.

I swear I did follow the documentation always and in all details.

Fri, Jun 21, 5:24 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, MediaWiki-User-Interface (active libraries), Regression
matmarex closed T367977: Reply button and notification permalink fail if the comment author contains + (plus) character as Resolved.
Fri, Jun 21, 4:41 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), DiscussionTools
matmarex added a comment to T356196: Auto triming of internal links is breaking anchors if the last character is a space.
Fri, Jun 21, 2:56 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), VisualEditor, User-notice, Editing-team, DiscussionTools
matmarex added a comment to T356196: Auto triming of internal links is breaking anchors if the last character is a space.

Running the maintenance script on all wikis on the beta cluster

Fri, Jun 21, 2:37 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), VisualEditor, User-notice, Editing-team, DiscussionTools
matmarex created P65316 errors.
Fri, Jun 21, 2:33 PM
matmarex created P65315 T356196.log.
Fri, Jun 21, 2:33 PM
matmarex closed T367668: ru.wikipedia.org TextExtracts does not return section names as Invalid.
Fri, Jun 21, 1:14 PM · TextExtracts
matmarex renamed T368102: jquery.textSelection behavior changed when given `undefined` in command options from jquery.textSelection broken since today to jquery.textSelection behavior changed when given `undefined` in command options.
Fri, Jun 21, 1:08 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, MediaWiki-User-Interface (active libraries), Regression
matmarex added a comment to T368102: jquery.textSelection behavior changed when given `undefined` in command options.

Minimal reproduction: $( '#wpTextbox1' ).textSelection( 'encapsulateSelection', { pre: 'A', peri: undefined, replace: true } )

Fri, Jun 21, 1:07 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, MediaWiki-User-Interface (active libraries), Regression
matmarex added a comment to T368102: jquery.textSelection behavior changed when given `undefined` in command options.

To be honest, I doubt this affects anyone except you, since that discussion also says (if I understand correctly) that this hidden feature was never documented correctly. But it does seem like a bug.

Fri, Jun 21, 12:48 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, MediaWiki-User-Interface (active libraries), Regression
matmarex added a comment to T368102: jquery.textSelection behavior changed when given `undefined` in command options.

I found your discussion on de.wp which gives actual steps to reproduce: https://de.wikipedia.org/wiki/Wikipedia:Fragen_zur_Wikipedia#c-PerfektesChaos-20240620175000-BUG:_Wort_„undefined“_erscheint_bei_der_Quelltextbearbeitung

Fri, Jun 21, 12:47 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, MediaWiki-User-Interface (active libraries), Regression
matmarex updated subscribers of T368119: It is no longer possible to click links within visualeditor's popupWidget.

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1043758

Fri, Jun 21, 1:07 AM · Verified, MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Editing-team (Kanban Board), Regression, VisualEditor-MediaWiki-References, VisualEditor
matmarex closed T367841: Display of custom footer icons is broken as Invalid.

I guess this task is rejected then. I'll have to try to get used to the new footer.

Fri, Jun 21, 12:12 AM · MediaWiki-General

Thu, Jun 20

matmarex closed T367891: Remove login popup experiment from the beta cluster as Resolved.
Thu, Jun 20, 11:30 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), SUL3, MediaWiki-Platform-Team, MediaWiki-User-login-and-signup
matmarex updated subscribers of T367645: The background of some SVG maps is not rendered.

I think that @Mdann52 is working on a bot to correct all of these files. I saw this linked in some discussion on en.wp: https://commons.wikimedia.org/wiki/Commons:Bots/Requests/Mdann52_bot_2

Thu, Jun 20, 11:26 PM · User-notice, Wikimedia-SVG-rendering
matmarex added a comment to T367668: ru.wikipedia.org TextExtracts does not return section names.

I see the section names in the example you provided. Can you clarify what output you're seeing, and what do you expect to see instead?

image.png (1×1 px, 278 KB)

Thu, Jun 20, 8:03 PM · TextExtracts
matmarex reopened T363445: Level 2 headings are omitted from action=query extracts in the API on pages where discussion tools are enabled as "Open".

Hi, I saw this issue reported a few weeks ago (I watch DiscussionTools bug reports), but I didn't find the time to investigate until now, especially after I saw it was marked as resolved.

Thu, Jun 20, 7:35 PM · Patch-For-Review, TextExtracts, Wikimedia-Medicine
matmarex closed T367735: Drop the user-agent-based browser support list from VE (VisualEditorBrowserUnsupportedList) as Resolved.
Thu, Jun 20, 5:36 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Technical-Debt, VisualEditor-MediaWiki, VisualEditor
matmarex closed T278543: updateSpecialPages.php tries (and fails) to silently ignore DB errors as Resolved.
Thu, Jun 20, 1:58 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), MediaWiki-Maintenance-system
matej_suchanek awarded T367918: DatabaseUpdater runMaintenance() ignores the $script parameter a Like token.
Thu, Jun 20, 11:48 AM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), MediaWiki-Installer
matmarex moved T356196: Auto triming of internal links is breaking anchors if the last character is a space from Not ready to announce to Announce in next Tech/News on the User-notice board.

User-notice proposed text: (using the same wording as when the feature was announced in Tech/News/2024/05)

Some of the permanent links to talk page comments, which can be copied by clicking on a comment's timestamp, did not work when the topic title was very long and the link was used as a wikitext link. This has been fixed.

It's a bit weirdly technical, but that's the best I came up with. Improvements welcome.

Thu, Jun 20, 2:32 AM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), VisualEditor, User-notice, Editing-team, DiscussionTools
matmarex added a comment to T356196: Auto triming of internal links is breaking anchors if the last character is a space.

Sorry it took us a while to get back to this. I'm now busy working on CentralAuth with the MediaWiki Platform team, and the rest of the Editing team is busy working on Edit check and other projects.

Thu, Jun 20, 2:25 AM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), VisualEditor, User-notice, Editing-team, DiscussionTools

Wed, Jun 19

matmarex closed T241389: Enotif_body says you can contact a user in userspace, and it should probably link to the User_talk: namespace instead as Resolved.
Wed, Jun 19, 10:44 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Growth-Team-Filtering, User-DannyS712, MediaWiki-Watchlist, Growth-Team, MediaWiki-Email
matmarex updated subscribers of T241389: Enotif_body says you can contact a user in userspace, and it should probably link to the User_talk: namespace instead.
Wed, Jun 19, 10:42 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Growth-Team-Filtering, User-DannyS712, MediaWiki-Watchlist, Growth-Team, MediaWiki-Email
matmarex added a comment to T367841: Display of custom footer icons is broken.

I actually have a patch ready to get patchdemo fixed. Just needs someone giving me rights in the repo to I don't need to fork the whole repo. (I know but I'm used to gerrit)

Wed, Jun 19, 7:15 PM · MediaWiki-General
matmarex added a comment to T367841: Display of custom footer icons is broken.

Also… why was MediaWiki's own icon made bigger? It doesn't look good, and it makes it more difficult to keep custom icons consistent with different MediaWiki versions.

Wed, Jun 19, 6:48 PM · MediaWiki-General
matmarex added a comment to T367841: Display of custom footer icons is broken.

I see now that you've mentioned it in release notes, but this still seems unnecessarily disruptive to me. Sites and extensions that add to $wgFooterIcons may not like this styling for their icons (the config variable is called "icons" after all, not "buttons"), and maintaining multiple icons for different MediaWiki versions will be annoying. If you want to decline this, I'll live with that, but I expect that there'll be some grumbling along these lines from other folks in the future.

Wed, Jun 19, 6:40 PM · MediaWiki-General
matmarex closed T367918: DatabaseUpdater runMaintenance() ignores the $script parameter as Resolved.
Wed, Jun 19, 6:22 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), MediaWiki-Installer
matmarex claimed T367918: DatabaseUpdater runMaintenance() ignores the $script parameter.

I'll make patches for all the extensions too.

Wed, Jun 19, 5:29 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), MediaWiki-Installer
matmarex moved T366984: When one transclusion generates multiple table cells, VE counts it as a single table cell, and adds slugs for "missing" cells from Code Review to QA on the Editing-team (Kanban Board) board.
Wed, Jun 19, 4:30 PM · Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki-Templates, VisualEditor-Tables, VisualEditor
matmarex added a subtask for T367842: Can't save changes in VE when temp accounts are enabled: jQuery.Deferred exception: matchPatterns is null : T367108: Default temporary user config causes a JavaScript error.
Wed, Jun 19, 3:52 PM · Trust and Safety Product Team, Temporary accounts, VisualEditor-MediaWiki, VisualEditor
matmarex added a parent task for T367108: Default temporary user config causes a JavaScript error: T367842: Can't save changes in VE when temp accounts are enabled: jQuery.Deferred exception: matchPatterns is null .
Wed, Jun 19, 3:52 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Trust and Safety Product Sprint (Sprint 12 (Jun 24 - July 5)), Temporary accounts (Update MediaWiki Core to introduce temp accounts)
matmarex added a comment to T367977: Reply button and notification permalink fail if the comment author contains + (plus) character.
> MediaWiki\Extension\DiscussionTools\CommentUtils::getTitleFromUrl( "/wiki/User:T367977+T367977", MediaWiki\MediaWikiServices::getInstance()->getMainConfig() )
= "User:T367977 T367977"
Wed, Jun 19, 3:02 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), DiscussionTools
matmarex created T367982: Vector 2022 talk page tab is a blue link even if the talk doesn't exist, should be a red link (but it turns red when clicked).
Wed, Jun 19, 2:42 PM · Web-Team-Backlog (FY2024-25 Q1 Sprint 1), Desktop Improvements (Vector 2022)

Tue, Jun 18

matmarex moved T358985: Admin account created by the installer isn't made global by CentralAuth from Blocked/waiting to Current Sprint on the MediaWiki-Platform-Team board.

That seems to work!

Tue, Jun 18, 10:27 PM · Patch-For-Review, MediaWiki-Installer, ci-test-error, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
matmarex added a comment to T367918: DatabaseUpdater runMaintenance() ignores the $script parameter.

It seems there's no documentation for this that would need to be updated:
https://www.mediawiki.org/w/index.php?title=Special:Search&profile=all&search="runMaintenance"&fulltext=1

Tue, Jun 18, 8:13 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), MediaWiki-Installer
matmarex created T367918: DatabaseUpdater runMaintenance() ignores the $script parameter.
Tue, Jun 18, 8:02 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), MediaWiki-Installer
matmarex renamed T362706: Permit displaying the login / signup page in a popup or iframe from Display the login / signup page in a popup to Permit displaying the login / signup page in a popup or iframe.
Tue, Jun 18, 7:06 PM · MW-1.43-notes (1.43.0-wmf.7; 2024-05-28), SUL3, MediaWiki-Platform-Team, MediaWiki-User-login-and-signup
matmarex renamed T366486: Compare experimental login types on the beta cluster from Compare experimental login popup types on the beta cluster to Compare experimental login types on the beta cluster.
Tue, Jun 18, 7:05 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), SUL3, MediaWiki-Platform-Team, MediaWiki-User-login-and-signup
matmarex renamed T364941: Decide on the login flow in MediaWiki under SUL3 from Use a popup as the default login flow in MediaWiki when appropriate to Decide on the login flow in MediaWiki under SUL3.
Tue, Jun 18, 7:04 PM · MediaWiki-Platform-Team, SUL3, MediaWiki-extensions-CentralAuth, MediaWiki-User-login-and-signup, MediaWiki-Core-AuthManager
matmarex added a parent task for T367911: Explore full-page navigation as the default login flow in MediaWiki under SUL3: T364941: Decide on the login flow in MediaWiki under SUL3.
Tue, Jun 18, 7:03 PM · MediaWiki-Platform-Team, SUL3
matmarex added a parent task for T367912: Explore a popup window as the default login flow in MediaWiki under SUL3: T364941: Decide on the login flow in MediaWiki under SUL3.
Tue, Jun 18, 7:03 PM · MediaWiki-Platform-Team, SUL3
matmarex added a parent task for T367913: Explore an iframe overlay as the default login flow in MediaWiki under SUL3: T364941: Decide on the login flow in MediaWiki under SUL3.
Tue, Jun 18, 7:03 PM · MediaWiki-Platform-Team, SUL3
matmarex added subtasks for T364941: Decide on the login flow in MediaWiki under SUL3: T367911: Explore full-page navigation as the default login flow in MediaWiki under SUL3, T367912: Explore a popup window as the default login flow in MediaWiki under SUL3, T367913: Explore an iframe overlay as the default login flow in MediaWiki under SUL3.
Tue, Jun 18, 7:03 PM · MediaWiki-Platform-Team, SUL3, MediaWiki-extensions-CentralAuth, MediaWiki-User-login-and-signup, MediaWiki-Core-AuthManager
matmarex created T367913: Explore an iframe overlay as the default login flow in MediaWiki under SUL3.
Tue, Jun 18, 7:03 PM · MediaWiki-Platform-Team, SUL3
matmarex created T367912: Explore a popup window as the default login flow in MediaWiki under SUL3.
Tue, Jun 18, 7:03 PM · MediaWiki-Platform-Team, SUL3
matmarex created T367911: Explore full-page navigation as the default login flow in MediaWiki under SUL3.
Tue, Jun 18, 7:03 PM · MediaWiki-Platform-Team, SUL3
matmarex claimed T367891: Remove login popup experiment from the beta cluster.
Tue, Jun 18, 4:15 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), SUL3, MediaWiki-Platform-Team, MediaWiki-User-login-and-signup
matmarex added a parent task for T366486: Compare experimental login types on the beta cluster: T367891: Remove login popup experiment from the beta cluster.
Tue, Jun 18, 4:12 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), SUL3, MediaWiki-Platform-Team, MediaWiki-User-login-and-signup
matmarex added a subtask for T367891: Remove login popup experiment from the beta cluster: T366486: Compare experimental login types on the beta cluster.
Tue, Jun 18, 4:11 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), SUL3, MediaWiki-Platform-Team, MediaWiki-User-login-and-signup
matmarex created T367891: Remove login popup experiment from the beta cluster.
Tue, Jun 18, 4:11 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), SUL3, MediaWiki-Platform-Team, MediaWiki-User-login-and-signup
matmarex updated the task description for T367844: Various buttons on Vector 2022 acquired unexpected link styling when hovered.
Tue, Jun 18, 2:43 AM · MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), Web-Team-Backlog (FY2023-24 Q4 Sprint 6), Desktop Improvements (Vector 2022)
matmarex created T367844: Various buttons on Vector 2022 acquired unexpected link styling when hovered.
Tue, Jun 18, 2:39 AM · MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), Web-Team-Backlog (FY2023-24 Q4 Sprint 6), Desktop Improvements (Vector 2022)
matmarex updated subscribers of T367843: Can't save changes in DiscussionTools when temp accounts are enabled: "You are no longer logged out, so the action could not be completed.".

Could be caused by rMW30287f6be67d: Temporary accounts: Create user on edit save attempts or some related work. Maybe just requires tweaking the assert parameters here? https://gerrit.wikimedia.org/g/mediawiki/extensions/DiscussionTools/+/08b62bc0682b4c07456c5344d8b9745ec0cbb17e/modules/CommentController.js#437

Tue, Jun 18, 2:34 AM · Trust and Safety Product Team, Temporary accounts, DiscussionTools
matmarex created T367843: Can't save changes in DiscussionTools when temp accounts are enabled: "You are no longer logged out, so the action could not be completed.".
Tue, Jun 18, 2:30 AM · Trust and Safety Product Team, Temporary accounts, DiscussionTools
matmarex updated subscribers of T367842: Can't save changes in VE when temp accounts are enabled: jQuery.Deferred exception: matchPatterns is null .

Probably caused by rMW7f588780a048: Support multiple matchPatterns in temp user autocreate config

Tue, Jun 18, 2:27 AM · Trust and Safety Product Team, Temporary accounts, VisualEditor-MediaWiki, VisualEditor
matmarex created T367842: Can't save changes in VE when temp accounts are enabled: jQuery.Deferred exception: matchPatterns is null .
Tue, Jun 18, 2:27 AM · Trust and Safety Product Team, Temporary accounts, VisualEditor-MediaWiki, VisualEditor
matmarex updated subscribers of T367841: Display of custom footer icons is broken.

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1027178

Tue, Jun 18, 2:24 AM · MediaWiki-General
matmarex created T367841: Display of custom footer icons is broken.
Tue, Jun 18, 2:21 AM · MediaWiki-General
matmarex added a comment to T344934: "Temporary user" popup is not visible after section edits.

I do like the idea of using two toast messages, my question is how long would the second toast message display for? Or if it is permanently visible as suggested, then my assumption is users click on it to dismiss, and I wonder if all users will understand that this is how to dismiss the message?

Tue, Jun 18, 1:53 AM · Patch-For-Review, Web-Team-Backlog, MinervaNeue, Desktop Improvements (Vector 2022), Temporary accounts

Mon, Jun 17

matmarex closed T366486: Compare experimental login types on the beta cluster as Resolved.

We got in touch with the design team, whose response is here: https://docs.google.com/document/d/1DQM_xi7fK2_YfFMV6mulGYTxmmr_tADHRhLrI7x-jMk/edit#heading=h.e4e6d6c4proc

Mon, Jun 17, 9:01 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), SUL3, MediaWiki-Platform-Team, MediaWiki-User-login-and-signup
matmarex closed T366486: Compare experimental login types on the beta cluster, a subtask of T364941: Decide on the login flow in MediaWiki under SUL3, as Resolved.
Mon, Jun 17, 9:01 PM · MediaWiki-Platform-Team, SUL3, MediaWiki-extensions-CentralAuth, MediaWiki-User-login-and-signup, MediaWiki-Core-AuthManager
matmarex closed T361695: The log type {log_type_one} has the same translation as {log_type_two} for {lang}. {log_type_one} will not be displayed in the drop down menu on Special:Log. as Resolved.

The az errors stopped with wmf.9 deployment. I deleted the override: https://az.wikipedia.org/wiki/MediaViki:Log-name-tag

Mon, Jun 17, 7:05 PM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), WMF-General-or-Unknown, Wikimedia-production-error
matmarex closed T367727: RestSandbox does not show endpoint details as Resolved.
Mon, Jun 17, 6:01 PM · MediaWiki-REST-API, MW-Interfaces-Team
matmarex closed T366508: Compare our login popup to other sites, a subtask of T364941: Decide on the login flow in MediaWiki under SUL3, as Resolved.
Mon, Jun 17, 5:43 PM · MediaWiki-Platform-Team, SUL3, MediaWiki-extensions-CentralAuth, MediaWiki-User-login-and-signup, MediaWiki-Core-AuthManager
matmarex closed T366508: Compare our login popup to other sites as Resolved.
Mon, Jun 17, 5:43 PM · SUL3, MediaWiki-Platform-Team
matmarex added a comment to T366508: Compare our login popup to other sites.

For the other websites, I took a few screenshots for reference. Some of these integrations aren't very good looking.

Mon, Jun 17, 5:42 PM · SUL3, MediaWiki-Platform-Team
matmarex added a comment to T366508: Compare our login popup to other sites.

We probably won't use the popup approach in the end, so I will cut this investigation short, but I wanted to note what I have already learned. I had a closer look at https://archive.org/donate and the two popup auth providers available there. Observations:

Mon, Jun 17, 5:24 PM · SUL3, MediaWiki-Platform-Team
matmarex claimed T367727: RestSandbox does not show endpoint details.
Mon, Jun 17, 4:01 PM · MediaWiki-REST-API, MW-Interfaces-Team
matmarex merged task T367759: SVG File not displaying correctly - Microsoft Edge into T367645: The background of some SVG maps is not rendered.
Mon, Jun 17, 2:34 PM · Browser-Support-Microsoft-Edge
matmarex merged T367759: SVG File not displaying correctly - Microsoft Edge into T367645: The background of some SVG maps is not rendered.
Mon, Jun 17, 2:34 PM · User-notice, Wikimedia-SVG-rendering
matmarex closed T115430: Undeploy the 'Cologne Blue' and 'Modern' skins from Wikimedia production, as no-one is keeping them working as Declined.

This task was previously declined.

Mon, Jun 17, 1:42 PM · Modern, CologneBlue, Wikimedia-Site-requests, Web-Team-Backlog

Sun, Jun 16

matmarex added a comment to T367645: The background of some SVG maps is not rendered.

I think the new behavior is standards-compliant, and the old one is incorrect. The file has a <g> element inside a <clipPath> element, which is apparently not allowed: https://developer.mozilla.org/en-US/docs/Web/SVG/Element/clipPath#usage_context (and was never allowed, here's a spec from 2001: https://www.w3.org/TR/SVG10/masking.html#EstablishingANewClippingPath).

Sun, Jun 16, 11:22 PM · User-notice, Wikimedia-SVG-rendering
matmarex added a project to T367638: Wikimedia\Assert\ParameterAssertionException: Bad value for parameter $title: invalid name: Wikidata.

More context:

Sun, Jun 16, 10:41 PM · wmde-wikidata-tech, Wikidata, Wikimedia-production-error, Growth-Team, Notifications
matmarex added a comment to T367671: Difference between VisualEditor and WikiEditor when using preloadparams with non-consecutive indices.

In both PHP and JS code, this ends up being represented as an array with a gap – try $request->getArray( 'preloadparams' ) in PHP, mw.util.getArrayParam( 'preloadparams' ) in JS.

Sun, Jun 16, 9:36 PM · VisualEditor
matmarex renamed T367629: Table is cut off on Vector 2022 when following a float (potentially entire table is invisible) from Table is invisible on Vector 2022 to Table is cut off on Vector 2022 when following a float (potentially entire table is invisible).
Sun, Jun 16, 8:00 PM · Web-Team-Backlog, Desktop Improvements (Vector 2022)
matmarex added a comment to T367629: Table is cut off on Vector 2022 when following a float (potentially entire table is invisible).

Took me just a few minutes to find affected articles on Wikipedia. https://en.wikipedia.org/wiki/List_of_presidents_of_Burundi (and lots of other articles in https://en.wikipedia.org/wiki/Category:Lists_of_national_presidents)

Sun, Jun 16, 8:00 PM · Web-Team-Backlog, Desktop Improvements (Vector 2022)

Sat, Jun 15

matmarex added a comment to T367629: Table is cut off on Vector 2022 when following a float (potentially entire table is invisible).

Maybe, but this is still very unexpected behavior.

Sat, Jun 15, 11:43 AM · Web-Team-Backlog, Desktop Improvements (Vector 2022)
matmarex created T367629: Table is cut off on Vector 2022 when following a float (potentially entire table is invisible).
Sat, Jun 15, 10:42 AM · Web-Team-Backlog, Desktop Improvements (Vector 2022)

Fri, Jun 14

matmarex merged T363828: Missing whitespace in headings in MobileFrontEnd + Parsoid into T367468: Heading CSS changes in Minerva cause issues with styled headings.
Fri, Jun 14, 9:37 PM · Verified, MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), Web-Team-Backlog (FY2023-24 Q4 Sprint 6), Regression, MinervaNeue
matmarex merged task T363828: Missing whitespace in headings in MobileFrontEnd + Parsoid into T367468: Heading CSS changes in Minerva cause issues with styled headings.
Fri, Jun 14, 9:36 PM · MobileFrontend, Content-Transform-Team-WIP, Parsoid-Read-Views
matmarex added a comment to T367468: Heading CSS changes in Minerva cause issues with styled headings.

@TheDJ I may be misunderstanding your suggestion, but I don't think that would help – the text would still be laid out using the flex layout, which would interfere with the normal line wrapping. My solution is to remove the display:flex where it wasn't supposed to apply (it should be applied only to the wrappers around the headings containing the section toggle, the heading text, and the section edit link [and optional DiscussionTools stuff] – not to the heading text itself, but it was applied there erroneously due to a conflict between styles for the old and new headings).

Fri, Jun 14, 9:26 PM · Verified, MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), Web-Team-Backlog (FY2023-24 Q4 Sprint 6), Regression, MinervaNeue
matmarex added a project to T367559: Cloud VPS "visualeditor" project Buster deprecation: Editing-team.

Excusing myself and the folks who were added to the project to have access to Patch demo (which is in this project for historical reasons, and which is running on a more recent VM already).

Fri, Jun 14, 3:02 PM · Editing-team, Cloud-VPS (Debian Buster Deprecation)

Thu, Jun 13

matmarex claimed T367468: Heading CSS changes in Minerva cause issues with styled headings.

That's my bad, sorry. Your investigation is exactly right on all counts. I will get the fix deployed soon (Monday at the latest).

Thu, Jun 13, 11:21 PM · Verified, MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), Web-Team-Backlog (FY2023-24 Q4 Sprint 6), Regression, MinervaNeue
VPuffetMichel awarded T315510: Start maintenance script to backfill talk page comment database a Stroopwafel token.
Thu, Jun 13, 8:14 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Goal, MW-1.40-notes (1.40.0-wmf.6; 2022-10-17), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Editing-team (Kanban Board), TPP-Phase1, DiscussionTools
matmarex added a comment to T343994: OutputPage::setPageTitle() should not accept Message objects, introduce OutputPage::setPageTitleMsg().

Production logstash: https://logstash.wikimedia.org/goto/ca022838d6eb4b350437e62dfe42ab66

Thu, Jun 13, 6:33 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), MW-1.41-notes, MW-1.42-notes, MW-1.41-release, Patch-For-Review, MediaWiki-General, MediaWiki-Internationalization
matmarex added a comment to T315510: Start maintenance script to backfill talk page comment database.

I concur, it seems like unnecessary work at this point.

Thu, Jun 13, 3:13 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Goal, MW-1.40-notes (1.40.0-wmf.6; 2022-10-17), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Editing-team (Kanban Board), TPP-Phase1, DiscussionTools