(Go: >> BACK << -|- >> HOME <<)

Page MenuHomePhabricator

Change the heading markup for non-default skins
Closed, ResolvedPublic0 Estimated Story Points

Description

NOTE: This task can be worked on when https://gerrit.wikimedia.org/r/c/mediawiki/core/+/842859 is merged.

Expected Visual changes

SkinBeforeAfter
Modern{F53342262}{F53342280}

Background

The content transform team are making changes to the HTML. Thanks to the way this has been built the changes are easily revertable if necessary.

User story

As a user I want minimal disruption to my wiki experience while we migrate from the old HTML format to the new HTML format.

Deployment plan

  • The markup is first deployed on skins with approx < 1% of users - CologneBlue, Modern, Timeless, Nostaglia , Monobook (merge by end of day 20th)
  • A User-notice should be filed T365078
  • The configuration is updated to support the rendering of the new heading markup
  • Logstash is monitored and we address any problems with gadgets relating to this change.

Not done

  • Provided we have not identified any issues in 7 days we will then update the markup on Minerva skin and we'll move this to QA (merge on 28th)

Reason: We found errors so deferred this to sprint 5.

Communication criteria - does this need an announcement or discussion?

When the date for deploys is known and finalized, a user notice should be filed prior to deployment on Monobook and Timeless by tagging this phabricator ticket with user-notice.

sign off steps

  • Create a task for rolling out the change on Vector 2022 and Vector skins. > T365736

Roll back plan

Since skins should be backwards compatible with old and new markup it is safe to revert a patch at any stage in the deployment process in event of significant issues. IF significant issues are encountered, work on this task should pause until that is taken care of.

Event Timeline

Change #1022356 had a related patch set uploaded (by Jdlrobson; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] Indicate support for new heading HTML

https://gerrit.wikimedia.org/r/1022356

Jdlrobson updated the task description. (Show Details)

Change #1022357 had a related patch set uploaded (by Jdlrobson; author: Bartosz Dziewoński):

[mediawiki/skins/Modern@master] Indicate support for new heading HTML

https://gerrit.wikimedia.org/r/1022357

Change #1022354 had a related patch set uploaded (by Jdlrobson; author: Bartosz Dziewoński):

[mediawiki/skins/CologneBlue@master] Indicate support for new heading HTML

https://gerrit.wikimedia.org/r/1022354

Change #1031610 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Disable wgParserEnableLegacyMediaDOM

https://gerrit.wikimedia.org/r/1031610

Change #1022357 merged by jenkins-bot:

[mediawiki/skins/Modern@master] Indicate support for new heading HTML

https://gerrit.wikimedia.org/r/1022357

Change #1022354 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@master] Indicate support for new heading HTML

https://gerrit.wikimedia.org/r/1022354

Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 0.May 16 2024, 6:15 PM

Change #1031610 merged by jenkins-bot:

[operations/mediawiki-config@master] Disable wgParserEnableLegacyMediaDOM

https://gerrit.wikimedia.org/r/1031610

Mentioned in SAL (#wikimedia-operations) [2024-05-20T20:06:48Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:1024813|Introduce sample overrides to web_ui_actions (T361962)]], [[gerrit:1031610|Disable wgParserEnableLegacyMediaDOM (T363597)]], [[gerrit:1031458|Disable last remaining projects using share user scripts (T301212)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-20T20:09:25Z] <urbanecm@deploy1002> urbanecm and jdlrobson and ksarabia: Backport for [[gerrit:1024813|Introduce sample overrides to web_ui_actions (T361962)]], [[gerrit:1031610|Disable wgParserEnableLegacyMediaDOM (T363597)]], [[gerrit:1031458|Disable last remaining projects using share user scripts (T301212)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-20T20:25:06Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:1024813|Introduce sample overrides to web_ui_actions (T361962)]], [[gerrit:1031610|Disable wgParserEnableLegacyMediaDOM (T363597)]], [[gerrit:1031458|Disable last remaining projects using share user scripts (T301212)]] (duration: 18m 18s)

Okay this should now go out with the train to Monobook, CologneBlue, Modern, Timeless and Nostalgia.
This is blocked until Wednesday at which point we can verify it is working, if any JS errors are spiking and if anyone in the community is complaining about broken gadgets.
On Monday 27th we should then be able to make a decision around whether rolling out further to Minerva.

Jdlrobson renamed this task from Change the heading markup for 3rd party and Minerva skins to Change the heading markup for non-default skins.Thu, May 23, 4:13 PM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Edtadros.
Jdlrobson closed this task as Resolved.EditedThu, May 23, 4:19 PM
Jdlrobson claimed this task.

Given the few bug reports trickling in (see T13555#9824143 where they are being reported) I've scheduled T365736 for Tuesday 4th June to give us more time to address gadgets before exposing this further. I suggest we do Minerva and legacy Vector in the next batch!

Nope - not in a way that is helpful at this stage! We'll relying on community reports for now. Thanks for checking!