(Go: >> BACK << -|- >> HOME <<)

Page MenuHomePhabricator

Fix the most common "Module not loadable on target mobile" warnings (December 2022)
Closed, ResolvedPublicBUG REPORT

Description

Following the example in T235712, this will be a new effort to work towards removing the targets system.

In https://gerrit.wikimedia.org/r/c/mediawiki/core/+/859643/ logging was restored in December 2022 to log warnings for any instances where ResourceLoader modules are added to the page and silently removed on mobile.

A dashboard presents the data collected https://logstash.wikimedia.org/goto/42d01f98f9e840a3af61d018b87dee13

This is a timeboxed task to fix as many offenders as possible. Your help merging fixes is appreciated!

TODO

code repositorymoduleFixed in patchmerged?
coremediawiki.action.view.filepage, filepage,mediawiki.action.view.metadatahttps://gerrit.wikimedia.org/r/c/mediawiki/core/+/865803
coremediawiki.special.userlogin.login.styles, mediawiki.special.userlogin.signup.styleshttps://gerrit.wikimedia.org/r/c/mediawiki/core/+/865804
Extension:Wikibasewikibase.ui.entityViewInit, wikibase.ui.entitysearch,jquery.wikibase.toolbar.styles,wikibase.common, wikibase.client.action.edit.collapsibleFooter, wikibase.client.linkitem.inithttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/875440
Extension:Wikibasewikibase.client.inithttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/865229
Extension:ContentTranslationext.cx.eventlogging.campaigns,ext.cx.entrypoints.contributionsmenuhttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/866487, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/866524
Extension:Citeext.cite.ux-enhancementshttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/866488
extensions / Wikidata.orgext.wikidata-org.badgeshttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikidata.org/+/867209T325084
Extension:Citoidext.citoid.wikibase.inithttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/Citoid/+/867205
Extension:WikibaseQualityConstraintswikibase.quality.constraints.suggestionshttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/86720
Extension:PropertySuggesterpropertySuggester.suggestionshttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/PropertySuggester/+/867210
Extension:ProofreadPageext.proofreadpage.article,ext. proofreadpage.page.navigation, ext.proofreadpage.pagehttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/867665
Extension:CharInsertext.charinsert.styles,ext.charinserthttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/CharInsert/+/865805
extensions / Wikisourceext.wikisource.downloadhttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikisource/+/867666
Extension:CodeMirrorext.CodeMirrorhttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/CodeMirror/+/875434
Extension:Scribuntoext.scribunto.logs,ext.scribunto.errorshttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/Scribunto/+/867204/
Extension:AdvancedSearchext.advancedSearch.initialstyles,ext.advancedSearch.inithttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/AdvancedSearch/+/867201
Extension:ImageSuggestionsext.imagesuggestions.notifications.styleshttps://github.com/wikimedia/mediawiki-extensions-ImageSuggestions/pull/1
Extension:ShortUrlext.shortUrlhttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/ShortUrl/+/866643..
Extension:Mathext.math.scriptshttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/867667
Extension:TemplateWizardext.TemplateWizardhttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/TemplateWizard/+/875432
Extension:TwoColConflictext.TwoColConflict.JSCheckhttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/TwoColConflict/+/875433
Extension:WikiEditorext.wikiEditor,ext.wikiEditor.styles,ext.wikiEditorhttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiEditor/+/875431
Extension:TimedMediaHandlerext.tmh.transcodetablehttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/TimedMediaHandler/+/866629
coremediawiki.userSuggest,mediawiki.filewarning,mediawiki.action.edit.collapsibleFooter,mediawiki.page.image.pagination, mediawiki.rcfilters.highlightCircles.seenunseen.styles,mediawiki.special.watchlist,mediawiki.special.userrightshttps://gerrit.wikimedia.org/r/c/mediawiki/core/+/867678
coremediawiki.page.gallery, mediawiki.page.gallery.slideshowT242143
Extension:Thanksext.thanks.corethank,ext.thanks.flowthankhttps://gerrit.wikimedia.org/r/c/mediawiki/extensions/Thanks/+/867295

The following had less than 70,000 warnings in a 7 day period so are not widespread enough to be a concern:

Extension:JsonConfigext.jsonConfig....
Extension:Wikihieroext.wikihiero....
Extension:TocTreeext.toctree....
GuidedTourext.guidedTour.tour.homepage_discovery....
Growthext.growthExperiments.MidEditSignup....
CentralAuthext.centralauth,ext.centralauth.globaluserautocomplete....
Extension:Pdfhandlepdfhandler.messages....
?......

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/Wikidata.orgmaster+2 -3
mediawiki/extensions/ShortUrlmaster+2 -1
mediawiki/extensions/TemplateWizardmaster+1 -1
mediawiki/extensions/CodeMirrormaster+11 -0
mediawiki/extensions/Wikibasemaster+5 -0
mediawiki/extensions/Wikisourcemaster+7 -0
mediawiki/extensions/ProofreadPagemaster+36 -3
mediawiki/extensions/AdvancedSearchmaster+20 -0
mediawiki/extensions/TwoColConflictmaster+3 -1
mediawiki/extensions/CharInsertmaster+2 -0
mediawiki/extensions/CharInsertmaster+9 -0
mediawiki/extensions/Wikibasemaster+109 -0
mediawiki/extensions/CodeEditormaster+4 -0
mediawiki/extensions/WikiEditormaster+2 -0
mediawiki/extensions/Wikibasemaster+20 -5
mediawiki/coremaster+9 -1
mediawiki/extensions/Scribuntomaster+2 -0
mediawiki/extensions/Citoidmaster+6 -1
mediawiki/extensions/Citemaster+4 -0
mediawiki/extensions/Thanksmaster+12 -0
mediawiki/extensions/Mathmaster+21 -1
mediawiki/extensions/TimedMediaHandlermaster+4 -0
mediawiki/extensions/PropertySuggestermaster+10 -0
mediawiki/extensions/ImageSuggestionsmaster+6 -1
mediawiki/extensions/WikibaseQualityConstraintsmaster+8 -0
mediawiki/extensions/ContentTranslationmaster+3 -1
mediawiki/extensions/ContentTranslationmaster+9 -5
mediawiki/extensions/ContentTranslationmaster+4 -0
mediawiki/corewmf/1.40.0-wmf.13+4 -0
mediawiki/coremaster+6 -4
mediawiki/coremaster+4 -0
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 865810 abandoned by Jdlrobson:

[mediawiki/extensions/ContentTranslation@master] Fixes Module not loadable on target mobile warning

Reason:

Thanks Santhosh!

https://gerrit.wikimedia.org/r/865810

Change 867201 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/AdvancedSearch@master] Fixes "Module not loadable on target mobile" warnings

https://gerrit.wikimedia.org/r/867201

Change 867204 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Scribunto@master] Fixes "Module not loadable on target mobile" warnings

https://gerrit.wikimedia.org/r/867204

Change 867205 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Citoid@master] Don't add ext.citoid.wikibase.init to mobile pages

https://gerrit.wikimedia.org/r/867205

Change 867207 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikibaseQualityConstraints@master] Fixes "Module not loadable on target mobile" warnings

https://gerrit.wikimedia.org/r/867207

Change 867209 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Wikidata.org@master] Load ext.wikidata-org.badges on mobile target

https://gerrit.wikimedia.org/r/867209

Change 867210 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/PropertySuggester@master] Fixes "Module not loadable on target mobile" warnings

https://gerrit.wikimedia.org/r/867210

Change 867259 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ImageSuggestions@master] Fixes: "Module not loadable on target mobile" warnings

https://gerrit.wikimedia.org/r/867259

Change 867295 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Thanks@master] Enable thanks JavaScript on mobile

https://gerrit.wikimedia.org/r/867295

Change 867207 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Fixes "Module not loadable on target mobile" warnings

https://gerrit.wikimedia.org/r/867207

Change 867259 merged by jenkins-bot:

[mediawiki/extensions/ImageSuggestions@master] Fixes: "Module not loadable on target mobile" warnings

https://gerrit.wikimedia.org/r/867259

Change 867665 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ProofreadPage@master] Load Proofread modules on mobile site

https://gerrit.wikimedia.org/r/867665

Change 867666 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Wikisource@master] Enable Wikisource.org modules on mobile domain

https://gerrit.wikimedia.org/r/867666

Change 867667 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Math@master] Load ext.math.scripts on moble

https://gerrit.wikimedia.org/r/867667

Jdlrobson updated the task description. (Show Details)

Change 867210 merged by jenkins-bot:

[mediawiki/extensions/PropertySuggester@master] Fixes "Module not loadable on target mobile" warnings

https://gerrit.wikimedia.org/r/867210

Change 867678 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Enable several modules on mobile site

https://gerrit.wikimedia.org/r/867678

Jdlrobson updated the task description. (Show Details)

Change 866629 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Load ext.tmh.transcodetable on mobile

https://gerrit.wikimedia.org/r/866629

Jdlrobson updated the task description. (Show Details)

Change 867667 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Load Math ResourceLoader modules on mobile

https://gerrit.wikimedia.org/r/867667

Change 867295 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] Enable thanks JavaScript on mobile

https://gerrit.wikimedia.org/r/867295

Change 866488 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Add 'ext.cite.ux-enhancements to mobile pages

https://gerrit.wikimedia.org/r/866488

Change 867205 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Don't add ext.citoid.wikibase.init to mobile pages

https://gerrit.wikimedia.org/r/867205

Jdlrobson updated the task description. (Show Details)

Change 867204 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Fixes "Module not loadable on target mobile" warnings

https://gerrit.wikimedia.org/r/867204

Change 867678 merged by jenkins-bot:

[mediawiki/core@master] Enable several modules on mobile site

https://gerrit.wikimedia.org/r/867678

Change 875431 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikiEditor@master] Load WikiEditor modules on mobile.

https://gerrit.wikimedia.org/r/875431

Change 875432 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/TemplateWizard@master] Load ext.TemplateWizard on mobile domain

https://gerrit.wikimedia.org/r/875432

Change 875433 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/TwoColConflict@master] Load ext.TwoColConflict.JSCheck on mobile domain

https://gerrit.wikimedia.org/r/875433

Change 875434 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/CodeMirror@master] Enable CodeMirror code on mobile domain

https://gerrit.wikimedia.org/r/875434

Change 875440 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Wikibase@master] Explicitly set modules as desktop targetted

https://gerrit.wikimedia.org/r/875440

Change 865809 abandoned by Jdlrobson:

[mediawiki/extensions/Wikibase@master] Intentionally restrict modules to mobile domain

Reason:

See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/875440 instead

https://gerrit.wikimedia.org/r/865809

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/fcbbcf787a/w

Change 875994 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/CodeEditor@master] Enable CodeEditor modules on mobile

https://gerrit.wikimedia.org/r/875994

Change 875431 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Load WikiEditor modules on mobile.

https://gerrit.wikimedia.org/r/875431

Change 875994 merged by jenkins-bot:

[mediawiki/extensions/CodeEditor@master] Enable CodeEditor modules on mobile

https://gerrit.wikimedia.org/r/875994

Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

Change 876224 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/CharInsert@master] Explicitly do not add modules to page in mobile site

https://gerrit.wikimedia.org/r/876224

Change 875440 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Explicitly set modules as desktop targeted

https://gerrit.wikimedia.org/r/875440

Change 876224 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/CharInsert@master] Explicitly do not add modules to page in mobile site

Reason:

Merging https://gerrit.wikimedia.org/r/865805 instead

https://gerrit.wikimedia.org/r/876224

Change 865805 merged by jenkins-bot:

[mediawiki/extensions/CharInsert@master] Add CharInsert modules to editor on mobile domain

https://gerrit.wikimedia.org/r/865805

Change 875433 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Load ext.TwoColConflict.JSCheck on mobile domain

https://gerrit.wikimedia.org/r/875433

Change 867201 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Enable AdvancedSearch on target mobile

https://gerrit.wikimedia.org/r/867201

Change 867665 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Set Proofread module targets explicitly

https://gerrit.wikimedia.org/r/867665

Change 867666 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] Enable Wikisource.org modules on mobile domain

https://gerrit.wikimedia.org/r/867666

Change 865808 abandoned by Jdlrobson:

[mediawiki/extensions/Wikibase@master] Set mobile target on modules being added to the page

Reason:

We did https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/875440 instead.

https://gerrit.wikimedia.org/r/865808

Change 875434 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Enable CodeMirror code on mobile domain

https://gerrit.wikimedia.org/r/875434

Change 875432 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Load ext.TemplateWizard on mobile domain

https://gerrit.wikimedia.org/r/875432

Change 866643 abandoned by Jdlrobson:

[mediawiki/extensions/ShortUrl@master] Set ext.shortUrl to target mobile

Reason:

Now https://gerrit.wikimedia.org/r/c/mediawiki/core/+/865811 has been merged this code automatically loads on mobile and desktop so this patch is no longer needed.

https://gerrit.wikimedia.org/r/866643

Change 867209 abandoned by Jdlrobson:

[mediawiki/extensions/Wikidata.org@master] Load ext.wikidata-org.badges on mobile target

Reason:

Update: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/865811 has been merged so this code is now automatically loaded.

https://gerrit.wikimedia.org/r/867209

Jdlrobson claimed this task.

This work is now done.
Follow up work is T328498 and T328497

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/fcbbcf787a/w/