(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T310859

Remove dead code outside the transclusionDialogNewSidebar flag
Closed, ResolvedPublic
Actions

Description

After defaulting the transclusionDialogNewSidebar flag to true in 806240 we can now remove the dead code paths that can never be reached anymore.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-Fisch created this task.Jun 17 2022, 8:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2022, 8:18 AM
gerritbot added a comment.Jun 17 2022, 8:20 AM

Change 806238 had a related patch set uploaded (by WMDE-Fisch; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove obsolete "search for a parameter" page and widgets

https://gerrit.wikimedia.org/r/806238

gerritbot added a project: Patch-For-Review.Jun 17 2022, 8:20 AM
awight moved this task from Backlog to Watching on the WMDE-Templates-FocusArea board.Jun 17 2022, 9:15 AM
gerritbot added a comment.Jun 17 2022, 9:39 AM

Change 806380 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Remove dead code in MWTransclusionContentPage

https://gerrit.wikimedia.org/r/806380

gerritbot added a comment.Jun 17 2022, 10:26 AM

Change 806387 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Remove dead code in MWParameterPage

https://gerrit.wikimedia.org/r/806387

gerritbot added a comment.Jun 17 2022, 10:47 AM

Change 806390 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Remove dead code in MWTemplatePlaceholderPage

https://gerrit.wikimedia.org/r/806390

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-06-08 board.Jun 17 2022, 10:57 AM
gerritbot added a comment.Jun 17 2022, 11:39 AM

Change 806238 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove obsolete "search for a parameter" page and widgets

https://gerrit.wikimedia.org/r/806238

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 17 2022, 12:00 PM
gerritbot added a comment.Jun 17 2022, 12:51 PM

Change 806387 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove dead code in MWParameterPage

https://gerrit.wikimedia.org/r/806387

gerritbot added a comment.Jun 20 2022, 7:49 AM

Change 806853 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove small pieces of dead code from MWParameterPage

https://gerrit.wikimedia.org/r/806853

gerritbot added a comment.Jun 20 2022, 7:58 AM

Change 806855 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Clear all old BookletLayout OutlineItems

https://gerrit.wikimedia.org/r/806855

gerritbot added a comment.Jun 20 2022, 8:24 AM

Change 806380 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove dead code in MWTransclusionContentPage

https://gerrit.wikimedia.org/r/806380

gerritbot added a comment.Jun 20 2022, 8:29 AM

Change 806853 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove small pieces of dead code from MWParameterPage

https://gerrit.wikimedia.org/r/806853

gerritbot added a comment.Jun 20 2022, 8:53 AM

Change 806390 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove dead code in MWTemplatePlaceholderPage

https://gerrit.wikimedia.org/r/806390

gerritbot added a comment.Jun 20 2022, 9:12 AM

Change 806859 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove invisible stuff from BookletLayout OutlineItems

https://gerrit.wikimedia.org/r/806859

gerritbot added a comment.Jun 20 2022, 10:09 AM

Change 806859 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove invisible stuff from BookletLayout OutlineItems

https://gerrit.wikimedia.org/r/806859

WMDE-Fisch claimed this task.Jun 20 2022, 12:58 PM
gerritbot added a comment.Jun 20 2022, 1:45 PM

Change 806909 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Remove dead code in MWTransclusionDialog

https://gerrit.wikimedia.org/r/806909

gerritbot added a comment.Jun 20 2022, 2:07 PM

Change 806913 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Remove dead code in MWTemplateDialog

https://gerrit.wikimedia.org/r/806913

gerritbot added a comment.Jun 21 2022, 12:26 PM

Change 807115 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] [WIP] Remove newSidbare CSS and merge CSS rules

https://gerrit.wikimedia.org/r/807115

gerritbot added a comment.Jun 21 2022, 12:29 PM

Change 807116 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Remove dead code in MWTemplatePage

https://gerrit.wikimedia.org/r/807116

awight moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-06-08 board.Jun 21 2022, 12:32 PM
gerritbot added a comment.Jun 21 2022, 2:49 PM

Change 806909 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove dead code in MWTransclusionDialog

https://gerrit.wikimedia.org/r/806909

gerritbot added a comment.Jun 21 2022, 2:52 PM

Change 806913 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove dead code in MWTemplateDialog

https://gerrit.wikimedia.org/r/806913

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.18; 2022-06-27); removed MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 21 2022, 3:00 PM
gerritbot added a comment.Jun 22 2022, 6:29 AM

Change 807116 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove dead code in MWTemplatePage

https://gerrit.wikimedia.org/r/807116

WMDE-Fisch added a project: WMDE-TechWish-Sprint-2022-06-22.Jun 22 2022, 8:10 AM
Tobi_WMDE_SW moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-06-22 board.Jun 22 2022, 8:11 AM
gerritbot added a comment.Jun 23 2022, 10:11 AM

Change 807930 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove duplicate "add parameters" method from template dialog

https://gerrit.wikimedia.org/r/807930

gerritbot added a comment.Jun 23 2022, 10:24 AM

Change 807933 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Inline template parameter id to page name connection

https://gerrit.wikimedia.org/r/807933

gerritbot added a comment.Jun 23 2022, 11:10 AM

Change 807933 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Inline template parameter id to page name connection

https://gerrit.wikimedia.org/r/807933

gerritbot added a comment.Jun 23 2022, 11:17 AM

Change 807930 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove duplicate "add parameters" method from template dialog

https://gerrit.wikimedia.org/r/807930

gerritbot added a comment.Jun 23 2022, 11:59 AM

Change 807960 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove unused return value from addPromptedParameters() method

https://gerrit.wikimedia.org/r/807960

gerritbot added a comment.Jun 23 2022, 12:27 PM

Change 807960 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove unused return value from addPromptedParameters() method

https://gerrit.wikimedia.org/r/807960

gerritbot added a comment.Jun 23 2022, 2:49 PM

Change 808001 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Unhoist variables & remove dead code from BookletLayout fork

https://gerrit.wikimedia.org/r/808001

WMDE-Fisch moved this task from Watching to In sprint on the WMDE-Templates-FocusArea board.Jun 24 2022, 9:56 AM
gerritbot added a comment.Jun 24 2022, 12:32 PM

Change 807115 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove newSidbar CSS and merge CSS rules

https://gerrit.wikimedia.org/r/807115

gerritbot added a comment.Jun 28 2022, 7:07 AM

Change 808001 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Unhoist variables & remove dead code from BookletLayout fork

https://gerrit.wikimedia.org/r/808001

gerritbot added a comment.Jun 28 2022, 9:55 AM

Change 809129 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Remove deprecated CSS from old add parameter search

https://gerrit.wikimedia.org/r/809129

gerritbot added a comment.Jun 28 2022, 2:56 PM

Change 809129 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove deprecated CSS from old add parameter search

https://gerrit.wikimedia.org/r/809129

lilients_WMDE moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2022-06-22 board.Jun 28 2022, 3:14 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jun 30 2022, 3:28 PM
awight closed this task as Resolved.Jul 4 2022, 1:57 PM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.21; 2022-07-18); removed MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jul 11 2022, 6:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits