(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T208831

Make Apertium tests independent of Labs service
Closed, ResolvedPublic
Actions

Description

2 tests from Apertium MT were failing in Production/master CI (See: https://integration.wikimedia.org/ci/job/npm-node-6-docker/3282/console for full log) due to dependencies on apertium-apy service running on Labs. This is not OK and it is hard to debug and can block merge changes of cxserver in Production and updating it.

Details

SubjectRepoBranchLines +/-
Use TestClient for tests, instead of a real Apertium instancemediawiki/services/cxservermaster+9 -4
Customize query in gerrit

Related Objects

Event Timeline

KartikMistry created this task.Nov 6 2018, 8:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 6 2018, 8:23 AM
KartikMistry renamed this task from Apertium test failures to Apertium test failures in cxserver.Nov 6 2018, 8:24 AM
KartikMistry triaged this task as High priority.
KartikMistry updated the task description. (Show Details)
Nikerabbit added a comment.Nov 6 2018, 9:38 AM

http://apertium.wmflabs.org/ is down (probably after the cloud services migration)

Nikerabbit raised the priority of this task from High to Unbreak Now!.Nov 6 2018, 9:39 AM
Nikerabbit added a project: Language-Team (Language-2018-October-December).

Rising priority to UBN! as is the custom for merge blockers.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptNov 6 2018, 9:39 AM
Nikerabbit added a comment.Nov 6 2018, 9:51 AM
ssh language-apertium2.eqiad.wmflabs
service apertium-apy status
● apertium-apy.service - Translation server and API for Apertium
   Loaded: loaded (/lib/systemd/system/apertium-apy.service; disabled; vendor preset: enabled)
   Active: inactive (dead)
     Docs: http://wiki.apertium.org/wiki/Apertium-apy

@KartikMistry Are there docs for this service? It took a while for me to figure out the service name etc.

I restarted it, but why wasn't it running by default?

Also, it's not nice that our tests depend on a labs service. They should be network-less by default.

KartikMistry added a comment.Nov 6 2018, 11:03 AM
In T208831#4723758, @Nikerabbit wrote:

@KartikMistry Are there docs for this service? It took a while for me to figure out the service name etc.

I restarted it, but why wasn't it running by default?

https://www.mediawiki.org/wiki/Content_translation/Machine_Translation/Apertium/Service

Also, it's not nice that our tests depend on a labs service. They should be network-less by default.

Agree. I'll rename this task and reuse it.

KartikMistry renamed this task from Apertium test failures in cxserver to Make Apertium tests independent of Labs service.Nov 6 2018, 11:07 AM
KartikMistry lowered the priority of this task from Unbreak Now! to High.
KartikMistry updated the task description. (Show Details)
• santhosh claimed this task.Nov 7 2018, 7:26 AM
gerritbot subscribed.Nov 7 2018, 8:49 AM

Change 472103 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Use TestClient for tests, instead of a real Apertium instanace

https://gerrit.wikimedia.org/r/472103

gerritbot added a project: Patch-For-Review.Nov 7 2018, 8:49 AM
• santhosh moved this task from Backlog to In Review on the Language-Team (Language-2018-October-December) board.Nov 7 2018, 8:50 AM
gerritbot added a comment.Nov 7 2018, 10:19 AM

Change 472103 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Use TestClient for tests, instead of a real Apertium instance

https://gerrit.wikimedia.org/r/472103

• Petar.petkovic removed a project: Patch-For-Review.Nov 7 2018, 10:43 AM
• Petar.petkovic moved this task from In Review to QA on the Language-Team (Language-2018-October-December) board.
• Petar.petkovic moved this task from Backlog to Page contents issues on the CX-cxserver board.
Nikerabbit added a comment.Nov 8 2018, 1:42 PM

Once this is deployed to production, the (Apertium) requests in https://grafana.wikimedia.org/dashboard/db/service-cxserver?orgId=1&from=now%2Fw&to=now should go down dramatically.

KartikMistry added a comment.Nov 8 2018, 2:04 PM
In T208831#4731930, @Nikerabbit wrote:

Once this is deployed to production, the (Apertium) requests in https://grafana.wikimedia.org/dashboard/db/service-cxserver?orgId=1&from=now%2Fw&to=now should go down dramatically.

Deployment is scheduled tomorrow.

Stashbot subscribed.Nov 9 2018, 12:16 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-09T12:16:23Z] <kartik@deploy1001> Started deploy [cxserver/deploy@fc21164]: Update cxserver to 01686f6 (T208831)

Stashbot added a comment.Nov 9 2018, 12:17 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-09T12:17:32Z] <kartik@deploy1001> Finished deploy [cxserver/deploy@fc21164]: Update cxserver to 01686f6 (T208831) (duration: 01m 09s)

• Petar.petkovic closed this task as Resolved.Nov 15 2018, 12:16 PM
• Petar.petkovic moved this task from QA to Done on the Language-Team (Language-2018-October-December) board.
• Petar.petkovic removed subscribers: Stashbot, gerritbot.
Stashbot added a comment.Nov 16 2018, 11:08 AM

Mentioned in SAL (#wikimedia-operations) [2018-11-16T11:08:55Z] <kartik@deploy1001> Started deploy [cxserver/deploy@473b0de]: Update cxserver to b7cdb26 (T208831, T203077, T203160, T206777)

Stashbot mentioned this in T203077: Performance analysis for translate API.Nov 16 2018, 11:08 AM
Stashbot mentioned this in T203160: CX2: Highlight (and skip) references with a template that could not be adapted.
Stashbot mentioned this in T206777: Create Wikipedia Shan.
Stashbot added a comment.Nov 16 2018, 11:13 AM

Mentioned in SAL (#wikimedia-operations) [2018-11-16T11:13:21Z] <kartik@deploy1001> Finished deploy [cxserver/deploy@473b0de]: Update cxserver to b7cdb26 (T208831, T203077, T203160, T206777) (duration: 04m 26s)

Liuxinyu970226 unsubscribed.Nov 19 2018, 1:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL