(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T203077

Performance analysis for translate API
Closed, ResolvedPublic
Actions

Description

If the sections are large and has many links, templates, cxserver will take a good amount of time to finish the processing.
For example, big tables in en:List_of_English_football_champions, like one in section "Football League First Division (1892–1992)".

The request will timeout in that cases. In the case of the above table, I observed that the request did not finish in 2minutes and timed out.

This ticket is to analyse and detect bottlenecks if any in the processing that we can improve and reduce the time.

Details

SubjectRepoBranchLines +/-
Prevent duplicate adaptation of tags under textblockmediawiki/services/cxservermaster+8 -2
Prevent duplicate adaptation of tags under textblockmediawiki/services/cxservermaster+13 -5
Do not adapt the translation units under a transclusion contextmediawiki/services/cxservermaster+403 -7
Do not machine translate transclusion related elementsmediawiki/services/cxservermaster+51 -3
Do not pass blank textblocks to machine translation servicesmediawiki/services/cxservermaster+8 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• santhosh created this task.Aug 29 2018, 11:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2018, 11:23 AM
Pginer-WMF added a project: Language-2018-July-September.Aug 29 2018, 11:27 AM
• Petar.petkovic moved this task from Backlog to Performance on the CX-cxserver board.Aug 29 2018, 12:02 PM
Pginer-WMF triaged this task as Medium priority.Sep 3 2018, 11:35 AM
• santhosh added a comment.EditedSep 6 2018, 12:11 PM

I was not able to translate at all before https://gerrit.wikimedia.org/r/c/mediawiki/services/cxserver/+/458132 and https://gerrit.wikimedia.org/r/c/mediawiki/services/cxserver/+/458352

I did a timing analysis for the big table in en:List_of_English_football_champions, the one un section "Football League First Division (1892–1992)". Target language: es. MT: Apertium

I changed the TitleInfoRequest and TitlePairRequest to Get methods instead of Post:

image.png (414×1 px, 24 KB)

Once the cache for cxserver is ready, a re-attempt to translation, using "Reset translation" gives

image.png (414×1 px, 21 KB)

If I use the POST method in TitleInfoRequest and TitlePairRequest (no modification)

image.png (414×1 px, 23 KB)

Observations

  1. The table is now translatable
  2. Using get request has slight improvement in timing compared to POST. VE API Request cache uses get. We changed the cxserver implmentation to use POST, but I don't think that is relevant now, since we never send more than 50 titles in go.
Nikerabbit subscribed.Sep 6 2018, 3:08 PM
  1. Is the table translatable with cold caches? It doesn't really mean anything if it is translatable with warm caches, as users will see a failure (and probably won't retry)
  2. Surprising that there is a diff with GET/POST. Is this consistent pattern? I'm okay with switching to GET as long as we don't get silent (or non-silent) failures due to it. Though, it was not about number of titles, but maximum query length. 50*300 bytes is too much (namespace + 255 bytes).
• santhosh added a comment.Sep 7 2018, 4:12 AM

The first, and the last data in the above comment are immediately after cxserver start, means cache was empty. And it was translatable after the api cache fix patches. In master, the table is not translatable at all. I waited for 4 mins and then the request timed out.

gerritbot subscribed.Sep 28 2018, 11:26 AM

Change 463454 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Do not pass blank textblocks to machine translation services

https://gerrit.wikimedia.org/r/463454

gerritbot added a project: Patch-For-Review.Sep 28 2018, 11:26 AM
• santhosh added a comment.Sep 28 2018, 11:29 AM

While working on above patch, I found an opportunity for improvement. See the below section content

<section id="cxTargetSection12" data-mw-cx-source="undefined">
    <span about="#mwt51" data-mw="{&quot;parts&quot;:[{&quot;template&quot;:{&quot;target&quot;:{&quot;wt&quot;:&quot;cquote&quot;,&quot;href&quot;:&quot;./Template:Cquote&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;The Turkish influence still remained in speech and mentality. The language ... is full with Turkish words. Older Užičans are at home still very much like the Turks&quot;},&quot;2&quot;:{&quot;wt&quot;:&quot;24px&quot;},&quot;3&quot;:{&quot;wt&quot;:&quot;24px&quot;},&quot;4&quot;:{&quot;wt&quot;:&quot;[[Milutin Uskoković]]&quot;},&quot;5&quot;:{&quot;wt&quot;:&quot;''Došljaci'' (1919)&quot;}},&quot;i&quot;:0}}]}"
        id="mwZw" typeof="mw:Transclusion" data-ve-no-generated-contents="true">
    </span>
    <link about="#mwt51" href="./Category:Articles_with_attributed_pull_quotes" rel="mw:PageProp/Category"
        data-ve-ignore="true">
    <table about="#mwt51" class="cquote pullquote" id="173" role="presentation" style="margin:auto; border-collapse: collapse; border: none; background-color: transparent; width: auto; "
        data-ve-ignore="true">
        <tbody id="174">
            <tr id="175">
                <td id="176" style="width: 20px; vertical-align: top; border: none; color: #B2B7F2; font-size: 40px; font-family: 'Times New Roman', Times, serif; font-weight: bold; line-height: .6em; text-align: left; padding: 10px 10px;"><span
                        class="cx-segment" data-segmentid="177">“</span></td>
                <td id="178" style="vertical-align: top; border: none; padding: 4px 10px; "><span class="cx-segment"
                        data-segmentid="179">The Turkish influence still remained in speech and mentality. </span><span
                        class="cx-segment" data-segmentid="180">The language ... is full with Turkish words. </span><span
                        class="cx-segment" data-segmentid="181">Older Užičans are at home still very much like the
                        Turks</span></td>
                <td id="182" style="width: 20px; vertical-align: bottom; border: none; color: #B2B7F2; font-size: 40px; font-family: 'Times New Roman', Times, serif; font-weight: bold; line-height: .6em; text-align: right; padding: 10px 10px;"><span
                        class="cx-segment" data-segmentid="183">”</span></td>
            </tr>
            <tr id="184">

                <td class="cquotecite" colspan="3" id="185" style="border: none; padding-right: 4%; font-size: smaller; line-height:normal; text-align: right;"><cite><span
                            class="cx-segment" data-segmentid="186">—<span typeof="mw:Entity"> </span><a class="cx-link"
                                data-linkid="187" href="./Milutin_Uskoković" rel="mw:WikiLink" title="Milutin Uskoković">Milutin
                                Uskoković</a>, <i>Došljaci</i> (1919)</span></cite></td>
            </tr>
        </tbody>
    </table>

</section>

There is nothing to translate for an MT client in this. All elements are template and its fragements. Adaptation on data-mw definition will be happening anyway. It is a waste to translate the table content.

If we can figure out the above fact in MTClient class translateHtml method, we can save serveral MT service requests.

• Petar.petkovic moved this task from Backlog to In Review on the Language-2018-July-September board.Sep 28 2018, 12:06 PM
• Petar.petkovic assigned this task to • santhosh.Sep 28 2018, 12:40 PM
Pginer-WMF edited projects, added Language-2018-Oct-December; removed Language-2018-July-September.Oct 1 2018, 3:58 PM
Pginer-WMF moved this task from Backlog to In Review on the Language-2018-Oct-December board.
Krinkle awarded a token.Oct 2 2018, 5:44 AM
Krinkle added a project: Performance-Team (Radar).
gerritbot added a comment.Oct 3 2018, 11:29 AM

Change 463454 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Do not pass blank textblocks to machine translation services

https://gerrit.wikimedia.org/r/463454

• Petar.petkovic removed a project: Patch-For-Review.Oct 4 2018, 3:29 PM
• Petar.petkovic moved this task from In Review to Backlog on the Language-2018-Oct-December board.
Arrbee edited projects, added Language-Team (Language-2018-October-December); removed Language-2018-Oct-December.Oct 4 2018, 3:56 PM
gerritbot added a comment.Oct 5 2018, 10:11 AM

Change 464785 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Do not machine translate transclusion related elements

https://gerrit.wikimedia.org/r/464785

gerritbot added a project: Patch-For-Review.Oct 5 2018, 10:11 AM
gerritbot added a comment.Oct 5 2018, 11:03 AM

Change 464796 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Do not adapt the translation units under a transclusion context

https://gerrit.wikimedia.org/r/464796

• santhosh added a subtask: T199529: Do not try to adapt the transclusion fragements.Oct 5 2018, 11:08 AM
gerritbot added a comment.Oct 9 2018, 12:03 PM

Change 464785 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Do not machine translate transclusion related elements

https://gerrit.wikimedia.org/r/464785

• Petar.petkovic moved this task from Backlog to In Review on the Language-Team (Language-2018-October-December) board.Oct 11 2018, 9:16 AM
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Oct 14 2018, 9:36 PM
Stashbot mentioned this in T205420: CXServer fails with HTTP 500: "MT processing error: undefined".Oct 15 2018, 3:14 AM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-10-15T03:14:02Z] <kartik@deploy1001> Started deploy [cxserver/deploy@5a70ef1]: Update cxserver to 47a864b (T205420, T203077, T205700, T205616)

Stashbot mentioned this in T205700: Apertium fails to translate a quote template.Oct 15 2018, 3:14 AM
Stashbot mentioned this in T205616: CX2: Section alignment broken when translating "Fleming: The Man Who Would Be Bond" from Hebrew.
Stashbot added a comment.Oct 15 2018, 3:18 AM

Mentioned in SAL (#wikimedia-operations) [2018-10-15T03:18:46Z] <kartik@deploy1001> Finished deploy [cxserver/deploy@5a70ef1]: Update cxserver to 47a864b (T205420, T203077, T205700, T205616) (duration: 04m 44s)

Stashbot added a comment.Oct 15 2018, 5:16 AM

Mentioned in SAL (#wikimedia-operations) [2018-10-15T05:16:28Z] <kartik@deploy1001> Started deploy [cxserver/deploy@fd74c3b]: Update cxserver to b51f363 (T203077, T99934, T203550)

Stashbot mentioned this in T99934: CX2: ContentTranslation adapts some references only partially.Oct 15 2018, 5:16 AM
Stashbot mentioned this in T203550: CX2: Reference template adapted as empty despite templateData.
Stashbot added a comment.Oct 15 2018, 5:20 AM

Mentioned in SAL (#wikimedia-operations) [2018-10-15T05:20:53Z] <kartik@deploy1001> Finished deploy [cxserver/deploy@fd74c3b]: Update cxserver to b51f363 (T203077, T99934, T203550) (duration: 04m 25s)

Nikerabbit removed a project: Patch-For-Review.Oct 17 2018, 2:30 PM
Nikerabbit moved this task from In Review to QA on the Language-Team (Language-2018-October-December) board.
gerritbot added a comment.Oct 18 2018, 7:26 AM

Change 464796 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Do not adapt the translation units under a transclusion context

https://gerrit.wikimedia.org/r/464796

Stashbot mentioned this in T207070: Link elements with data-mw attributes are adapted as Links instead of templates.Oct 22 2018, 4:31 AM

Mentioned in SAL (#wikimedia-operations) [2018-10-22T04:31:52Z] <kartik@deploy1001> Started deploy [cxserver/deploy@904151f]: Update cxserver to eee8974 (T207070, T203077, T199529)

Stashbot mentioned this in T199529: Do not try to adapt the transclusion fragements.Oct 22 2018, 4:31 AM
Stashbot added a comment.Oct 22 2018, 4:37 AM

Mentioned in SAL (#wikimedia-operations) [2018-10-22T04:37:35Z] <kartik@deploy1001> Finished deploy [cxserver/deploy@904151f]: Update cxserver to eee8974 (T207070, T203077, T199529) (duration: 05m 42s)

Pginer-WMF closed subtask T199529: Do not try to adapt the transclusion fragements as Resolved.Oct 30 2018, 8:21 AM
Etonkovidova closed this task as Resolved.Nov 1 2018, 12:20 AM
Etonkovidova subscribed.

Checked in cx2 - the translating time looks decent for such big tables - in a range of 12-19 sec.

• Petar.petkovic moved this task from QA to Done on the Language-Team (Language-2018-October-December) board.Nov 5 2018, 9:56 PM
• Petar.petkovic removed subscribers: Stashbot, gerritbot.
gerritbot added a comment.Nov 8 2018, 12:11 PM

Change 472424 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Prevent duplicate adaptation of tags under textblock

https://gerrit.wikimedia.org/r/472424

gerritbot added a project: Patch-For-Review.Nov 8 2018, 12:11 PM
gerritbot added a comment.Nov 8 2018, 12:16 PM

Change 472424 abandoned by Santhosh:
Prevent duplicate adaptation of tags under textblock

https://gerrit.wikimedia.org/r/472424

gerritbot added a comment.Nov 8 2018, 12:18 PM

Change 472425 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Prevent duplicate adaptation of tags under textblock

https://gerrit.wikimedia.org/r/472425

• Petar.petkovic reopened this task as Open.Nov 9 2018, 1:41 PM
• Petar.petkovic moved this task from Done to In Review on the Language-Team (Language-2018-October-December) board.
gerritbot added a comment.Nov 13 2018, 7:19 AM

Change 472425 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Prevent duplicate adaptation of tags under textblock

https://gerrit.wikimedia.org/r/472425

• Petar.petkovic closed this task as Resolved.Nov 15 2018, 12:24 PM
• Petar.petkovic moved this task from In Review to Done on the Language-Team (Language-2018-October-December) board.
• Petar.petkovic removed a project: Patch-For-Review.
Stashbot mentioned this in T208831: Make Apertium tests independent of Labs service.Nov 16 2018, 11:08 AM

Mentioned in SAL (#wikimedia-operations) [2018-11-16T11:08:55Z] <kartik@deploy1001> Started deploy [cxserver/deploy@473b0de]: Update cxserver to b7cdb26 (T208831, T203077, T203160, T206777)

Stashbot mentioned this in T203160: CX2: Highlight (and skip) references with a template that could not be adapted.Nov 16 2018, 11:08 AM
Stashbot mentioned this in T206777: Create Wikipedia Shan.
Stashbot added a comment.Nov 16 2018, 11:13 AM

Mentioned in SAL (#wikimedia-operations) [2018-11-16T11:13:21Z] <kartik@deploy1001> Finished deploy [cxserver/deploy@473b0de]: Update cxserver to b7cdb26 (T208831, T203077, T203160, T206777) (duration: 04m 26s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL