(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T364435

Drop gu_salt from globaluser
Open, In Progress, Needs TriagePublic
Actions

Description

All values which are stored in gu_salt can be stored as ':B:' . $this->mSalt . ':' . $this->mPassword in the gu_password column.

Details

SubjectRepoBranchLines +/-
filtered_tables: Remove gu_saltoperations/puppetproduction+0 -1
Add sql files for dropping gu_salt from globalusermediawiki/extensions/CentralAuthmaster+308 -10
Drop gu_salt from globaluser table on Third-party wikismediawiki/extensions/CentralAuthmaster+9 -0
Run migrateGuSalt.php on Third-party wikismediawiki/extensions/CentralAuthmaster+39 -11
Stop using gu_saltmediawiki/extensions/CentralAuthmaster+8 -33
wikireplicas: Drop gu_salt from maintain-viewsoperations/puppetproduction+1 -1
Add migrateGuSalt.php scriptmediawiki/extensions/CentralAuthmaster+105 -0
migrateGuSalt: Use transactionmediawiki/extensions/CentralAuthmaster+3 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Zabe created this task.May 7 2024, 10:23 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptMay 7 2024, 10:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Zabe added a parent task: Restricted Task.May 7 2024, 10:23 PM
gerritbot added a comment.May 7 2024, 10:50 PM

Change #1028906 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Add migrateGuSalt.php script

https://gerrit.wikimedia.org/r/1028906

gerritbot added a project: Patch-For-Review.May 7 2024, 10:51 PM
gerritbot added a comment.May 9 2024, 8:24 PM

Change #1029709 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/puppet@production] wikireplicas: Drop gu_salt from maintain-views

https://gerrit.wikimedia.org/r/1029709

fnegri subscribed.May 10 2024, 1:40 PM
fnegri claimed this task.May 10 2024, 1:44 PM
fnegri added a project: cloud-services-team (FY2023/2024-Q3-Q4).

Claiming this task temporarily: I will deploy the wikireplicas change on Monday, then I will unassign myself.

fnegri changed the task status from Open to In Progress.May 10 2024, 1:45 PM
fnegri moved this task from Backlog to In progress on the cloud-services-team (FY2023/2024-Q3-Q4) board.
gerritbot added a comment.May 10 2024, 11:18 PM

Change #1028906 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Add migrateGuSalt.php script

https://gerrit.wikimedia.org/r/1028906

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).May 11 2024, 12:01 AM
gerritbot added a comment.May 11 2024, 7:57 AM

Change #1030526 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/CentralAuth@master] migrateGuSalt: Use transaction

https://gerrit.wikimedia.org/r/1030526

gerritbot added a comment.May 11 2024, 9:01 AM

Change #1030526 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] migrateGuSalt: Use transaction

https://gerrit.wikimedia.org/r/1030526

larissagaulia moved this task from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.May 13 2024, 11:16 AM
larissagaulia edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team.
Stashbot added a comment.Tue, May 14, 10:48 PM

Mentioned in SAL (#wikimedia-operations) [2024-05-14T22:48:31Z] <zabe> start running migrateGuSalt.php in screen session # T364435

gerritbot added a comment.Tue, May 14, 11:12 PM

Change #1031606 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Stop using gu_salt

https://gerrit.wikimedia.org/r/1031606

gerritbot added a comment.Tue, May 14, 11:37 PM

Change #1031608 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/puppet@production] filtered_tables: Remove gu_salt

https://gerrit.wikimedia.org/r/1031608

gerritbot added a comment.Thu, May 16, 10:30 AM

Change #1029709 merged by FNegri:

[operations/puppet@production] wikireplicas: Drop gu_salt from maintain-views

https://gerrit.wikimedia.org/r/1029709

ops-monitoring-bot added a comment.Thu, May 16, 10:37 AM

Cookbook cookbooks.sre.wikireplicas.update-views run by fnegri: Started updating wiki replica views

ops-monitoring-bot added a comment.Thu, May 16, 10:48 AM

Cookbook cookbooks.sre.wikireplicas.update-views started by fnegri completed:

  • clouddb1021.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --all-databases --replace-all --auto-depool --table globaluser'
  • clouddb1017.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --all-databases --replace-all --auto-depool --table globaluser'
  • clouddb1018.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --all-databases --replace-all --auto-depool --table globaluser'
  • clouddb1019.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --all-databases --replace-all --auto-depool --table globaluser'
  • clouddb1020.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --all-databases --replace-all --auto-depool --table globaluser'
  • clouddb1013.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --all-databases --replace-all --auto-depool --table globaluser'
  • clouddb1014.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --all-databases --replace-all --auto-depool --table globaluser'
  • clouddb1015.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --all-databases --replace-all --auto-depool --table globaluser'
  • clouddb1016.eqiad.wmnet (PASS)
    • Ran Puppet agent
    • Ran 'maintain-views --all-databases --replace-all --auto-depool --table globaluser'
fnegri removed fnegri as the assignee of this task.Thu, May 16, 10:50 AM

Claiming this task temporarily: I will deploy the wikireplicas change on Monday, then I will unassign myself.

Apologies, I did this a few days later. The wikireplicas patch is now merged and applied.

fnegri removed a project: cloud-services-team (FY2023/2024-Q3-Q4).Thu, May 16, 1:02 PM
Tgr subscribed.Thu, May 16, 8:03 PM

Do we need to do something to support third-party users (although officially, third-party use of CentralAuth is not supported)? I guess once T348486: Migrate CentralAuth to use a virtual database domain lands, CA can have update scripts and we can just automatically run the migration?

gerritbot added a comment.Thu, May 16, 8:10 PM

Change #1031606 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Stop using gu_salt

https://gerrit.wikimedia.org/r/1031606

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.6; 2024-05-21); removed MW-1.43-notes (1.43.0-wmf.5; 2024-05-14).Thu, May 16, 9:00 PM
gerritbot added a comment.Thu, May 16, 10:47 PM

Change #1032596 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Run migrateGuSalt.php on Third-party wikis

https://gerrit.wikimedia.org/r/1032596

gerritbot added a comment.Thu, May 23, 5:46 PM

Change #1032596 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Run migrateGuSalt.php on Third-party wikis

https://gerrit.wikimedia.org/r/1032596

gerritbot added a comment.Thu, May 23, 5:54 PM

Change #1035532 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Drop gu_salt from globaluser table

https://gerrit.wikimedia.org/r/1035532

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.7; 2024-05-28); removed MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).Thu, May 23, 6:00 PM
gerritbot added a comment.Sun, May 26, 5:37 PM

Change #1035897 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] Add sql files for dropping gu_salt from globaluser

https://gerrit.wikimedia.org/r/1035897

gerritbot added a comment.Tue, May 28, 3:56 PM

Change #1035897 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Add sql files for dropping gu_salt from globaluser

https://gerrit.wikimedia.org/r/1035897

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.8; 2024-06-04); removed MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).Tue, May 28, 4:00 PM
Zabe added a subtask: T366123: Drop gu_salt from globaluser in WMF prod.Tue, May 28, 9:35 PM
gerritbot added a comment.Wed, May 29, 11:38 AM

Change #1031608 abandoned by Zabe:

[operations/puppet@production] filtered_tables: Remove gu_salt

Reason:

Done in https://gerrit.wikimedia.org/r/c/operations/puppet/+/1037046

https://gerrit.wikimedia.org/r/1031608

Marostegui closed subtask T366123: Drop gu_salt from globaluser in WMF prod as Resolved.Fri, May 31, 6:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL