(Go: >> BACK << -|- >> HOME <<)

Page MenuHomePhabricator

Provide nodejs20 base images for production
Closed, ResolvedPublic

Description

Per upstream's release chart, NodeJS 18 is now in maintenance mode; NodeJS 20 is LTS until October, and NodeJS 22 comes out next week (2024-04-23).

Would it be possible to provide nodejs20-slim and nodejs20-devel production base images?

Event Timeline

nodejs20 isn't even on trixie/sid right now https://packages.debian.org/trixie/nodejs, https://packages.debian.org/sid/nodejs but only in experimental.

I am adding @MoritzMuehlenhoff to advise. Since we bring in nodejs via https://deb.nodesource.com/ in some cases in our repos, it might be doable.

That's not problem. We should just use the nodesource packages for this, we've been doing the same for "intermediate LTSes" before (e.g. node 16 or node 14) not covered by an intree Debian nodejs version. I'll work on this next week.

That's not problem. We should just use the nodesource packages for this, we've been doing the same for "intermediate LTSes" before (e.g. node 16 or node 14) not covered by an intree Debian nodejs version. I'll work on this next week.

Perfect, thanks for this!

Change #1024663 had a related patch set uploaded (by Muehlenhoff; author: Muehlenhoff):

[operations/puppet@production] aptrepo: Add new repository component and repo sync config for Node 20

https://gerrit.wikimedia.org/r/1024663

Change #1024663 merged by Muehlenhoff:

[operations/puppet@production] aptrepo: Add new repository component and repo sync config for Node 20

https://gerrit.wikimedia.org/r/1024663

Change #1026873 had a related patch set uploaded (by Muehlenhoff; author: Muehlenhoff):

[operations/docker-images/production-images@master] Add node20 production image

https://gerrit.wikimedia.org/r/1026873

Mentioned in SAL (#wikimedia-operations) [2024-05-07T15:19:38Z] <moritzm> imported nodejs 20.5.1-deb-1nodesource1 to thirdparty/node20 T362681

Change #1026873 merged by Muehlenhoff:

[operations/docker-images/production-images@master] Add node20 production image

https://gerrit.wikimedia.org/r/1026873

I kicked off a build of the node20 image, it should hopefully appear in the registry soon.

I kicked off a build of the node20 image, it should hopefully appear in the registry soon.

Not there yet; did the build get stuck/break?

I kicked off a build of the node20 image, it should hopefully appear in the registry soon.

Not there yet; did the build get stuck/break?

OK, after the weekend it's now shown up, and works great. Thank you!

I kicked off a build of the node20 image, it should hopefully appear in the registry soon.

Not there yet; did the build get stuck/break?

OK, after the weekend it's now shown up, and works great. Thank you!

Great :-)

It seems the image has some issues with dependencies. See: https://integration.wikimedia.org/ci/job/cxserver-pipeline-test/582/console cc @MoritzMuehlenhoff

Despite being named -slim it includes npm; don't try to re-install it, and it works fine.

It seems the image has some issues with dependencies. See: https://integration.wikimedia.org/ci/job/cxserver-pipeline-test/582/console cc @MoritzMuehlenhoff

Despite being named -slim it includes npm; don't try to re-install it, and it works fine.

Thanks! Removing 'npm' works!