(Go: >> BACK << -|- >> HOME <<)

Page MenuHomePhabricator

Wikistory: unparsed and broken HTML code
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
GMikesell-WMF
Nov 28 2023, 8:12 PM
Referenced Files
F41613872: 2023-12-19_16-04-30.png
Dec 20 2023, 12:13 AM
F41613870: 2023-12-14_08-08-01.png
Dec 20 2023, 12:13 AM
F41553452: 2023-12-01_15-10-38.png
Dec 1 2023, 11:12 PM
F41553430: 2023-12-01_14-32-00.png
Dec 1 2023, 10:56 PM
F41553428: 2023-12-01_14-33-39.png
Dec 1 2023, 10:56 PM
F41549746: 2023-11-30_14-31-57.mp4.gif
Nov 30 2023, 10:41 PM
F41549742: 2023-11-30_14-32-38.png
Nov 30 2023, 10:41 PM
F41549740: 2023-11-30_14-33-18.png
Nov 30 2023, 10:41 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:
You'll see unparsed and broken HTML code as seen below and from beginning to end in the gif below

Homi Jehangir Bhabha ( /<span style="border-bottom:1px dotted"><span>ˈ</span><span>b</span><span>ɑː</span><span>b</span> <span>ɑː</span></span>/ ;) (30 October 1909 – 24 January 1966) was an Indian nuclear physicist, founding director , and professor of physics at the Tata Institute of Fundamental Research

What should have happened instead?:
No HTML code

Software version (skip for WMF-hosted wikis like Wikipedia):
os: macOS 14.1.1
Browser: Chrome Version 119.0.6045.159
Test link: https://id.m.wikipedia.org/wiki/Homi_J._Bhabha

Other information (browser name/version, screenshots, etc.):

2023-11-28_12-00-21.mp4.gif (1×3 px, 2 MB)

QA Results - ID Prod

Event Timeline

Change 978693 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Properly unwrap links

https://gerrit.wikimedia.org/r/978693

Change 978693 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Properly unwrap links

https://gerrit.wikimedia.org/r/978693

@SBisson HTML code is now not showing as seen in the screenshots and gif below. I will move this to Design Sign-off. Thanks for all your work!

Status: ✅PASS
Environment:ID Prod
OS: macOS Sonoma 14.1
Browser: Chrome 119
Skins. Minerva
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://id.m.wikipedia.org/wiki/Homi_J._Bhabha

✅AC1: https://phabricator.wikimedia.org/T352216

Previous PatchLatest Patch
2023-11-30_14-33-18.png (1×2 px, 919 KB)
2023-11-30_14-32-38.png (445×2 px, 99 KB)

Gif

2023-11-30_14-31-57.mp4.gif (1×2 px, 2 MB)

@SBisson a new update that I just noticed with the audio button as seen below.

Status: ❌ FAIL
Environment:ID Prod
OS: macOS Sonoma 14.1
Browser: Chrome 119
Skins. Minerva
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://id.m.wikipedia.org/wiki/Carlos_Sainz_Jr.
https://id.m.wikipedia.org/wiki/Istimewa:Pembuat_Story/Donald_Trump#article

This one is fixed as seen below

Previous PatchLatest Patch
2023-11-30_14-33-18.png (1×2 px, 919 KB)
2023-11-30_14-32-38.png (445×2 px, 99 KB)

but

It looks like the audio version as seen in https://id.m.wikipedia.org/wiki/Carlos_Sainz_Jr. still has broken html

2023-12-01_14-33-39.png (1×2 px, 428 KB)
2023-12-01_14-32-00.png (1×2 px, 1 MB)

Another one
https://id.m.wikipedia.org/wiki/Istimewa:Pembuat_Story/Donald_Trump#article

2023-12-01_15-10-38.png (491×2 px, 117 KB)

@GMikesell-WMF note that this patch will be released to production next week, reaching idwiki on Dec 14. Please test again at that time.

@SBisson Issue is now fixed in Prod as seen from the screenshots below. I will move this to design sign-off. Thanks for all your work!

Status: ✅PASS
Environment: Prod- id.m.wikipedia
OS: macOS Sonoma 14.2.1
Browser: Chrome 120, Firefox 120, Safari 17.2, Edge 120
Skins. Minerva
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://id.m.wikipedia.org/wiki/Istimewa:Pembuat_Story/Donald_Trump#article

✅AC1: https://phabricator.wikimedia.org/T352216

Before PatchAfter Patch
2023-12-14_08-08-01.png (298×847 px, 49 KB)
2023-12-19_16-04-30.png (1×2 px, 388 KB)