I can sign up, but I can’t sign in…
Arguably, sign in would likely be more useful for people browsing gerrit on smaller screen devices (I've wanted to +2 some commits without going on my computer)...
Reedy | |
Aug 24 2023, 8:02 AM |
Restricted File | |
Jun 1 2024, 9:18 AM |
F54829663: IMG_5451.png | |
Jun 1 2024, 9:17 AM |
F54829664: IMG_5452.png | |
Jun 1 2024, 9:17 AM |
F54829665: IMG_5450.png | |
Jun 1 2024, 9:17 AM |
F54827910: Screenshot_20240601-101123.png | |
Jun 1 2024, 8:12 AM |
F54827891: Screenshot_20240601-100958.png | |
Jun 1 2024, 8:12 AM |
F37625488: IMG_2604.png | |
Aug 24 2023, 8:02 AM |
I can sign up, but I can’t sign in…
Arguably, sign in would likely be more useful for people browsing gerrit on smaller screen devices (I've wanted to +2 some commits without going on my computer)...
The link is further to the right and ends up hidden. Maybe we can remove the Wikimedia Code Review text though I have no idea how to do that in CSS.
The content comes from operations/puppet:
<a href="/r/"><h1 class="wm-gerrit-heading"> Wikimedia Code Review </h1></a>
And the style is:
... /** * The logo uses position absolute because the HTML generated by Gerrit * creates the header as a sibling *after* the menu instead of before it. * As such, the only reliable way to render to the left of it, is either * with fragile negative offsets, or by using absolute position. * * The logo is taller than gerrit_topmenu. As such, a later CSS rule * ensures gerrit_topmenu has a minimum height that accomodates the * logo as well, to avoid page content from overlapping the logo. */ #gerrit_header { display: block !important; } .wm-gerrit-heading { position: absolute; top: 0; left: 0; margin: 7px 13px; padding: 0; /* This font and color aren't used since there is an image there, * but is kept for consistency when used for display of alt-text */ font-weight: normal; letter-spacing: -1px; color: #990000; min-height: 60px; min-width: 60px; background: transparent no-repeat 0 0; background-image: url(/r/static/wikimedia-codereview-logo.cache.png); background-image: linear-gradient(transparent,transparent), url(/r/static/wikimedia-codereview-logo.cache.svg); text-indent: -9999px; overflow: hidden; }
I think we can do it in JS (I dunno if we can do it in pure CSS...?), if it's a small viewport, or mobile or something, either hide the text, or change it etc
This appears to be because items are being pushed out of screen. I did a hack https://gerrit-review.googlesource.com/c/gerrit/+/420278. It's an ugly hack but it does the job. The better fix and something I'm pushing and looking at is to create a mobile optimised header that pushes these drop downs to a side bar (or aka hamburger).
When you click the "Sign Up" and on that next screen scroll down a bit, there is a:
Already have an account? Go to Log In link.
That can be used as an alternative.
This will be fixed with T365328.
Although the better and correct fix is: https://gerrit-review.googlesource.com/c/gerrit/+/425857 (Making the navbar responsive)
On some cheap Android phone it initially looks like this:
It was not super obvious that I have to drag the viewport sideways to get this:
Yeh, it’s a hack. I’ve fixed it on the master branch of Gerrit by creating a mobile view. Please visit https://gerrit-review.googlesource.com/q/status:open+-is:wip to see what it’s like and do give feedback!
{F54829712}