(Go: >> BACK << -|- >> HOME <<)

Page MenuHomePhabricator

Missing sign in links on mobile
Open, LowPublic

Assigned To
None
Authored By
Reedy
Aug 24 2023, 8:02 AM
Referenced Files
Restricted File
Jun 1 2024, 9:18 AM
F54829663: IMG_5451.png
Jun 1 2024, 9:17 AM
F54829664: IMG_5452.png
Jun 1 2024, 9:17 AM
F54829665: IMG_5450.png
Jun 1 2024, 9:17 AM
F54827910: Screenshot_20240601-101123.png
Jun 1 2024, 8:12 AM
F54827891: Screenshot_20240601-100958.png
Jun 1 2024, 8:12 AM
F37625488: IMG_2604.png
Aug 24 2023, 8:02 AM

Description

IMG_2604.png (1×750 px, 324 KB)

I can sign up, but I can’t sign in…

Arguably, sign in would likely be more useful for people browsing gerrit on smaller screen devices (I've wanted to +2 some commits without going on my computer)...

Event Timeline

Reedy renamed this task from Missing sign in links on mobile to Missing sign in links on mobile.Aug 24 2023, 8:11 AM
Reedy updated the task description. (Show Details)

The link is further to the right and ends up hidden. Maybe we can remove the Wikimedia Code Review text though I have no idea how to do that in CSS.

The content comes from operations/puppet:

modules/gerrit/files/site/etc/GerritSiteHeader.html
<a href="/r/"><h1 class="wm-gerrit-heading">
    Wikimedia Code Review
</h1></a>

And the style is:

modules/gerrit/files/site/etc/GerritSite.css
...
/**
 * The logo uses position absolute because the HTML generated by Gerrit
 * creates the header as a sibling *after* the menu instead of before it.
 * As such, the only reliable way to render to the left of it, is either
 * with fragile negative offsets, or by using absolute position.
 *
 * The logo is taller than gerrit_topmenu. As such, a later CSS rule
 * ensures gerrit_topmenu has a minimum height that accomodates the
 * logo as well, to avoid page content from overlapping the logo.
 */
#gerrit_header {
    display: block !important;
}

.wm-gerrit-heading {
    position: absolute;
    top: 0;
    left: 0;
    margin: 7px 13px;
    padding: 0;
    /* This font and color aren't used since there is an image there,
     * but is kept for consistency when used for display of alt-text
     */
    font-weight: normal;
    letter-spacing: -1px;
    color: #990000;
    min-height: 60px;
    min-width: 60px;
    background: transparent no-repeat 0 0;
    background-image: url(/r/static/wikimedia-codereview-logo.cache.png);
    background-image: linear-gradient(transparent,transparent), url(/r/static/wikimedia-codereview-logo.cache.svg);
    text-indent: -9999px;
    overflow: hidden;
}

The link is further to the right and ends up hidden. Maybe we can remove the Wikimedia Code Review text though I have no idea how to do that in CSS.

I think we can do it in JS (I dunno if we can do it in pure CSS...?), if it's a small viewport, or mobile or something, either hide the text, or change it etc

This appears to be because items are being pushed out of screen. I did a hack https://gerrit-review.googlesource.com/c/gerrit/+/420278. It's an ugly hack but it does the job. The better fix and something I'm pushing and looking at is to create a mobile optimised header that pushes these drop downs to a side bar (or aka hamburger).

When you click the "Sign Up" and on that next screen scroll down a bit, there is a:

Already have an account? Go to Log In link.

That can be used as an alternative.

This will be fixed with T365328.

Although the better and correct fix is: https://gerrit-review.googlesource.com/c/gerrit/+/425857 (Making the navbar responsive)

This will be fixed with T365328.

On some cheap Android phone it initially looks like this:

Screenshot_20240601-100958.png (1×720 px, 206 KB)

It was not super obvious that I have to drag the viewport sideways to get this:

Screenshot_20240601-101123.png (1×720 px, 143 KB)

This will be fixed with T365328.

On some cheap Android phone it initially looks like this:

Screenshot_20240601-100958.png (1×720 px, 206 KB)

It was not super obvious that I have to drag the viewport sideways to get this:

Screenshot_20240601-101123.png (1×720 px, 143 KB)

Yeh, it’s a hack. I’ve fixed it on the master branch of Gerrit by creating a mobile view. Please visit https://gerrit-review.googlesource.com/q/status:open+-is:wip to see what it’s like and do give feedback!

IMG_5450.png (2×1 px, 738 KB)

IMG_5452.png (2×1 px, 748 KB)

IMG_5451.png (2×1 px, 457 KB)

{F54829712}

Back to using Gerrit in order to close the Gerrit (Gerrit 3.8) milestone.