Page subscription button gets an event listener every time you preview, sends duplicate requests
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Nardog
	Jun 25 2023, 8:02 PM

Description

Steps to replicate the issue (include links if applicable):

Enable "Show preview without reloading the page" in Preferences
Open e.g. https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&action=edit&section=0
Click "Show preview"
Click "Subscribe" or "Unsubscribe" on the page toolbar (#p-cactions)

What happens?:
The notification "You have (un)subscribed" appears twice. The number of duplicate notifs increases as you repeat steps 3–4.

What should have happened instead?:
The notification appears once per (un)subscribing.

Other information (browser name/version, screenshots, etc.):

	Subject	Repo	Branch	Lines +/-
	Unregister existing topic subscription handlers on init	mediawiki/extensions/DiscussionTools	master	+6 -1

Further reproduction note: only applies in WikiEditor, because the preview mechanism is completely different in NWE.

Change 933135 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Unregister existing topic subscription handlers on init

Change 933135 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Unregister existing topic subscription handlers on init

DLynch added a project: Editing QA.

Notifications appear once per action triggered

ppelberg closed this task as Resolved.Jul 7 2023, 11:36 PM

	F37127402: Screenshot 2023-07-03 at 23.59.32.png
	Jul 3 2023, 11:00 PM