Maniphest T330033

WikiLambda PHP: Consider using injected services in API classes
Open, LowPublic
Actions

Assigned To

None

Authored By

	DMartin-WMF
	Feb 19 2023, 8:33 PM

Tags

Referenced Files

None

Subscribers

Description

Consider using injected services in API classes, as suggested in a review of this patch.

The suggestion refers to this code segment:

$services = MediaWikiServices::getInstance();
$jobQueueGroup = $services->getJobQueueGroup();

See also: Make ZObjectFactory an injectable service
Make ZObjectStore an injectable service
WikiLambda PHP: Consider using an injected service for wfMessage

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist

Details

	Subject	Repo	Branch	Lines +/-
	ApiPerformTest: Re-use JobQueueGroup from Services where we can	mediawiki/extensions/WikiLambda	master	+13 -7

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T362246 Use dependency injection across WikiLambda wherever possible
		Open		None	T330033 WikiLambda PHP: Consider using injected services in API classes

Event Timeline

DMartin-WMF created this task.Feb 19 2023, 8:33 PM

DMartin-WMF updated the task description. (Show Details)Feb 19 2023, 8:36 PM

DVrandecic moved this task from To triage to To triage: Nice-to-haves on the Abstract Wikipedia team board.Feb 21 2023, 7:35 PM

Change 893524 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ApiPerformTest: Re-use JobQueueGroup from Services where we can

https://gerrit.wikimedia.org/r/893524

gerritbot added a project: Patch-For-Review.Mar 1 2023, 6:12 PM

Change 893524 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ApiPerformTest: Re-use JobQueueGroup from Services where we can

https://gerrit.wikimedia.org/r/893524

Maintenance_bot removed a project: Patch-For-Review.Mar 7 2023, 10:10 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 9 2023, 6:01 PM

Jdforrester-WMF added a parent task: T362246: Use dependency injection across WikiLambda wherever possible.Apr 10 2024, 3:17 PM

Jdforrester-WMF triaged this task as Low priority.Wed, May 15, 4:44 PM

Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.

Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.