(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T328956

TypeError: Cannot read properties of undefined (reading 'getBoundingClientRect')
Closed, ResolvedPublic4 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error
normalized_message
TypeError: Cannot read properties of undefined (reading 'getBoundingClientRect')
at isLanguageFullyVisible  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.uls.i18n%2Clanguagenames%2Cmediawiki%2Cmessages%7Cjquery.i18n%2Culs%7Cjquery.uls.grid&skin=vector-2022&version=1irt0:70:498
at LanguageCategoryDisplay.highlightLanguageOption  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.uls.i18n%2Clanguagenames%2Cmediawiki%2Cmessages%7Cjquery.i18n%2Culs%7Cjquery.uls.grid&skin=vector-2022&version=1irt0:72:1
at LanguageCategoryDisplay.navigateUp  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.uls.i18n%2Clanguagenames%2Cmediawiki%2Cmessages%7Cjquery.i18n%2Culs%7Cjquery.uls.grid&skin=vector-2022&version=1irt0:71:699
at LanguageFilter.keypress  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.uls.i18n%2Clanguagenames%2Cmediawiki%2Cmessages%7Cjquery.i18n%2Culs%7Cjquery.uls.grid&skin=vector-2022&version=1irt0:81:393
at HTMLInputElement.dispatch  https://en.wikipedia.org/w/load.php?lang=en&modules=jquery%2Cvue&skin=vector-2022&version=1vlka:70:260
at elemData.handle  https://en.wikipedia.org/w/load.php?lang=en&modules=jquery%2Cvue&skin=vector-2022&version=1vlka:66:877
exception.trace





Impact



295 errors in last 7 days



Notes



Seems to occur on keypress

Potential upstream issue in jquery.uls.lcd.js
Details
SubjectRepoBranchLines +/-
Update jquery.uls from upstreammediawiki/extensions/UniversalLanguageSelectormaster+19 -23
Update jquery.uls from upstreammediawiki/extensions/UniversalLanguageSelectormaster+4 -0
Update jquery.uls from upstreammediawiki/extensions/UniversalLanguageSelectormaster+4 -0
Customize query in gerrit
Related Objects
Search...
Event Timeline
Jdlrobson created this task.Feb 6 2023, 8:01 PM
Restricted Application added a subscriber: Aklapper.  ·  View Herald TranscriptFeb 6 2023, 8:01 PM
Jdlrobson updated the task description. (Show Details)Feb 6 2023, 8:02 PM
Umherirrender added a project: JavaScript.Feb 6 2023, 9:26 PM
Nikerabbit added a subscriber: abi_.Feb 7 2023, 6:26 AM
Nikerabbit triaged this task as High priority.Feb 7 2023, 12:18 PM
Nikerabbit added projects: Language-Team (Language-2023-January-March), Unplanned-Sprint-Work.
Nikerabbit subscribed.
Caused by T187964: Enable up/down keys for navigating the ULS menu.
Nikerabbit added a parent task: T187964: Enable up/down keys for navigating the ULS menu.Feb 7 2023, 12:19 PM
Nikerabbit moved this task from Backlog to Code failures on the UniversalLanguageSelector board.
Nikerabbit moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2023-January-March) board.
• thcipriani moved this task from Untriaged to Feb 2023 on the Wikimedia-production-error board.Feb 9 2023, 4:45 PM
abi_ claimed this task.Feb 15 2023, 8:12 PM
abi_ moved this task from Priority: Localization infrastructure to In Review on the Language-Team (Language-2023-January-March) board.
I'm able to reproduce this with the following steps:



    

  1. Go to https://en.wikipedia.org/wiki/2022%E2%80%9323_Pro_A_season?useskin=vector-2022
    2. 

  2. Open the language selector and filter the languages so that there is only one language remaining
    3. 

  3. Press the up arrow
    4. 




Submitted: https://github.com/wikimedia/jquery.uls/pull/445/files to fix this.
gerritbot added a comment.Feb 16 2023, 4:43 PM
Change 889516 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):



[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls from upstream



https://gerrit.wikimedia.org/r/889516
gerritbot added a project: Patch-For-Review.Feb 16 2023, 4:43 PM
gerritbot added a comment.Feb 16 2023, 5:04 PM
Change 889516 merged by jenkins-bot:



[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls from upstream



https://gerrit.wikimedia.org/r/889516
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 16 2023, 6:00 PM
abi_ closed this task as Resolved.Feb 20 2023, 3:53 AM
abi_ moved this task from In Review to Done on the Language-Team (Language-2023-January-March) board.
The fix has been deployed and tested on translatewiki.net
Nikerabbit removed a project: Patch-For-Review.Feb 20 2023, 9:09 AM
Jdlrobson reopened this task as Open.Mar 10 2023, 1:01 AM
This error is still occuring in Wikimedia production at a rate of 192 errors in the last 7 days.
abi_ added a comment.Mar 13 2023, 10:13 AM


In T328956#8682017, @Jdlrobson wrote:


This error is still occuring in Wikimedia production at a rate of 192 errors in the last 7 days.





Thanks. I noticed some occurrences that were due to my changes to ULS when an empty state is added to ULS in order to provide entry points to create articles. I've submitted https://github.com/wikimedia/jquery.uls/pull/449 to fix this.



I also see other occurrences of this error but doesn't appear to be related to ULS. See Logstash link.
abi_ moved this task from Done to In Review on the Language-Team (Language-2023-January-March) board.Mar 13 2023, 10:13 AM
gerritbot added a comment.Mar 13 2023, 1:54 PM
Change 896401 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):



[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls library



https://gerrit.wikimedia.org/r/896401
gerritbot added a project: Patch-For-Review.Mar 13 2023, 1:54 PM
gerritbot added a comment.Mar 13 2023, 2:41 PM
Change 896401 merged by jenkins-bot:



[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls from upstream



https://gerrit.wikimedia.org/r/896401
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.27; 2023-03-13); removed MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Mar 13 2023, 3:01 PM
Nikerabbit removed a project: Patch-For-Review.Mar 13 2023, 3:13 PM
Nikerabbit moved this task from In Review to Check after deployment on the Language-Team (Language-2023-January-March) board.
abi_ lowered the priority of this task from High to Medium.Mar 27 2023, 10:20 AM
abi_ moved this task from Check after deployment to Priority: Localization infrastructure on the Language-Team (Language-2023-January-March) board.
I now see 19 occurrences of this error in the last 10 days. Will continue investigation at a lower priority.
Pginer-WMF edited projects, added Language-Team (Language-2023-April-June); removed Language-Team (Language-2023-January-March).Mar 31 2023, 1:26 PM
Pginer-WMF moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2023-April-June) board.
Nikerabbit lowered the priority of this task from Medium to Lowest.Apr 4 2023, 12:05 PM
Nikerabbit set the point value for this task to 4.Apr 4 2023, 12:18 PM
abi_ moved this task from Priority: Localization infrastructure to In Review on the Language-Team (Language-2023-April-June) board.Apr 13 2023, 12:31 PM
abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2023-April-June) board.Apr 24 2023, 4:44 AM
I've added some error logging in the jquery.uls library: https://github.com/wikimedia/jquery.uls/pull/453



Hopefully, this should help find the error.
Jdlrobson closed this task as Resolved.May 9 2023, 5:57 PM
I'm not seeing any errors on the latest deploy branch. Thanks for working on this!

https://logstash.wikimedia.org/goto/3dcd48891a7a606eaa9d1841f3d7a20e
Nikerabbit reopened this task as Open.May 9 2023, 9:07 PM
Hasn't gone through sprint process yet.
abi_ added a comment.EditedMay 16 2023, 12:11 PM
I'm seeing instances of the following error a few times weekly:



Error: Could not identify selected item with index: 9; Total items in ULS: 3



Link to Logstash



This might be caused due to lag in responding to user input. I'm planning to add some auto-correcting code to jquery.uls and improve logging.



Edit: Submitted: https://github.com/wikimedia/jquery.uls/pull/457
gerritbot added a comment.May 29 2023, 8:35 AM
Change 924048 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):



[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls from upstream



https://gerrit.wikimedia.org/r/924048
gerritbot added a project: Patch-For-Review.May 29 2023, 8:35 AM
gerritbot added a comment.May 29 2023, 9:02 AM
Change 924048 merged by jenkins-bot:



[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.uls from upstream



https://gerrit.wikimedia.org/r/924048
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.11; 2023-05-30).May 29 2023, 10:00 AM
abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2023-April-June) board.Jun 5 2023, 12:47 PM
I'm not seeing any more occurrences of this issue in the past 5 days. I'll check this for a couple of day and then resolve it.
abi_ closed this task as Resolved.Jun 7 2023, 6:53 AM
No occurrences of this error since 31st of May. Marking this as resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL