(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T315432

Consolidate all in-Vue API calls into our mixins/api.js file
Closed, ResolvedPublic
Actions

Description

We have a 'mixins/api.js' file destined to centralize all front-end API calls but many of them are distributed around vuex store actions.

We should move all of these into this file.

This will be helpful when we want to integrate other functionalities related to API calls and unified handling of returns (like, for example, show error toast messages)

Details

SubjectRepoBranchLines +/-
Centralize API calls in api.js mixin and fix error handlingmediawiki/extensions/WikiLambdawmf/1.42.0-wmf.25+251 -179
Centralize API calls in api.js mixin and fix error handlingmediawiki/extensions/WikiLambdamaster+251 -179
move all API calls in a single mixins/api.js filemediawiki/extensions/WikiLambdamaster+145 -72
Customize query in gerrit

Related Objects

Event Timeline

gengh created this task.Aug 17 2022, 11:48 AM
Jdforrester-WMF renamed this task from Take all front-end API calls to mixins/api.js to Consolidate all in-Vue API calls into our mixins/api.js file.Aug 18 2022, 5:32 PM
Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.
DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Aug 30 2022, 6:34 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
• JKieserman claimed this task.Sep 26 2022, 1:07 PM
gerritbot added a comment.Sep 28 2022, 12:59 AM

Change 835722 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] move all API calls in a single mixins/api.js file

https://gerrit.wikimedia.org/r/835722

gerritbot added a project: Patch-For-Review.Sep 28 2022, 12:59 AM
Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:26 PM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:45 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).
Jdforrester-WMF triaged this task as Medium priority.Mar 24 2023, 12:54 AM
gerritbot added a comment.Jun 1 2023, 4:14 PM

Change 835722 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] move all API calls in a single mixins/api.js file

Reason:

No longer applies, sadly.

https://gerrit.wikimedia.org/r/835722

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2023, 4:30 PM
Jdforrester-WMF removed • JKieserman as the assignee of this task.Aug 7 2023, 8:19 PM
Jdforrester-WMF added a subscriber: • JKieserman.
Jdforrester-WMF lowered the priority of this task from Medium to Low.Oct 12 2023, 4:51 PM
Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.
gengh claimed this task.Apr 3 2024, 3:19 PM
gerritbot added a comment.Apr 3 2024, 4:44 PM

Change #1016393 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Centralize API calls in api.js mixin and fix error handling

https://gerrit.wikimedia.org/r/1016393

gerritbot added a project: Patch-For-Review.Apr 3 2024, 4:44 PM
gerritbot added a comment.Apr 3 2024, 5:11 PM

Change #1016393 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Centralize API calls in api.js mixin and fix error handling

https://gerrit.wikimedia.org/r/1016393

gerritbot added a comment.Apr 3 2024, 5:16 PM

Change #1016778 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@wmf/1.42.0-wmf.25] Centralize API calls in api.js mixin and fix error handling

https://gerrit.wikimedia.org/r/1016778

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.26; 2024-04-09).Apr 3 2024, 6:00 PM
gerritbot added a comment.Apr 3 2024, 8:08 PM

Change #1016778 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.42.0-wmf.25] Centralize API calls in api.js mixin and fix error handling

https://gerrit.wikimedia.org/r/1016778

Stashbot added a comment.Apr 3 2024, 8:08 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-03T20:08:52Z] <jforrester@deploy1002> Started scap: Backport for [[gerrit:1016778|Centralize API calls in api.js mixin and fix error handling (T361598 T315432)]]

Stashbot mentioned this in T361598: Adapt front-end to understand new errors after returning HTTP error codes.Apr 3 2024, 8:08 PM
Stashbot added a comment.Apr 3 2024, 8:11 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-03T20:11:18Z] <jforrester@deploy1002> jforrester: Backport for [[gerrit:1016778|Centralize API calls in api.js mixin and fix error handling (T361598 T315432)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Apr 3 2024, 8:23 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-03T20:23:50Z] <jforrester@deploy1002> Finished scap: Backport for [[gerrit:1016778|Centralize API calls in api.js mixin and fix error handling (T361598 T315432)]] (duration: 14m 58s)

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.25; 2024-04-02); removed MW-1.42-notes (1.42.0-wmf.26; 2024-04-09).Apr 3 2024, 9:00 PM
gengh moved this task from Backlog to Verify in production on the Abstract Wikipedia team board.Apr 15 2024, 8:46 AM
Jdforrester-WMF closed this task as Resolved.Apr 16 2024, 2:52 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL