(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T310318

Cite tool has performance problems when many citations are in an article
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Open a page with hundreds of refs, e.g., https://en.wikipedia.org/wiki/COVID-19_vaccine?veaction=edit&section=22
  2. Try to re-use a ref by searching for a relevant keyword, e.g., last or news.
  3. Wait for about three minutes.
  4. Get your result.

Once it's processed the refs, it's much faster. It's just the initial search that takes so long.

Can be tested on beta:
https://en.wikipedia.beta.wmflabs.org/wiki/COVID-19_vaccine?veaction=edit

Details

SubjectRepoBranchLines +/-
Use useView mode of PreviewElement for re-use search widgetmediawiki/extensions/Citemaster+2 -1
Customize query in gerrit

Event Timeline

• Whatamidoing-WMF created this task.Jun 9 2022, 9:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2022, 9:51 PM
Maintenance_bot added a project: VisualEditor.Jun 9 2022, 10:29 PM
gerritbot added a comment.Jun 15 2022, 3:32 PM

Change 805842 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/Cite@master] Use useView mode of PreviewElement for re-use search widget

https://gerrit.wikimedia.org/r/805842

gerritbot added a project: Patch-For-Review.Jun 15 2022, 3:32 PM
• Esanders added a comment.Jun 15 2022, 3:55 PM

Monkey patching the above on the example @Whatamidoing-WMF provided, the list opens in about 1.5 seconds, whereas before the whole page just froze for minutes.

• Esanders updated the task description. (Show Details)Jun 15 2022, 3:56 PM
gerritbot added a comment.Jun 15 2022, 7:01 PM

Change 805842 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Use useView mode of PreviewElement for re-use search widget

https://gerrit.wikimedia.org/r/805842

Maintenance_bot removed a project: Patch-For-Review.Jun 15 2022, 7:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 15 2022, 8:00 PM
matmarex added a project: Editing-team (Kanban Board).Jun 15 2022, 9:21 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.Jun 15 2022, 9:37 PM
matmarex added a project: Editing QA.
EAkinloose edited projects, added Verified; removed Editing QA.Jun 28 2022, 12:12 AM
EAkinloose subscribed.

Cit tool performance is improved despite many citations. See https://photos.app.goo.gl/fxD7DH9qAsoT3Kf27.

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jun 28 2022, 12:12 AM
ppelberg closed this task as Resolved.Jul 8 2022, 12:53 AM
ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits