(Go: >> BACK << -|- >> HOME <<)

Page MenuHomePhabricator

Rename template dialog "pocSidebar"
Closed, ResolvedPublic1 Estimated Story Points

Description

This sidebar is no longer a "proof of concept". Rename to "sidebar", perhaps?

Any conditionals like if ( this.pocSidebar ) can be rewritten, this is always true now.

Try to clean up this issue in MWTemplateDialog:

// FIXME: This is created at the wrong time. That's why we run into the situation
//  where an old instance exists. Should be in initialize().

Event Timeline

lilients_WMDE set the point value for this task to 1.

Change 806910 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/VisualEditor@master] Rename template dialog pocSidebar

https://gerrit.wikimedia.org/r/806910

Change 806910 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Rename template dialog pocSidebar

https://gerrit.wikimedia.org/r/806910

Change 806938 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove some "pocSidebar" related pieces from template dialog

https://gerrit.wikimedia.org/r/806938

Change 806938 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove some "pocSidebar" related pieces from template dialog

https://gerrit.wikimedia.org/r/806938

thiemowmde claimed this task.