(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T309768

TypeError: Cannot read properties of undefined (reading 'dailyLimit')
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
TypeError: Cannot read properties of undefined (reading 'dailyLimit')
exception.trace





Impact



    

  • When the quality gate limit is reached, the user can proceed to the article but will see a "No suggestions found" dialog (instead of seeing a quality gate-specific dialog on Special:Homepage). For users who have not reached the quality gate limit, the experience is the not impacted.
    • 




Notes



Somehow the quality gate data is not exported with the taskset, not sure why.
Details
SubjectRepoBranchLines +/-
NewcomerTasksStore: Check if taskData is set before usingmediawiki/extensions/GrowthExperimentsmaster+2 -2
NewcomerTasksStore: update quality gate config when the task queue is setmediawiki/extensions/GrowthExperimentsmaster+1 -0
NewcomerTasksStore: update quality gate config when the task queue is setmediawiki/extensions/GrowthExperimentswmf/1.39.0-wmf.15+1 -0
Customize query in gerrit
Related Objects
Event Timeline
kostajh created this task.Jun 2 2022, 8:26 AM
Restricted Application added a subscriber: Aklapper.  ·  View Herald TranscriptJun 2 2022, 8:26 AM
Umherirrender added a project: JavaScript.Jun 2 2022, 6:16 PM
• mewoph merged a task: T309891: TypeError: Cannot read properties of undefined (reading 'dailyLimit').Jun 3 2022, 7:41 PM
• mewoph subscribed.
• mewoph claimed this task.Jun 3 2022, 7:50 PM
• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph updated the task description. (Show Details)
• mewoph added a comment.Jun 3 2022, 8:01 PM
This regressed from T308542: Suggested edits: Populate task queue from server-side. Previously the quality gate config is set when the first task is populated. When the logic was changed to be a task queue, the quality gate config was not set.
gerritbot added a comment.Jun 3 2022, 8:02 PM
Change 802855 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):



[mediawiki/extensions/GrowthExperiments@master] NewcomerTasksStore: update quality gate config when the task queue is set



https://gerrit.wikimedia.org/r/802855
gerritbot added a project: Patch-For-Review.Jun 3 2022, 8:02 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 3 2022, 8:03 PM
• mewoph updated the task description. (Show Details)Jun 3 2022, 8:06 PM
• mewoph updated the task description. (Show Details)Jun 3 2022, 8:21 PM
Sgs subscribed.Jun 8 2022, 10:45 AM
Error







normalized_message
TypeError: this.config.gateConfig[taskType] is undefined





Impact



~70 events in the last couple of days in group2



Error







normalized_message
TypeError: undefined is not an object (evaluating 'this.config.gateConfig[taskType].dailyLimit')





Impact



~22 events in last couple of days in group2



Notes



Adding these two errors here instead of re-opening previous tasks with the same error exception since the cause seems the regression mentioned above. @mewoph can you confirm that these two exceptions will also be fixed with the patch?
• mewoph added a comment.Jun 8 2022, 3:53 PM
Hi @Sgs, the different messages are from different browsers so the fix should address all of them.
Sgs added a comment.Jun 8 2022, 5:08 PM


In T309768#7989499, @mewoph wrote:


Hi @Sgs, the different messages are from different browsers so the fix should address all of them.





Alright. Thank you.
gerritbot added a comment.Jun 8 2022, 6:42 PM
Change 802855 merged by jenkins-bot:



[mediawiki/extensions/GrowthExperiments@master] NewcomerTasksStore: update quality gate config when the task queue is set



https://gerrit.wikimedia.org/r/802855
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 8 2022, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 8 2022, 7:30 PM
thcipriani moved this task from Untriaged to Jun 2022 on the Wikimedia-production-error board.Jun 9 2022, 4:09 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 10 2022, 10:49 AM
Jdlrobson added a parent task: T308070: 1.39.0-wmf.17 deployment blockers.Jun 10 2022, 9:42 PM
gerritbot added a comment.Jun 13 2022, 12:51 PM
Change 804712 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):



[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.15] NewcomerTasksStore: update quality gate config when the task queue is set



https://gerrit.wikimedia.org/r/804712
gerritbot added a project: Patch-For-Review.Jun 13 2022, 12:51 PM
gerritbot added a comment.Jun 13 2022, 1:15 PM
Change 804712 merged by jenkins-bot:



[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.15] NewcomerTasksStore: update quality gate config when the task queue is set



https://gerrit.wikimedia.org/r/804712
kostajh added subscribers: Urbanecm_WMF, Etonkovidova.Jun 13 2022, 1:19 PM


In T309768#7998513, @gerritbot wrote:


Change 804712 merged by jenkins-bot:



[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.15] NewcomerTasksStore: update quality gate config when the task queue is set



https://gerrit.wikimedia.org/r/804712





@Etonkovidova, @Urbanecm_WMF and I backported this today, so the fix should be everywhere now.
Stashbot added a comment.Jun 13 2022, 1:22 PM
Mentioned in SAL (#wikimedia-operations) [2022-06-13T13:22:56Z] <urbanecm@deploy1002> Synchronized php-1.39.0-wmf.15/extensions/GrowthExperiments/modules/ext.growthExperiments.DataStore/NewcomerTasksStore.js: 67a5352b0bf9f6aa160cc93a42ca22a02aad883a: NewcomerTasksStore: update quality gate config when the task queue is set (T309768) (duration: 03m 41s)
Maintenance_bot removed a project: Patch-For-Review.Jun 13 2022, 1:30 PM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.15; 2022-06-06); removed MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 13 2022, 2:00 PM
gerritbot added a comment.Jun 15 2022, 10:36 AM
Change 805770 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):



[mediawiki/extensions/GrowthExperiments@master] NewcomerTasksStore: Check if taskData is set before using



https://gerrit.wikimedia.org/r/805770
gerritbot added a project: Patch-For-Review.Jun 15 2022, 10:36 AM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.17; 2022-06-20); removed MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 15 2022, 4:00 PM
hashar closed this task as Resolved.Jun 21 2022, 7:31 AM
hashar subscribed.
Looks like that one has been fixed by @kostajh for 1.39.0-wmf.15 and is not a blocker for 1.39.0-wmf.17
hashar removed a parent task: T308070: 1.39.0-wmf.17 deployment blockers.Jun 21 2022, 7:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits