(Go: >> BACK << -|- >> HOME <<)

Page MenuHomePhabricator

Clean up feature flags except for new transclusion dialog sidebar
Closed, ResolvedPublic8 Estimated Story Points

Description

Once we're comfortable with our new features, we should remove the configuration and logic from the extensions and mediawiki-config:

  • wgCodeMirrorAccessibilityColors (2 points)
  • Remove the flag, remove config, merge CSS AccessibilityColors with main
  • wgCodeMirrorColorblindColors (1 point)
  • Remove the flag, remove config
  • wgCodeMirrorEnableBracketMatching (2 points)
  • Remove the flag, remove config, cleanup tests
  • wgTemplateDataSuggestedValuesEditor
  • wgVisualEditorTransclusionDialogSuggestedValues (2 points for both)
  • Remove the flags, remove config, cleanup tests
  • wgTemplateWizardTemplateSearchImprovements
  • wgVisualEditorTemplateSearchImprovements (3 points for both)
  • Remove the flags, remove config
    • Might be that some code needs to stay for non Cirrus users
  • wgVisualEditorTransclusionDialogBackButton (2 points for both)
  • Remove the flags, remove config
  • wgVisualEditorTransclusionDialogInlineDescriptions (3 points)
  • Remove the flags, remove config, merge CSS

* [] Remove feature flags from wmf-config repo.
* [] These features will now be enabled by default for third-party wikis, so find an appropriate communication method to pass along that news.

Details

SubjectRepoBranchLines +/-
mediawiki/extensions/TemplateDatamaster+1 -22
mediawiki/extensions/CodeMirrormaster+7 -8
mediawiki/extensions/TemplateWizardmaster+3 -38
mediawiki/extensions/VisualEditormaster+4 -4
mediawiki/extensions/Citemaster+13 -3
mediawiki/extensions/VisualEditormaster+2 -6
mediawiki/extensions/CodeMirrormaster+144 -133
mediawiki/extensions/CodeMirrormaster+31 -39
mediawiki/extensions/Citemaster+1 -1
mediawiki/extensions/VisualEditormaster+58 -138
mediawiki/extensions/Citewmf/1.39.0-wmf.16+13 -3
mediawiki/extensions/VisualEditormaster+17 -31
mediawiki/extensions/CodeMirrormaster+8 -65
mediawiki/extensions/VisualEditormaster+4 -35
mediawiki/extensions/CodeMirrormaster+8 -18
mediawiki/extensions/CodeMirrormaster+8 -19
mediawiki/extensions/CodeMirrormaster+32 -92
mediawiki/extensions/VisualEditormaster+1 -14
Show related patches Customize query in gerrit

Event Timeline

Change 804585 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/CodeMirror@master] Remove $wgCodeMirrorAccessibilityColors feature flag (1/2)

https://gerrit.wikimedia.org/r/804585

Change 804590 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/CodeMirror@master] Merge accessibility-mindful colors into base styles

https://gerrit.wikimedia.org/r/804590

awight added a subscriber: Lena_WMDE.

@Lena_WMDE Can you remind me if we're also planning to drop the $wgCodeMirrorColorblindColors feature flag? There will still be the user preference controlling whether the color schema is enabled or not.

Change 804592 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/CodeMirror@master] Remove $wgCodeMirrorEnableBracketMatching feature flag

https://gerrit.wikimedia.org/r/804592

awight updated the task description. (Show Details)

Change 804594 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Remove $wgVisualEditorTransclusionDialogSuggestedValues feature flag

https://gerrit.wikimedia.org/r/804594

Change 804596 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/TemplateWizard@master] Remove $wgTemplateWizardTemplateSearchImprovements feature flag

https://gerrit.wikimedia.org/r/804596

Change 804598 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Remove $wgVisualEditorTemplateSearchImprovements feature flag

https://gerrit.wikimedia.org/r/804598

Change 804600 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

https://gerrit.wikimedia.org/r/804600

Change 804602 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Remove $wgVisualEditorTransclusionDialogInlineDescriptions feature flag

https://gerrit.wikimedia.org/r/804602

awight renamed this task from Clean up feature flags once they are established defaults to Clean up feature flags except for new transclusion dialog sidebar.Jun 10 2022, 3:34 PM
awight updated the task description. (Show Details)
awight removed a project: Epic.
awight updated the task description. (Show Details)

The new sidebar flag is already covered by work that we're doing separately, as T289049: Disconnect old sidebar from VE template dialog.

Change 804609 had a related patch set uploaded (by Awight; author: Awight):

[operations/mediawiki-config@master] [DNM] Drop deprecated feature flags

https://gerrit.wikimedia.org/r/804609

@Lena_WMDE Can you remind me if we're also planning to drop the $wgCodeMirrorColorblindColors feature flag? There will still be the user preference controlling whether the color schema is enabled or not.

Yes, please remove the feature flag.

Shall we remove the feedback dialog leading to https://meta.wikimedia.org/wiki/Talk:WMDE_Technical_Wishes/VisualEditor_template_dialog_improvements ?

I'm not sure what you mean by the "feedback dialog" - could you explain further?

Change 804585 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Remove $wgCodeMirrorAccessibilityColors feature flag

https://gerrit.wikimedia.org/r/804585

Change 804594 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove $wgVisualEditorTransclusionDialogSuggestedValues feature flag

https://gerrit.wikimedia.org/r/804594

Change 804600 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

https://gerrit.wikimedia.org/r/804600

Change 804590 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Merge accessibility-mindful colors into base styles

https://gerrit.wikimedia.org/r/804590

Change 804592 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Remove $wgCodeMirrorEnableBracketMatching feature flag

https://gerrit.wikimedia.org/r/804592

Change 805101 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/CodeMirror@master] Remove $wgCodeMirrorColorblindColors feature flag

https://gerrit.wikimedia.org/r/805101

Change 804596 merged by jenkins-bot:

[mediawiki/extensions/TemplateWizard@master] Remove $wgTemplateWizardTemplateSearchImprovements feature flag

https://gerrit.wikimedia.org/r/804596

lilients_WMDE set the point value for this task to 8.Jun 13 2022, 3:06 PM
lilients_WMDE removed Final Story Points.

Change 805101 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Remove $wgCodeMirrorColorblindColors feature flag

https://gerrit.wikimedia.org/r/805101

Change 805319 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/CodeMirror@master] Merge identical styles in MediaWiki style sheet

https://gerrit.wikimedia.org/r/805319

Change 805345 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/CodeMirror@master] Convert MediaWiki style sheet to LESS code

https://gerrit.wikimedia.org/r/805345

Change 805367 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/CodeMirror@master] Merge some more identical MediaWiki color scheme styles

https://gerrit.wikimedia.org/r/805367

Change 805368 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

https://gerrit.wikimedia.org/r/805368

Change 805372 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Remove $wgVisualEditorTransclusionDialogInlineDescriptions feature flag

https://gerrit.wikimedia.org/r/805372

Change 804598 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove $wgVisualEditorTemplateSearchImprovements feature flag

https://gerrit.wikimedia.org/r/804598

Shall we remove the feedback dialog leading to https://meta.wikimedia.org/wiki/Talk:WMDE_Technical_Wishes/VisualEditor_template_dialog_improvements ?

I'm not sure what you mean by the "feedback dialog" - could you explain further?

In the help dialog we've got this link to Leave feedback that leads to said page.

Feedback.png (212×348 px, 18 KB)

Change 805748 had a related patch set uploaded (by Awight; author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@wmf/1.39.0-wmf.16] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

https://gerrit.wikimedia.org/r/805748

Change 805748 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@wmf/1.39.0-wmf.16] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

Reason:

Decided to go with If68a822 instead.

https://gerrit.wikimedia.org/r/805748

Change 804602 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove $wgVisualEditorTransclusionDialogInlineDescriptions feature flag

https://gerrit.wikimedia.org/r/804602

Change 805372 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Remove $wgVisualEditorTransclusionDialogInlineDescriptions feature flag

https://gerrit.wikimedia.org/r/805372

Change 805319 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Merge identical styles in MediaWiki style sheet

https://gerrit.wikimedia.org/r/805319

All of the extension patches to remove feature flags are merged. The config patch can be split into a separate task, to be deployed after next week's train.

Change 805345 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Convert MediaWiki style sheet to LESS code

https://gerrit.wikimedia.org/r/805345

Shall we remove the feedback dialog leading to https://meta.wikimedia.org/wiki/Talk:WMDE_Technical_Wishes/VisualEditor_template_dialog_improvements ?

I'm not sure what you mean by the "feedback dialog" - could you explain further?

In the help dialog we've got this link to Leave feedback that leads to said page.

Feedback.png (212×348 px, 18 KB)

Thanks @WMDE-Fisch yes the "leave feedback" link can be removed as well.

Change 805780 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/VisualEditor@master] Remove feedback message link

https://gerrit.wikimedia.org/r/805780

Change 805780 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove feedback message link

https://gerrit.wikimedia.org/r/805780

Change 805368 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@master] Remove $wgVisualEditorTransclusionDialogBackButton feature flag

Reason:

Replaced by If68a822 and potentially Id23d3ac.

https://gerrit.wikimedia.org/r/805368

Change 806234 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Stop using deprecated "ParameterPlaceholderPage" class name

https://gerrit.wikimedia.org/r/806234

Change 806234 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Stop using deprecated "ParameterPlaceholderPage" class name

https://gerrit.wikimedia.org/r/806234

Change 805367 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Merge some more identical MediaWiki color scheme styles

https://gerrit.wikimedia.org/r/805367

awight claimed this task.

Change 808849 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TemplateData@master] Remove $wgTemplateDataSuggestedValues feature flag

https://gerrit.wikimedia.org/r/808849

Change 808849 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Remove $wgTemplateDataSuggestedValues feature flag

https://gerrit.wikimedia.org/r/808849