(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T234205

Add cog wheel to the popup to disable ReferencePreviews
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To
lilients_WMDE
Authored By
Tobi_WMDE_SW
Sep 30 2019, 11:51 AM
Tags
Referenced Files
F34052615: Screen Shot 2021-01-28 at 12.19.32.png
Jan 28 2021, 11:23 AM
F34052614: Screen Shot 2021-01-28 at 12.20.55.png
Jan 28 2021, 11:23 AM
F31903498: 450px-Reference_Previews_elements (1).png
Jun 24 2020, 8:06 AM
Subscribers
Aklapper
awight
ECohen_WMDE
Jonesey95
Tobi_WMDE_SW

Description

Show the preferences cog in reference previews:

Screen Shot 2021-01-28 at 12.19.32.png (406×530 px, 137 KB)
Screen Shot 2021-01-28 at 12.20.55.png (404×534 px, 138 KB)

Requirements

Implementation

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/661954

Details

SubjectRepoBranchLines +/-
Minimize and optimize reference preview CSSmediawiki/extensions/Popupsmaster+29 -28
Fix maximum height of reference popups when in betamediawiki/extensions/Popupsmaster+13 -5
Fix maximum height of reference popupsmediawiki/extensions/Popupsmaster+5 -1
Add cogwheel to disable ReferencePreviewsmediawiki/extensions/Popupsmaster+63 -49
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tobi_WMDE_SW created this task.Sep 30 2019, 11:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2019, 11:51 AM
Tobi_WMDE_SW moved this task from Backlog to Before Default on the Reference Previews board.Sep 30 2019, 11:52 AM
thiemowmde mentioned this in T235737: Discuss and decide on underspecified behavior for anonymous users.Oct 17 2019, 9:35 AM
Jonesey95 subscribed.Oct 24 2019, 10:02 PM
ECohen_WMDE subscribed.Jun 19 2020, 3:24 PM
ECohen_WMDE added a comment.Jun 24 2020, 8:06 AM

450px-Reference_Previews_elements (1).png (262×450 px, 24 KB)

Here is a mock that I found on the help page. Could not find the icon in OOUI, do you need the file or do you have it from page previews?

ECohen_WMDE moved this task from Before Default to Ready for pickup on the Reference Previews board.Jun 24 2020, 8:06 AM
awight subscribed.Jul 1 2020, 11:43 AM
In T234205#6251234, @ecohen wrote:

450px-Reference_Previews_elements (1).png (262×450 px, 24 KB)

Here is a mock that I found on the help page. Could not find the icon in OOUI, do you need the file or do you have it from page previews?

Yes, the cog is included in the Popups extension that provides the page previews and reference previews features.

https://github.com/wikimedia/mediawiki-extensions-Popups/blob/master/resources/ext.popups.images/cog.svg

awight updated the task description. (Show Details)Jul 1 2020, 11:45 AM
ECohen_WMDE added a comment.Jul 1 2020, 1:35 PM

Great - then I will assume this task is ready for pickup. Or does it also needs specs? I can ask about getting access to the design files.

awight added a comment.Jul 2 2020, 11:39 AM
In T234205#6271268, @ecohen wrote:

Great - then I will assume this task is ready for pickup. Or does it also needs specs? I can ask about getting access to the design files.

No need! We're just cloning Page Previews, we should even be able to reuse the .less files.

thiemowmde added a parent task: T235737: Discuss and decide on underspecified behavior for anonymous users.Jul 22 2020, 7:11 AM
Lena_WMDE moved this task from Ready for pickup to Before Default on the Reference Previews board.Oct 14 2020, 10:03 AM
ECohen_WMDE mentioned this in T265709: Merge Page Preview and Reference Preview preferences.Oct 16 2020, 9:47 AM
ECohen_WMDE added a subtask: T265709: Merge Page Preview and Reference Preview preferences.
ECohen_WMDE updated the task description. (Show Details)Oct 16 2020, 11:07 AM
ECohen_WMDE moved this task from Before Default to In preparation on the Reference Previews board.
Lena_WMDE updated the task description. (Show Details)Oct 19 2020, 8:59 AM
Lena_WMDE added a project: WMDE-TechWish.
Lena_WMDE set the point value for this task to 3.Oct 19 2020, 9:55 AM
Lena_WMDE moved this task from In preparation to Ready for pickup on the Reference Previews board.
Lena_WMDE moved this task from Ready for pickup to In preparation on the Reference Previews board.Oct 21 2020, 8:28 AM
awight mentioned this in T265482: On click [ref], jump down to references section.Oct 29 2020, 10:56 AM
Lena_WMDE added a parent task: T271206: Enable RefPreviews on first wikis.Jan 5 2021, 3:57 PM
Lena_WMDE removed a parent task: T235737: Discuss and decide on underspecified behavior for anonymous users.Jan 6 2021, 8:42 AM
ECohen_WMDE updated the task description. (Show Details)Jan 28 2021, 11:23 AM
ECohen_WMDE updated the task description. (Show Details)Jan 28 2021, 11:35 AM
Lena_WMDE moved this task from In preparation to Ready for pickup on the Reference Previews board.Feb 3 2021, 9:25 AM
Lena_WMDE updated the task description. (Show Details)
Lena_WMDE edited projects, added WMDE-TechWish (Sprint-2021-02-03); removed WMDE-TechWish.Feb 3 2021, 9:30 AM
lilients_WMDE claimed this task.Feb 3 2021, 1:22 PM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish (Sprint-2021-02-03) board.
lilients_WMDE updated the task description. (Show Details)Feb 4 2021, 9:55 AM
gerritbot added a comment.Feb 5 2021, 3:56 PM

Change 661954 had a related patch set uploaded (by Svantje Lilienthal; owner: Svantje Lilienthal):
[mediawiki/extensions/Popups@master] Add cogwheel to disable ReferencePreviews

https://gerrit.wikimedia.org/r/661954

gerritbot added a project: Patch-For-Review.Feb 5 2021, 3:56 PM
lilients_WMDE updated the task description. (Show Details)Feb 5 2021, 5:14 PM
lilients_WMDE mentioned this in T274105: Provide API for reuse of the page previews settings cog.Feb 8 2021, 10:02 AM
lilients_WMDE updated the task description. (Show Details)Feb 9 2021, 4:18 PM
lilients_WMDE moved this task from Doing to Review on the WMDE-TechWish (Sprint-2021-02-03) board.
Lena_WMDE moved this task from Ready for pickup to Doing on the Reference Previews board.Feb 11 2021, 2:59 PM
gerritbot added a comment.Feb 17 2021, 8:19 AM

Change 661954 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Add cogwheel to disable ReferencePreviews

https://gerrit.wikimedia.org/r/661954

lilients_WMDE moved this task from Review to Demo on the WMDE-TechWish (Sprint-2021-02-03) board.Feb 17 2021, 8:20 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 17 2021, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 17 2021, 9:10 AM
thiemowmde added a project: WMDE-TechWish-Sprint-2021-02-17.Feb 17 2021, 9:13 AM
thiemowmde moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2021-02-17 board.
Lena_WMDE changed the point value for this task from 3 to 0.Feb 17 2021, 9:33 AM
gerritbot added a comment.Feb 17 2021, 10:19 AM

Change 664783 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Fix maximum height of reference popups

https://gerrit.wikimedia.org/r/664783

gerritbot added a project: Patch-For-Review.Feb 17 2021, 10:19 AM

Change 664784 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Minimize and optimize reference preview CSS

https://gerrit.wikimedia.org/r/664784

thiemowmde mentioned this in T276200: Fix smaller design issues related to ReferencePreviews settings icon.Mar 2 2021, 9:23 AM
WMDE-Fisch closed subtask T265709: Merge Page Preview and Reference Preview preferences as Resolved.Mar 2 2021, 9:27 AM
WMDE-Fisch closed this task as Resolved.Mar 2 2021, 9:36 AM
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-02-17 board.
gerritbot added a comment.Mar 5 2021, 12:16 PM

Change 664783 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix maximum height of reference popups

https://gerrit.wikimedia.org/r/664783

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.34; 2021-03-09); removed MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Mar 5 2021, 1:00 PM
gerritbot added a comment.Mar 5 2021, 1:09 PM

Change 668687 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/Popups@master] Fix maximum height of reference popups when in beta

https://gerrit.wikimedia.org/r/668687

gerritbot added a comment.Mar 5 2021, 2:48 PM

Change 668687 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix maximum height of reference popups when in beta

https://gerrit.wikimedia.org/r/668687

Lena_WMDE mentioned this in T277638: Separate user setting for RefPreviews and Page Previews for default.Mar 17 2021, 9:34 AM
gerritbot added a comment.May 3 2021, 11:43 AM

Change 664784 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Minimize and optimize reference preview CSS

https://gerrit.wikimedia.org/r/664784

thiemowmde mentioned this in T346404: When reference previews is a beta feature the settings cog does not display for logged in users.Sep 15 2023, 6:56 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 15 2023, 7:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL