Change 521357 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Add link to Special:Homepage on Special:Contributions

https://gerrit.wikimedia.org/r/521357

@Cntlsn @MMiller_WMF this will be in beta shortly.

Change 521357 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add link to Special:Homepage on Special:Contributions

https://gerrit.wikimedia.org/r/521357

@kostajh thanks, it works good! I only have a little UI note, can we wrap

<div id="mw-content-text">...</div>

into

<div id="bodyContent" class="content">...</div>

just like in User:[username]? This way it should gain a bit of margin on the sides.

Also, the container of the text-box would better have <div class="cta-holder"> just like in User:[username], but that class seems to have no effect. Are we not loading it?

I just tried this out in beta, and it looks good to me. My only question is for @Cntlsn -- do you think that the word "homepage" should be a link, in addition to having the button? Is there a reason to have two links to the same place?

In T227575#5340660, @Cntlsn wrote:

@kostajh thanks, it works good! I only have a little UI note, can we wrap

<div id="mw-content-text">...</div>

into

<div id="bodyContent" class="content">...</div>

just like in User:[username]? This way it should gain a bit of margin on the sides.

I agree that this is inconsistent, and Special:homepage also has a bodyContent div, but none of the mobile-specific special pages (Contributions, Watchlist, EditWatchlist, Diff, History) do. I think that's more likely to be a bug than a feature, but fixing it would be a structural change to the mobile site that would affect much more than just the homepage or the contributions page, so I think that's best left to the Web-Team-Backlog team.

Also, the container of the text-box would better have <div class="cta-holder"> just like in User:[username], but that class seems to have no effect. Are we not loading it?

It looks like the cta-holder class and its styling are specific to the mobile userpage. I found these styles in a file called userpage.less, so it makes sense that that file is not loaded on the contributions page. I also don't see what that class would get us, other than slightly different padding and a border-radius (which we can add separately if you like). Instead, I'm using the warningbox class, which seems appropriate for the context.

@Catrope -- similarly to T225328, we want to remove the link in the text, leaving only the link on the button. Moving back to In Progress and changing the task description now.

@Catrope -- similarly to T225328, we want to remove the link in the text, leaving only the link on the button. Moving back to In Progress and changing the task description now.

This was done in this patch and is ready for QA.

Note: 'homepage' is not capitalized e.g. 'Homepage'?

Users with Homepage enabled by default would see:

Users who not get Homepage by default (or not enabled it, or disabled it) would see the old no-contributions page:

@Cntlsn -- could you please prioritize the design review on this so that we can keep the feature rolling with this week's train?

@Etonkovidova -- that's correct. The name of the feature, "homepage", is not capitalized.

@MMiller_WMF -- per @Catrope's comment above T227575#5347835, the UI fixes I proposed won't go through. I will move the task to the "Needs PM Review" column, but how do we make sure this would make it to the Web-Team-Backlog? Shall we create a separate task?

@Etonkovidova -- have you validated that EventLogging to homepagevisit works correctly for this and that the right thing goes into the referer_route field?

In T227575#5359740, @MMiller_WMF wrote:

@Etonkovidova -- have you validated that EventLogging to homepagevisit works correctly for this and that the right thing goes into the referer_route field?

Yes, betalabs eventlogging HomepageVisit table records event_referer_route='specialcontributions and event_is_mobile=1 (needs to be checked in production too).