CX2: Doesn't handle correctly ISBN, should not put nowiki tags around them
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	NicoV
	Jan 9 2019, 10:40 AM

Description

CX2 should handle correctly ISBN rather than putting nowiki tags around them, either with the ISBN template, or just plain text (and letting MediaWiki do the magic links if it's configured to do so)

Example

Example on frwiki "Conservation russe" : original translation, manual fix

When translating Русская беседа from Russian to French. The bibliography section has an ISBN code in the original article that is presented in different ways: in the original article it is shown as an "ISBN Link" in Visual Editor, and as plain text "ISBN 978-5-211-05327-4." string in wikitext. In Content translation it is rendered as a regular link for the source document and adapted as an empty link in the translation. Finally, when the translation is published, it results in "<nowiki>ISBN 978-5-211-05327-4</nowiki>".

Empty link shown when added to the translation:

Screenshot 2019-03-04 at 11.12.54.png (370×1 px, 113 KB)

Link on the source document:

Screenshot 2019-03-04 at 11.15.30.png (371×1 px, 114 KB)

__
Related:

Details

	Subject	Repo	Branch	Lines +/-
	Update cxserver to 2019-09-04-065911-production	operations/deployment-charts	master	+3 -3
	Add ISBN support	mediawiki/services/cxserver	master	+61 -4

Customize query in gerrit

Related Objects

Mentioned In: T206310: CX2: Highlight references with a template that is missing mandatory parameters after being adapted
rDEPLOYCHARTSa4ec99409aa3: Update cxserver to 2019-09-04-065911-production
T217585: CX2: ISBN doubled, one correctly formatted with {{ISBN}}, another incorrectly formatted with [[Special:BookSources]]
T217187: VisualEditor adds nowiki-tags around ISBNs
T213256: CX2: Outputs unnecessary self-closing nowiki and div tags inside ref tags
Mentioned Here: T206310: CX2: Highlight references with a template that is missing mandatory parameters after being adapted
T217585: CX2: ISBN doubled, one correctly formatted with {{ISBN}}, another incorrectly formatted with [[Special:BookSources]]

Event Timeline

NicoV created this task.Jan 9 2019, 10:40 AM

Restricted Application added subscribers: jeblad, Aklapper. · View Herald TranscriptJan 9 2019, 10:40 AM

Pginer-WMF mentioned this in T213256: CX2: Outputs unnecessary self-closing nowiki and div tags inside ref tags.Jan 21 2019, 2:24 PM

Pginer-WMF triaged this task as Medium priority.Jan 24 2019, 5:17 PM

Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.

Pginer-WMF added a project: Language-Team (Language-2019-January-March).Feb 18 2019, 3:12 PM

Pginer-WMF merged a task: T145183: CX adds unnecessary nowiki around ISBN (again).Feb 18 2019, 3:15 PM

Pginer-WMF added a subscriber: Amire80.

Pginer-WMF updated the task description. (Show Details)Mar 4 2019, 10:26 AM

Cirdan subscribed.Mar 6 2019, 12:13 PM

Cirdan mentioned this in T217187: VisualEditor adds nowiki-tags around ISBNs.Mar 6 2019, 12:15 PM

Pginer-WMF mentioned this in T217585: CX2: ISBN doubled, one correctly formatted with {{ISBN}}, another incorrectly formatted with [[Special:BookSources]].Mar 18 2019, 3:42 PM

Pginer-WMF updated the task description. (Show Details)

Pginer-WMF edited projects, added Language-Team (Language-2019-April-June); removed Language-Team (Language-2019-January-March).Mar 29 2019, 11:39 PM

Pginer-WMF updated the task description. (Show Details)Jun 10 2019, 3:07 PM

Pginer-WMF edited projects, added Language-Team (Language-2019-July-September); removed Language-Team (Language-2019-April-June).Jul 9 2019, 1:47 PM

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-July-September) board.Jul 29 2019, 10:57 AM

santhosh claimed this task.Sep 3 2019, 6:28 AM

Change 534011 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Add ISBN support

https://gerrit.wikimedia.org/r/534011

gerritbot added a project: Patch-For-Review.Sep 3 2019, 7:01 AM

santhosh moved this task from Priority backlog to In Review on the Language-Team (Language-2019-July-September) board.Sep 3 2019, 7:24 AM

Change 534011 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Add ISBN support

https://gerrit.wikimedia.org/r/534011

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2019, 7:10 AM

Change 534427 had a related patch set uploaded (by KartikMistry; owner: KartikMistry):
[operations/deployment-charts@master] Update cxserver to 2019-09-04-065911-production

https://gerrit.wikimedia.org/r/534427

gerritbot added a project: Patch-For-Review.Sep 4 2019, 12:04 PM

Change 534427 merged by KartikMistry:
[operations/deployment-charts@master] Update cxserver to 2019-09-04-065911-production

https://gerrit.wikimedia.org/r/534427

KartikMistry mentioned this in rDEPLOYCHARTSa4ec99409aa3: Update cxserver to 2019-09-04-065911-production.Sep 5 2019, 6:35 AM

Mentioned in SAL (#wikimedia-operations) [2019-09-05T06:44:05Z] <kart_> Updated cxserver to 2019-09-04-065911-production (T213255, T206310)

Stashbot mentioned this in T206310: CX2: Highlight references with a template that is missing mandatory parameters after being adapted.Sep 5 2019, 6:44 AM

santhosh moved this task from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.Sep 5 2019, 6:48 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 5 2019, 7:10 AM

@Pginer-WMF should we move the related tasks to done as well?

In T213255#5477679, @Jpita wrote:

@Pginer-WMF should we move the related tasks to done as well?

I'd suggest doing the following:

If they provide an example that can be reproduced, test them and close them if they are solved
If they just complain about lack of ISBN support without anything else actionable, close them mentioning we improved the support in this ticket.

Hi.
Is it in production? Meaning, if we see problems with new translations, it means the fix is not complete?

In T213255#5477903, @NicoV wrote:

Hi.
Is it in production? Meaning, if we see problems with new translations, it means the fix is not complete?

I assume it is in production already, but @KartikMistry can confirm whether all the code for this was deployed. However, it is possible that a translation was started before the fix, the ISBNs were not properly handled when added to the translation, and the translation gets published after the fix. So the relevant translations to check are those started after the fix (not just those published after). In any case, feel free to report problematic instances and we can check when those were created and investigate further.

For example, T217585 seems to happen still, I've added a recent example

Does it include also problems with BookSource, like this article on frwiki ?

[[:de:Special:BookSources/3885068397|ISBN 3-88506-839-7]] and so on

	F28323677: Screenshot 2019-03-04 at 11.15.30.png
	Mar 4 2019, 10:26 AM

	F28323647: Screenshot 2019-03-04 at 11.12.54.png
	Mar 4 2019, 10:26 AM