(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T205433

Exception "User account is not global" on Special:ContentTranslation with lang/target params
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

For example, if I open https://dev.translatewiki.net/w/i.php?title=Special:ContentTranslation&page=Vantaa&from=en&to=es&targettitle=Vantaa&version=2 in incognito mode, I get the following error:

[946fc2b6f7ea09fc38e7af62] /w/i.php?title=Special:ContentTranslation&page=Vantaa&from=en&to=es&targettitle=Vantaa&version=1 Exception from line 20 of /www/dev.translatewiki.net/docroot/w/extensions/ContentTranslation/includes/Translator.php: User account is not global

Backtrace:

#0 /www/dev.translatewiki.net/docroot/w/extensions/ContentTranslation/specials/SpecialContentTranslation.php(104): ContentTranslation\Translator->getGlobalUserId()
#1 /www/dev.translatewiki.net/docroot/w/extensions/ContentTranslation/specials/SpecialContentTranslation.php(151): SpecialContentTranslation->isExistingTranslation()
#2 /www/dev.translatewiki.net/docroot/w/extensions/ContentTranslation/specials/SpecialContentTranslation.php(187): SpecialContentTranslation->onTranslationView()
#3 /www/dev.translatewiki.net/docroot/w/extensions/ContentTranslation/specials/ContentTranslationSpecialPage.php(23): SpecialContentTranslation->getRedirectURL()
#4 /www/dev.translatewiki.net/docroot/w/includes/specialpage/SpecialPage.php(569): ContentTranslationSpecialPage->execute(NULL)
#5 /www/dev.translatewiki.net/docroot/w/includes/specialpage/SpecialPageFactory.php(581): SpecialPage->run(NULL)
#6 /www/dev.translatewiki.net/docroot/w/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#7 /www/dev.translatewiki.net/docroot/w/includes/MediaWiki.php(868): MediaWiki->performRequest()
#8 /www/dev.translatewiki.net/docroot/w/includes/MediaWiki.php(525): MediaWiki->main()
#9 /www/dev.translatewiki.net/docroot/w/index.php(42): MediaWiki->run()
#10 {main}

This can happen in two ways:

  1. Session has expired when user clicks to continue a draft on the dashboard
  2. Direct access via browser history or bookmarks

Logstash has 88 instances of this for the past 7 days. That is not a lot, but it's still log spam that should be fixed.

Suggested fix: Check if user is anonymous before loading the draft. This is mostly easily done on the PHP side, and it can display a nicely formatted error message instead. For example using SpecialPage::requireLogin.

Details

SubjectRepoBranchLines +/-
Show login page if anon user try to access existing translationmediawiki/extensions/ContentTranslationwmf/1.32.0-wmf.24+9 -1
Show login page if anon user try to access existing translationmediawiki/extensions/ContentTranslationmaster+9 -1
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Sep 25 2018, 1:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2018, 1:26 PM
KartikMistry subscribed.Sep 26 2018, 7:26 AM
Krinkle renamed this task from Exception when trying to access a draft as anonymous user to Exception "User account is not global" on Special:ContentTranslation with lang/target params.Oct 1 2018, 11:29 PM
Krinkle added a project: Wikimedia-production-error.
Krinkle triaged this task as High priority.Oct 1 2018, 11:46 PM
Krinkle moved this task from Untriaged to Older on the Wikimedia-production-error board.
Krinkle subscribed.

Tentatively triaging as high priority due to the exposed fatal exception on a public GET url that actively contributes to false alarms. Under that priority, I don't particularly mind what printed result is for users, as long as it doesn't produce HTTP 500 or log under fatal/exception. Anything less severe that that would make it increasingly less impactful.

Recent data:

  • capture.png (1×2 px, 80 KB)
  • Example https://id.wikipedia.org/w/index.php?title=Istimewa:ContentTranslation&page=Yodeling&from=en&to=id&targettitle=Yodel (reproducible when logged-out).
Pginer-WMF added a project: Language-2018-Oct-December.Oct 3 2018, 7:33 AM
Pginer-WMF moved this task from Backlog to Maintenance backlog on the Language-2018-Oct-December board.
Arrbee edited projects, added Language-Team (Language-2018-October-December); removed Language-2018-Oct-December.Oct 4 2018, 4:47 PM
Arrbee moved this task from Backlog to Maintenance backlog on the Language-Team (Language-2018-October-December) board.
• santhosh claimed this task.Oct 9 2018, 9:45 AM
• santhosh moved this task from Maintenance backlog to In Progress on the Language-Team (Language-2018-October-December) board.
gerritbot subscribed.Oct 9 2018, 9:55 AM

Change 465379 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Show login page if anon user try to access existing translation

https://gerrit.wikimedia.org/r/465379

gerritbot added a project: Patch-For-Review.Oct 9 2018, 9:55 AM
• santhosh moved this task from In Progress to In Review on the Language-Team (Language-2018-October-December) board.Oct 9 2018, 9:55 AM
gerritbot added a comment.Oct 10 2018, 3:48 PM

Change 465379 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Show login page if anon user try to access existing translation

https://gerrit.wikimedia.org/r/465379

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 10 2018, 4:00 PM
gerritbot added a comment.Oct 10 2018, 9:04 PM

Change 465765 had a related patch set uploaded (by Krinkle; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@wmf/1.32.0-wmf.24] Show login page if anon user try to access existing translation

https://gerrit.wikimedia.org/r/465765

gerritbot added a comment.Oct 10 2018, 9:31 PM

Change 465765 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@wmf/1.32.0-wmf.24] Show login page if anon user try to access existing translation

https://gerrit.wikimedia.org/r/465765

Krinkle closed this task as Resolved.Oct 10 2018, 9:50 PM
Krinkle removed a project: Patch-For-Review.
Stashbot subscribed.Oct 10 2018, 9:51 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-10T21:50:55Z] <krinkle@deploy1001> Synchronized php-1.32.0-wmf.24/extensions/ContentTranslation/specials/SpecialContentTranslation.php: T205433 - Ib34b28c5bb114c (duration: 00m 49s)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)); removed MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 10 2018, 10:00 PM
• Petar.petkovic moved this task from In Review to Done on the Language-Team (Language-2018-October-December) board.Oct 11 2018, 9:11 AM
• Petar.petkovic moved this task from Needs Triage to Bugs on the ContentTranslation board.
Krinkle mentioned this in Blog Post: Production Excellence #4: October 2018.Nov 28 2018, 5:37 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL