(Go: >> BACK << -|- >> HOME <<)

Page MenuHomePhabricator

Deal with no longer used noicon/noplayer mode of TMH
Closed, ResolvedPublic

Description

The former OggHandler had a 'noicon' mode but I don't believe that TMH still effectively does anything with that option any longer. Should investigate and decide on what to do with it.

Wonder how much this option is used in the content, and if we can afford to just drop it from the syntax (which probably would cause these to be interpreted as captions).

Event Timeline

TheDJ renamed this task from Deal with no longer used noicon mode of TMH to Deal with no longer used noicon/noplayer mode of TMH.May 13 2016, 8:12 AM
TheDJ assigned this task to cscott.
TheDJ updated the task description. (Show Details)

Assigning this to scott in hopes that he can help figure out how much this is present in our wikitext.

I think flagging them as bogus options will be a nice fix. Beyond that I don't think we need to worry about them for Parsoid, and should drop special-casing them from TMH eventually (maybe after a year of them being actively purged via Linter).

noicon is a magic word of the timedmediahandler, it seems odd to mark it as error when it is part of the extension. Remove it from the extension and ignore it for b/c reasons seems a better way.

Aklapper added a subscriber: cscott.

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)

Both of these are only present as references in the testcases and the magic words dictionary of TMH and parsoid. They have not worked for over 11 years (commit c6763ff4f34f8be0d282f665a6f8ddaba043fc92), so when used they have been showing as a caption for 11 years already. I think that is more than argument enough to remove any remaining remnants.

Change 801426 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Remove noicon and noplayer options from TMH wikisyntax

https://gerrit.wikimedia.org/r/801426

Change 802574 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Stop recognizing noicon and noplayer media options

https://gerrit.wikimedia.org/r/802574

Change 801426 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Remove noicon and noplayer options from TMH wikisyntax

https://gerrit.wikimedia.org/r/801426

Change 802574 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Stop recognizing noicon and noplayer media options

https://gerrit.wikimedia.org/r/802574

TheDJ claimed this task.

Change 806477 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a13

https://gerrit.wikimedia.org/r/806477

Change 806477 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a13

https://gerrit.wikimedia.org/r/806477