I just noticed I've copy&pasted wrong browserSupport. Not sure if that matters. Using ES6, so no IE support.

Thanks -- looks good in general.
There is a larger question about how many different ISBN searches we're going to add. I think in general this one makes sense -- we don't have good coverage of Poland/Eastern Europe in the current ISBN searches -- but this is run on every single ISBN that people input and makes things a bit slower, so there is a real downside to keep adding these.
@dstillman what's your view on this? One option would be to just run this on ISBNs with Polish region code -- that's surely going to miss some stuff (e.g. other Eastern countries well represented in the NLP) but it would avoid the issue above.

...One option would be to just run this on ISBNs with Polish region code -- that's surely going to miss some stuff (e.g. other Eastern countries well represented in the NLP) but it would avoid the issue above.

I happen to have access to full dump of BN. I'll check for patterns in ISBN.

Filtering by /^(97883|83)/ might work. Stats from the database:

• pl83: 1 085 412
• total with ~valid isbn: 1 433 909

Stats SQL:

select 'pl83' as type, sum(isbn_count) from temp_isbn_short
--select * from temp_isbn_short
where isbn_prefix ~ '^97883' or isbn_prefix ~ '^83'
union all
select 'total with ~valid isbn', sum(isbn_count) from temp_isbn_short
;

Prefix data of BN:
data-isbn-short.csv

Oh yes, I think that's a strong case for prefiltering ISBNs. (which would then also allow us to add many more ISBN translators). @dstillman would it make more sense to do this in the identifier code or the translators individually (which I think we can already do?)

Much better to do it in the translator detect code — then it'll just work everywhere.

Done. Added a simple filter which should be fast.

@adam3smith Hi. I think I resolved everything here, but please let me know if there is more work for me to do? Otherwise, could you re-run tests and merge?

Hi, I've updated the base for my pull request so merging should be easy.

Maybe this linter will work too... Although I don't know where the version number '65161a4967b2...' came from in the script. From what I see it's some change from 2022-10-28:
OUP: Lint, add authors from DOM if necessary (#2898)

(I believe CI fails if there have been any CI-relevant changes on the master branch while the PR is under review)

edit: I don't know either then ;)

Sorry for the delay -- I wanted to spend some time testing this to make sure this works as intended, since we haven't used the idea of restricting to ISBN regions before -- it's looking great and I'm very excited that this means we'll be able to add other national (or quasi-national) libraries to ISBN search without real costs.