feat: some macro methods for Android PermissionHelper #4186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jeromelaban
reviewed
Oct 1, 2020
|
Can I get any reaction for this PR (updated version)? |
1 similar comment
|
Can I get any reaction for this PR (updated version)? |
jeromelaban
reviewed
Oct 23, 2020
|
Can I get any response/review of this PR? |
|
So, one method is removed (if you don't want it), but another is still present. |
|
Sorry, I removed bad method :) Not the method you doesn't want... |
agneszitte
reviewed
Sep 13, 2022
|
@pkar70 there is come conflicts to be resolved for this PR ;) |
Co-authored-by: Agnès ZITTE <16295702+agneszitte-nventive@users.noreply.github.com>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Some scenarios dealing with permissions on Android are complicated.
What is the new behavior?
Three methods added:
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
This PR would be used in several of my other PRs, and probably also by by others.
Internal Issue (If applicable):