(Go: >> BACK << -|- >> HOME <<)

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iOS): MediaPlayerElement controls visibility #17386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajpinedam
Copy link
Contributor

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The MPE in iOS, when used in combination with NativeFrameNavigation, does not display the Player Controls correctly, preventing the user from using them.

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@ajpinedam ajpinedam self-assigned this Jul 4, 2024
@ajpinedam ajpinedam requested a review from kazo0 July 4, 2024 18:52
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17386/index.html

@ajpinedam
Copy link
Contributor Author

Fix running on a sample application:

Fluent Material
ios-uno-mpe-controls-fluent-fix ios-uno-mpe-controls-material-fix

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17386/index.html

Comment on lines +6 to +7
xmlns:not_ios="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:ios="http://platform.uno/ios"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should technically also be an issue on Android. It may be trying to render a native android app bar inside of the MediaTransportControls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Let me run the sample on an Android device

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly, there is no issue with Android. This is running the latest stable Uno.SDK 5.2.175

Material Fluent
android-uno-mpe-controls-material android-uno-mpe-controls-fluent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants