(Go: >> BACK << -|- >> HOME <<)
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove ApplyDataContext method (deprecated) that's causing invalid data context #17239

Merged
merged 2 commits into from
Jun 28, 2024
Merged

fix: Remove ApplyDataContext method (deprecated) that's causing invalid data context #17239

merged 2 commits into from
Jun 28, 2024

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): closes #17237

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

DataContext is being set to null on the new instance, despite code that clones properties correctly updating the DataContext

What is the new behavior?

ApplyDataContext method has been removed to avoid incorrectly setting the DataContext

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@nickrandolph
Copy link
Contributor Author

@mergify backport release/stable/5.3

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 20, 2024 •
edited
Loading

backport release/stable/5.3

✅ Backports have been created

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17239/index.html

ajpinedam
ajpinedam approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor
@ajpinedam ajpinedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niice! 🚀

@jeromelaban
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17239/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17239/index.html

@nventive-devops
Copy link
Contributor

The build 130549 found UI Test snapshots differences: android-28-net8: 19, android-28-net8-Snap: 38, ios: 5, ios-Snap: 45, skia-gtk-screenshots: 24, skia-linux-screenshots: 26, skia-windows-screenshots: 22, wasm: 350, wasm-automated-net8.0-UWP-Default-automated: 21, wasm-automated-net8.0-UWP-RuntimeTests-0: 0, wasm-automated-net8.0-UWP-RuntimeTests-1: 0, wasm-automated-net8.0-UWP-RuntimeTests-2: 0, wasm-automated-net8.0-WinUI-Benchmarks-automated: 0, wasm-automated-net8.0-WinUI-RuntimeTests-0: 0, wasm-automated-net8.0-WinUI-RuntimeTests-1: 0, wasm-automated-net8.0-WinUI-RuntimeTests-2: 0

Details

  • android-28-net8: 19 changed over 829

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
    • DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
    • When_Clip_Is_Set_On_Child_Element_validation
    • When_Clipped_Rounded_Corners_UITests_Windows_UI_Xaml_Clipping_Clipping4273
    • When_Clip_Is_Set_On_Child_Element_original
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • RadioButtons_Disable_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_RadioButton_IsEnabled_Automated
    • WebView_NavigateToLongString_AfterSuccess
    • When_InListView_after_scroll
    • When_InScrollViewer_after_scroll
    • Detereminate_ProgressRing_Validation0_[#FF0000_#FF0000_#FF0000_#FF0000]_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRing
    • When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
    • UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage

  • android-28-net8-Snap: 38 changed over 1064

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse
    • Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
    • Scrolling_MUXControlsTestApp_ScrollViewDynamicPage_MUXControlsTestApp_ScrollViewDynamicPage
    • Scrolling_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage
    • TextBox_WASM_Multiline_TextBox_UITests_Windows_UI_Xaml_Controls_TextBox_WASM_Multiline
    • Thumb_UITests_Windows_UI_Xaml_Controls_ThumbTests_Thumb_CapturePreventScroll_UITests_Windows_UI_Xaml_Controls_ThumbTests_Thumb_CapturePreventScroll
    • Thumb_UITests_Windows_UI_Xaml_Controls_ThumbTests_Thumb_DragEvents_UITests_Windows_UI_Xaml_Controls_ThumbTests_Thumb_DragEvents
    • RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
    • TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout
    • Transform_Basics_UITests_Shared_Windows_UI_Xaml_Media_Transform_Basics
    • TextBlock_SimpleText_MaxLines_One_Uno_UI_Samples_Content_UITests_TextBlockControl_SimpleText_MaxLines_One
    • ListView_HorizontalListView_Templates_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Templates
    • TextBox_TextBox_HorizontalAlignment_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_HorizontalAlignment
    • TextBox_TextBox_Keyboard_Dismiss_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_Keyboard_Dismiss
    • MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension

  • ios: 5 changed over 269

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage

  • ios-Snap: 45 changed over 1055

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ListView_ListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGrouped
    • ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
    • Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFill_GenericApp_Views_Content_UITests_ImageBrushTestControl_ImageBrush_UniformToFill
    • Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
    • Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
    • Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
    • Brushes_RectangleStretchFill_Uno_UI_Samples_UITests_ImageBrushTestControl_RectangleStretchFill
    • Grid_Grid_DataBound_ColumnRow_Definitions_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_DataBound_ColumnRow_Definitions
    • Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal
    • NavigationView_FluentStyle_NavigationViewSample_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl
    • ListView_ListViewHeaderFooterOnly_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderFooterOnly
    • ListView_ListViewHeaderFooter_ImplicitlyBinded_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderFooter_ImplicitlyBinded
    • TextBlock_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanel
    • UIElement_TransformToVisual_Simple_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_Simple
    • Brushes_ImageBrushLocalAsset_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushLocalAsset
    • NavigationView_MUXControlsTestApp_NavigationViewMinimalPage_MUXControlsTestApp_NavigationViewMinimalPage
    • NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page

  • skia-gtk-screenshots: 24 changed over 2208

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ImageIconPage.png-dark
    • ImageIconPage.png
    • ImageBrushInList.png-dark
    • ImageBrushInList.png
    • ImageBrushStretch2.png
    • PasswordBox_AutoFill.png-dark
    • PasswordBox_AutoFill.png
    • ImageBrushAlignmentXY.png
    • Using .ogg.png-dark
    • Using .ogg.png
    • SvgImageSource_FromStream.png-dark
    • SvgImageSource_FromStream.png
    • BorderImageBrushRelativeTransform.png-dark
    • BorderImageBrushRelativeTransform.png
    • Image_Stretch_None_ScrollViewer.png-dark
    • Image_Stretch_None_ScrollViewer.png
    • Rectangle.png-dark
    • Rectangle.png
    • TransformToVisual_Translate2d.png-dark
    • TransformToVisual_Translate2d.png

  • skia-linux-screenshots: 26 changed over 2208

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • DragDrop_TestPage.png-dark
    • DragDrop_TestPage.png
    • Image_Stretch_None_ScrollViewer.png-dark
    • Image_Stretch_None_ScrollViewer.png
    • Ellipse.png-dark
    • Ellipse.png
    • CompositionEffectBrush.png-dark
    • CompositionEffectBrush.png
    • Image_Formats.png-dark
    • Image_Formats.png
    • Mini player.png-dark
    • Mini player.png
    • ImageBrush_UniformToFill.png-dark
    • ImageBrush_UniformToFill.png
    • ImageIconPage.png-dark
    • ImageIconPage.png
    • RectangleStretchFill.png-dark
    • RectangleStretchFill.png
    • PanelImageBrush.png-dark
    • PanelImageBrush.png

  • skia-windows-screenshots: 22 changed over 2208

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • BorderImageBrush.png-dark
    • BorderImageBrush.png
    • BorderImageBrushRelativeTransform.png
    • ImageBrush_UniformToFill.png-dark
    • ImageBrush_UniformToFill.png
    • ImageSourceUrlMsAppDataScheme.png-dark
    • ImageSourceUrlMsAppDataScheme.png
    • BorderImageBrushRelativeTransform.png-dark
    • ImageBrushInList.png-dark
    • ImageBrushInList.png
    • DoubleImageBrushInList.png-dark
    • DoubleImageBrushInList.png
    • ImagesInlineInFlipView.png-dark
    • ImagesInlineInFlipView.png
    • Mini player.png-dark
    • Mini player.png
    • Native.png-dark
    • Native.png
    • NavigationViewRS3Page.png-dark
    • NavigationViewRS3Page.png

  • wasm: 350 changed over 1042

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.NavigationViewAnimationPage
    • SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.Rectangle_With_RotateTransform
    • SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.TextBox_With_RotateTransform
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.HorizontalListView_Padding
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.HorizontalListView_Templates
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGroupedVariableHeightComplexTemplate
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewWithinScollViewer
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_BoundSelectedItem
    • SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.Path_Arc
    • SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.Path_Geometry
    • UITests.Microsoft_UI_Xaml_Controls.InfoBadgeTests.InfoBadgePage
    • UITests.Microsoft_UI_Xaml_Controls.NavigationViewTests.NavigationViewBasicPage
    • UITests.Microsoft_UI_Xaml_Controls.NumberBoxTests.NumberBox_Description
    • UITests.Shared.Windows_System.LauncherTests
    • UITests.Shared.Windows_System.Profile.AnalyticsInfoTests
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_DataTemplateSelector
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_Explicit_Items
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_Infinite_Breadth
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_ItemsPanel_HotSwap
    • UITests.Shared.Windows_UI_Xaml_Controls.WebView.WebView_NavigateToString2

  • wasm-automated-net8.0-UWP-Default-automated: 21 changed over 1963

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • Border_NonUniformThicknessandRadius_Uno_UI_Samples_UITests_BorderTestsControl_NonUniformThicknessandRadius
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
    • Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • TextBlock_TextBlockSimpleContrainedHorizontalCenterWrap2_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockSimpleContrainedHorizontalCenterWrap2
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Windows_Media_MediaPlayer_UITests_Windows_Media_MediaPlayerTests
    • When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • TextBlock_TextBlock_UpdatePerformance_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_UpdatePerformance
    • When_MenuFlyout_Nested_Clamped_To_Window_Outer_flyout_-_opening_2
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Pickers_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated_Reload_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated_Reload
    • When_Theme_Changed_No_Crash_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers

  • wasm-automated-net8.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net8.0-UWP-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net8.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net8.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net8.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net8.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net8.0-WinUI-RuntimeTests-2: 0 changed over 1

@jeromelaban
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-17239/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-17239/index.html

@nventive-devops
Copy link
Contributor

The build 130910 found UI Test snapshots differences: android-28-net8: 19, android-28-net8-Snap: 47, ios: 6, ios-Snap: 42, skia-gtk-screenshots: 31, skia-linux-screenshots: 18, skia-windows-screenshots: 40, wasm: 354, wasm-automated-net8.0-UWP-Default-automated: 22, wasm-automated-net8.0-UWP-RuntimeTests-0: 0, wasm-automated-net8.0-UWP-RuntimeTests-1: 1, wasm-automated-net8.0-UWP-RuntimeTests-2: 0, wasm-automated-net8.0-WinUI-Benchmarks-automated: 0, wasm-automated-net8.0-WinUI-RuntimeTests-0: 0, wasm-automated-net8.0-WinUI-RuntimeTests-1: 0, wasm-automated-net8.0-WinUI-RuntimeTests-2: 0

Details

  • android-28-net8: 19 changed over 829

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • CommandBar_LongTitle_Validation_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitle
    • When_InScrollViewer_after_scroll
    • SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • Loaded_Unloaded_Validation_UITests_Shared_Windows_UI_Xaml_FrameworkElementTests_LoadEvents
    • ListView_SelectedItem_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_SelectedItem
    • DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • When_InListView_after_scroll
    • UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
    • When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
    • Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
    • When_TransformToVisual_Transform_UITests_Shared_Windows_UI_Xaml_UIElementTests_TransformToVisual_Transform
    • Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220

  • android-28-net8-Snap: 47 changed over 1064

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • Border_BorderTopwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderTopwithmargins
    • Brushes_ImageBrushChangingCornerRadius_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushChangingCornerRadius
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Border_BorderRightwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderRightwithmargins
    • Buttons_Buttons_Native_UITests_Shared_Windows_UI_Xaml_Controls_Buttons_Native
    • Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
    • Icons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground
    • Scrolling_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage
    • Border_NonUniformThicknessandRadius_Uno_UI_Samples_UITests_BorderTestsControl_NonUniformThicknessandRadius
    • Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage
    • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • NavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPage
    • TextBox_TextBoxPadding_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBoxPadding
    • Border_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_Clipped_Change_Property
    • Buttons_CheckBox_Button_UWA_Style_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_Button_UWA_Style
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected

  • ios: 6 changed over 269

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • Check_ListView_Swallows_Measure_after_scroll
    • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers

  • ios-Snap: 42 changed over 1055

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse
    • Brushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfill
    • Brushes_ImageBrushLocalAsset_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushLocalAsset
    • Brushes_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGrid
    • Image_Image_Stretch_None_ScrollViewer_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None_Containers
    • Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes
    • Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
    • TextBlock_TextBlock_FixedWidth_With_DataBound_Run_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_FixedWidth_With_DataBound_Run
    • Brushes_ImageBrushWithScaleTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithScaleTransform
    • ListView_ListViewGrouped_ItemContainerStyleSelector_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGrouped_ItemContainerStyleSelector
    • ListView_ListView_Header_DataContextChanging_UITests_Shared_Windows_UI_Xaml_Controls_ListView_Header_DataContextChanging
    • ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
    • WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties
    • WebView_UITests_Microsoft_UI_Xaml_Controls_WebViewTests_WebView_InvokeScriptAsync_UITests_Microsoft_UI_Xaml_Controls_WebViewTests_WebView_InvokeScriptAsync
    • Brushes_ImageBrushAlignmentXY_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushAlignmentXY
    • Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider

  • skia-gtk-screenshots: 31 changed over 2208

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • UIElement_ContextFlyout.png-dark
    • UIElement_ContextFlyout.png
    • PathImageBrushfill.png
    • Uniform100x100.png-dark
    • Uniform100x100.png
    • UniformAlignmentCenterInDoubleStackPanelWebUri.png-dark
    • UniformAlignmentCenterInDoubleStackPanelWebUri.png
    • BorderImageBrushRelativeTransform.png-dark
    • StretchNoneBoundingBoxInDoubleStackPanel.png-dark
    • StretchNoneBoundingBoxInDoubleStackPanel.png
    • BorderImageBrushRelativeTransform.png
    • ImageBrush_SameWithDelay.png-dark
    • ImageBrush_SameWithDelay.png
    • Mini player.png-dark
    • Mini player.png
    • Path_Geometries.png-dark
    • Path_Geometries.png
    • RectangleStretchFill.png
    • ImageBrushAlignmentXY2.png
    • ImageOpened.png

  • skia-linux-screenshots: 18 changed over 2208

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • BorderImageBrush.png-dark
    • BorderImageBrush.png
    • ImageBrush_UniformToFill.png-dark
    • ImageBrush_UniformToFill.png
    • Image_UseTargetSize.png-dark
    • Image_UseTargetSize.png
    • ImageBrushInList.png-dark
    • ImageBrushInList.png
    • PathImageBrushfill.png-dark
    • PathImageBrushfill.png
    • Image_Formats.png-dark
    • Image_Formats.png
    • Mini player.png-dark
    • Mini player.png
    • TransformToVisual_Translate2d.png-dark
    • TransformToVisual_Translate2d.png
    • Using .ogg.png-dark
    • Using .ogg.png

  • skia-windows-screenshots: 40 changed over 2208

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • BorderImageBrushRelativeTransform.png-dark
    • DoubleImageBrushInList.png-dark
    • DoubleImageBrushInList.png
    • ImageBrushInList.png-dark
    • ImageBrushInList.png
    • ImageWithLateSourceUniformToFill.png-dark
    • ImageWithLateSourceUniformToFill.png
    • Image_UseTargetSize.png-dark
    • Image_UseTargetSize.png
    • ImageBrush_UniformToFill.png-dark
    • ImageBrush_UniformToFill.png
    • ImageIconPage.png-dark
    • ImageIconPage.png
    • ImageInStackPanel.png-dark
    • ImageInStackPanel.png
    • ImageSourceUrlMsAppDataScheme.png-dark
    • ImageSourceUrlMsAppDataScheme.png
    • Image_Stretch_None_ScrollViewer.png-dark
    • Image_Stretch_None_ScrollViewer.png
    • Ellipse.png-dark

  • wasm: 354 changed over 1042

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • GenericApp.Views.Samples.Shared.Content.UITests.GridViewGrouped
    • MUXControlsTestApp.HierarchicalNavigationViewMarkup
    • MUXControlsTestApp.NavigationViewBlankPage1
    • MUXControlsTestApp.SwipeControlPage
    • SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.Grid_With_RotateTransform_And_Button
    • SamplesApp.Windows_UI_Xaml.Clipping.XamlButtonWithClipping
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGrouped_ItemContainerStyleSelector
    • SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.Test3
    • SamplesApp.Windows_UI_Xaml_Shapes.PolygonPage
    • UITests.Shared.Microsoft_UI_Xaml_Controls.TwoPaneViewTests.TwoPaneViewPage
    • UITests.Shared.Resources.StaticResource.StaticResource_Simple
    • UITests.Shared.Windows_UI_Input.VisualStatesTests.ComboBoxItem
    • UITests.Shared.Windows_UI_Input.VisualStatesTests.ListViewItem
    • UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ItemDataContext
    • UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_MaxDropdownHeight
    • UITests.Shared.Windows_UI_Xaml_Controls.TextBlockControl.TextBlock_Visibility_Arrange
    • UITests.Windows_Devices.Midi.MidiDeviceInput
    • UITests.Windows_Devices.Power.Battery
    • UITests.Windows_Gaming.GamepadEnumerationTest
    • UITests.Windows_UI_Xaml.UIElementTests.UIElement_MeasureDirtyPath

  • wasm-automated-net8.0-UWP-Default-automated: 22 changed over 1963

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Geometries_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Geometries
    • Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry
    • Default_StrokeThickness_MyLine_0_StrokeThickness
    • Border_OnepxThicknessandRadiusAndTextBlock_Uno_UI_Samples_UITests_BorderTestsControl_OnepxThicknessandRadiusAndTextBlock
    • Default_StrokeThickness_MyPolygon
    • Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
    • Path_StrokeThickness10FixedWidth_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_StrokeThickness10FixedWidth
    • Performance_Dopes_UITests_Windows_UI_Xaml_Performance_Performance_Dopes
    • Pickers_TimePicker_Flyout_Automated_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_MenuFlyout_Nested_Clamped_To_Window_Outer_flyout_-_opening_2
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers

  • wasm-automated-net8.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net8.0-UWP-RuntimeTests-1: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage

  • wasm-automated-net8.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net8.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net8.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net8.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net8.0-WinUI-RuntimeTests-2: 0 changed over 1

@jeromelaban jeromelaban merged commit 7dca68c into master Jun 28, 2024
107 checks passed
@jeromelaban jeromelaban deleted the dev/nr/fixandroidhr branch June 28, 2024 18:21
@mergify mergify bot mentioned this pull request Jun 28, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

@ajpinedam ajpinedam ajpinedam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] Hot Reload losing the DataContext when using Navigation
5 participants
@nickrandolph @unodevops @jeromelaban @nventive-devops @ajpinedam