(Go: >> BACK << -|- >> HOME <<)

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild w/NumPy 2 (restrict to 1) #16300

Draft
wants to merge 1 commit into
base: branch-24.08
Choose a base branch
from

Conversation

jakirkham
Copy link
Member
@jakirkham jakirkham commented Jul 17, 2024

Description

Part of issue: rapidsai/build-planning#38

Start building cudf with numpy version 2.0. This remains compatible with numpy version 1.x and 2.x. Allows us to test building with numpy version 2.0 (and make sure we catch any issues that show up). Though continue to pin to numpy version 1.x for now. This formulation should make it easier to update with RDFG later when rolling out NumPy 2 support across RAPIDS (as the same constraint is here as in all other RAPIDS projects making it easier to replace).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jakirkham jakirkham requested a review from a team as a code owner July 17, 2024 22:41
@jakirkham jakirkham requested a review from msarahan July 17, 2024 22:41
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 17, 2024
@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 17, 2024
@jakirkham jakirkham changed the title Drop {{ pin_compatible('numpy') }} & build with NumPy 2 (constrain to NumPy 1 though) Drop {{ pin_compatible('numpy') }} & build w/NumPy 2 (restrict to 1) Jul 17, 2024
@jakirkham
Copy link
Member Author

Need NumPy 2 compatible RMM wheels to proceed. Marking as draft

@jakirkham jakirkham marked this pull request as draft July 17, 2024 23:21
This changes the builds to start using NumPy 2 when building cuDF and
friends. However this maintains the same runtime dependency to restrict
cuDF and friends to NumPy 1.23+ (pre-2). As building libraries against
NumPy 2 provides NumPy 2 compatibility and maintains NumPy 1
compatibility (back to NumPy 1.19), this provides equivalent NumPy
compatibility to what we had before and extends it further. This also
helps us ensure that our builds are (and remain) compatible with NumPy
2. Finally this will help us prep recipes for the NumPy 2 migration with
RDFG still to come.
@jakirkham jakirkham changed the title Drop {{ pin_compatible('numpy') }} & build w/NumPy 2 (restrict to 1) Rebuild w/NumPy 2 (restrict to 1) Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant