feat(qrcode): add google qrcode api support #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cubesky
requested changes
Jun 10, 2017
| @@ -9,6 +9,6 @@ | |||
| margin: 2 | |||
| }) %>"> | |||
| <% } else if(theme.qrcode.use === "online") { %> | |||
| <img src="https://pan.baidu.com/share/qrcode?w=246&h=246&url=<%= page.permalink %>"> | |||
| <img src="<% if(config.language === "zh-CN") { %>https://pan.baidu.com/share/qrcode?w=246&h=246&url=<%= page.permalink %><% } else { %>https://chart.googleapis.com/chart?cht=qr&chs=246x246&chl=<%= page.permalink %>&chld=M|2<% } %>"> | |||
There was a problem hiding this comment.
This may cause error when config.language not config. Use
if(config.language !== null)
to avoid this error and increase compatibility.
There was a problem hiding this comment.
In fact. when the language is not being configured, it will use google chart api.
cubesky
approved these changes
Jun 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing rules
canary. Then be sure to put thecanarybranch as the target for your pull request.Contributing rulespart from this descriptionWhat kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Description
Add another Qrcode API :
chart.googleapis.comUse the language configuration to decide which api to be use.
Verification steps
No verification steps.