(Go: >> BACK << -|- >> HOME <<)
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(layout): add the "lang" to < html > #189

Merged
merged 1 commit into from
Feb 2, 2017
Merged

feat(layout): add the "lang" to < html > #189

merged 1 commit into from
Feb 2, 2017

Conversation

EYHN
Copy link
Contributor
@EYHN EYHN commented Feb 1, 2017

Contributing rules

  • Fork the repo and create your branch from canary. Then be sure to put the canary branch as the target for your pull request.
  • Please be sure to follow the contributing guidelines, especially for commit message
  • Remove the Contributing rules part from this description
  • Fill out the other parts from this description

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

add the "lang" to < html >

<html lang="<%- config.language.substring(0,2) %>">

Closes issue #188;

Verification steps

No verification steps.

@cubesky
Copy link
Collaborator
cubesky commented Feb 1, 2017

Thanks for your pr.

@cubesky cubesky merged commit 89c0157 into iblh:canary Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cubesky cubesky cubesky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EYHN @cubesky