(Go: >> BACK << -|- >> HOME <<)

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand data transformations to include custom criteria #93

Closed
jrista opened this issue Feb 18, 2020 · 0 comments · Fixed by #102
Closed

Expand data transformations to include custom criteria #93

jrista opened this issue Feb 18, 2020 · 0 comments · Fixed by #102
Assignees
Labels
enhancement New feature or request proposal Proposal for New Feature/Functionality

Comments

@jrista
Copy link
Contributor
jrista commented Feb 18, 2020

Currently, custom transformations, introduced in v0.4.2, only pass in the entity being transformed. However there are use cases where custom criteria could be extremely useful in performing transformations. Inclusion of custom criteria in the transformation calls should be a simple change, and would greatly expand their capabilities.

export interface IEntityTransformer {
  fromServer: (data: any, criteria?: any): any;
  toServer: (entity: any, criteria?: any): any;
}
@jrista jrista added enhancement New feature or request proposal Proposal for New Feature/Functionality labels Feb 18, 2020
@jrista jrista added this to To do in NgRx Auto-Entity via automation Feb 24, 2020
@jrista jrista modified the milestone: v0.3.0 Feb 24, 2020
@jrista jrista self-assigned this Feb 24, 2020
@jrista jrista modified the milestones: v0.5.0-alpha.1, v0.5.0-alpha.2 Feb 24, 2020
@jrista jrista moved this from To do to In progress in NgRx Auto-Entity Feb 24, 2020
@jrista jrista moved this from In progress to To do in NgRx Auto-Entity Feb 24, 2020
@jrista jrista moved this from To do to In progress in NgRx Auto-Entity Feb 25, 2020
jrista pushed a commit that referenced this issue Feb 25, 2020
 * Add criteria as optional parameter to data transformers
 * Update entity service to pass criteria to data transformers

Resolves #93
@jrista jrista linked a pull request Feb 25, 2020 that will close this issue
@jrista jrista moved this from In progress to Review in progress in NgRx Auto-Entity Feb 25, 2020
jrista pushed a commit that referenced this issue Feb 25, 2020
 * Add criteria as optional parameter to data transformers
 * Update entity service to pass criteria to data transformers

Resolves #93
@jrista jrista closed this as completed Feb 25, 2020
NgRx Auto-Entity automation moved this from Review in progress to Done Feb 25, 2020
@jrista jrista moved this from Done to Released in NgRx Auto-Entity Sep 13, 2020
@jrista jrista moved this from Pre-Released to Officially Released in NgRx Auto-Entity Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal Proposal for New Feature/Functionality
Projects
NgRx Auto-Entity
  
Officially Released
Development

Successfully merging a pull request may close this issue.

1 participant