(Go: >> BACK << -|- >> HOME <<)

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form should not trigger unnecessary onFieldsChange #43290

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

zombieJ
Copy link
Member
@zombieJ zombieJ commented Jun 30, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #43276

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form submit trigger wrong onFieldsChange event even all the fields do not config rules.
🇨🇳 Chinese 修复 Form 在提交时,字段没有配置 rules 时仍会错误触发 onFieldsChange 事件的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 69f945c

Updated rc-field-form dependency to fix form validation and performance issues. This affects the Form component of the ant-design library.

🔍 Walkthrough

🤖 Generated by Copilot at 69f945c

  • Updated the rc-field-form dependency to fix form validation and performance issues (link)

@github-actions
Copy link
Contributor
github-actions bot commented Jun 30, 2023

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
rc-field-form 1.33.0 None +0 257 kB afc163

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 377.1 KB (+40 B 🔺)
./dist/antd-with-locales.min.js 436.56 KB (+43 B 🔺)

@codecov
Copy link
codecov bot commented Jun 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (78714e0) 100.00% compared to head (69f945c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43290   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          648       648           
  Lines        10968     10968           
  Branches      2979      2979           
=========================================
  Hits         10968     10968           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit a39abf7 into master Jun 30, 2023
95 checks passed
@zombieJ zombieJ deleted the form-field branch June 30, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form 点击提交时触发未预期的 onFieldsChange 事件
2 participants