fix: transfer error when reset data in some cases #42785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #42785 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 648 646 -2
Lines 10957 10935 -22
Branches 2976 2970 -6
=========================================
- Hits 10957 10935 -22
☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Jun 2, 2023
zombieJ
reviewed
Jun 2, 2023
zombieJ
reviewed
Jun 2, 2023
|
感觉这个实现不太好，太多的 |
afc163
reviewed
Jun 2, 2023
li-jia-nan
reviewed
Jun 2, 2023
li-jia-nan
reviewed
Jun 3, 2023
li-jia-nan
reviewed
Jun 3, 2023
afc163
reviewed
Jun 5, 2023
zombieJ
reviewed
Jun 6, 2023
zombieJ
reviewed
Jun 6, 2023
li-jia-nan
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at fe08ed8
Fixed a bug in the
transfercomponent that caused an error when the data source and the target keys were reset. Added a test case to verify the fix and improved the logic of theuseEffecthook incomponents/transfer/index.tsx.🔍 Walkthrough
🤖 Generated by Copilot at fe08ed8
DefaultRecordTypeandButtonin test filecomponents/transfer/__tests__/index.test.tsx(link)useEffecthook incomponents/transfer/index.tsxto handle noprops.selectedKeyscase (link)components/transfer/__tests__/index.test.tsxto check no error when data source and target keys are reset by a button in the footer (link)