(Go: >> BACK << -|- >> HOME <<)

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tour): find dom node throw wranning in strict mode feature #40160

Conversation

kiner-tang
Copy link
Member
@kiner-tang kiner-tang commented Jan 11, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

fix #39921

📝 Changelog

Language Changelog
🇺🇸 English Fixed the findDomNode method warning thrown by the tour component when called in strict mode
🇨🇳 Chinese 修复tour组件在严格模式下调用findDomNode抛出警告问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor
github-actions bot commented Jan 11, 2023

@codecov
Copy link
codecov bot commented Jan 11, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (8f8c778) compared to base (642bb58).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #40160   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          603       603           
  Lines        10221     10221           
  Branches      2753      2753           
=========================================
  Hits         10221     10221           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yoyo837 yoyo837 merged commit 42b1d54 into ant-design:feature Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants