(Go: >> BACK << -|- >> HOME <<)
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Image): add onActive to toolbarRender #49356

Open
wants to merge 4 commits into
base: feature
Choose a base branch
from
Open

feat(Image): add onActive to toolbarRender #49356

wants to merge 4 commits into from

Conversation

madocto
Copy link
Contributor
@madocto madocto commented Jun 11, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close: #47948

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Image add onActive to toolbarRender for toggling images .
🇨🇳 Chinese Image 新增 onActive 到 toolbarRender 以切换图片 。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@stackblitz StackBlitz
Copy link
stackblitz bot commented Jun 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 11, 2024 •
edited
Loading

👁 Visual Regression Report for PR #49356 Failed ❌

🎯 Target branch: feature (9c91bdb)
📖 View Full Report ↗︎

Expected (Branch feature) Actual (Current PR) Diff
image-toolbarRender.compact.png image-toolbarRender.compact.png image-toolbarRender.compact.png image-toolbarRender.compact.png
image-toolbarRender.compact.png image-toolbarRender.compact.png image-toolbarRender.compact.css-var.png image-toolbarRender.compact.css-var.png
image-toolbarRender.dark.png image-toolbarRender.dark.png image-toolbarRender.dark.png image-toolbarRender.dark.png
image-toolbarRender.dark.png image-toolbarRender.dark.png image-toolbarRender.dark.css-var.png image-toolbarRender.dark.css-var.png
image-toolbarRender.default.png image-toolbarRender.default.png image-toolbarRender.default.png image-toolbarRender.default.png
image-toolbarRender.default.png image-toolbarRender.default.png image-toolbarRender.default.css-var.png image-toolbarRender.default.css-var.png

Check Full Report for details

If you think the visual diff is acceptable, please check:

  • Visual diff is acceptable

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jun 11, 2024 •
edited
Loading

Preview is ready

@socket-security Socket Security
Copy link
socket-security bot commented Jun 11, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/rc-image@7.10.0 environment 0 159 kB zombiej

🚮 Removed packages: npm/rc-image@7.9.0

View full report↗︎

@codecov Codecov
Copy link
codecov bot commented Jun 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.99%. Comparing base (9c91bdb) to head (c441059).

Additional details and impacted files 
@@           Coverage Diff            @@
##           feature   #49356   +/-   ##
========================================
  Coverage    99.99%   99.99%           
========================================
  Files          750      750           
  Lines        13132    13132           
  Branches      3443     3443           
========================================
  Hits         13131    13131           
  Misses           1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@madocto