(Go: >> BACK << -|- >> HOME <<)

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove useless disabled style in Upload #45446

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

vagusX
Copy link
Member
@vagusX vagusX commented Oct 20, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English Remove duplicate disabled styles in Upload.Dragger
🇨🇳 Chinese 移除 Upload.Dragger 中重复的 disabled 样式

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 6adcdb4

Removed cursor: 'not-allowed' style from upload component's drag and drop area. This fixed a bug where the cursor would show as not-allowed even when the component was enabled.

🔍 Walkthrough

🤖 Generated by Copilot at 6adcdb4

  • Removed cursor: 'not-allowed' style from drag and drop area of upload component to fix bug where cursor would show as not-allowed even when component was enabled (link)

@stackblitz
Copy link
stackblitz bot commented Oct 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor
github-actions bot commented Oct 20, 2023

@vagusX vagusX requested a review from zombieJ October 20, 2023 05:51
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 397.94 KB (-4 B 🔽)
./dist/antd-with-locales.min.js 457.25 KB (-2 B 🔽)

@argos-ci
Copy link
argos-ci bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Oct 20, 2023, 6:04 AM

@codecov
Copy link
codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (029641a) 100.00% compared to head (6adcdb4) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #45446    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          695       694     -1     
  Lines        12011     11676   -335     
  Branches      3242      3118   -124     
==========================================
- Hits         12011     11676   -335     
Files Coverage Δ
components/upload/style/dragger.ts 100.00% <ø> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 changed the title fix: remove useless disabled style in Upload chore: remove useless disabled style in Upload Oct 20, 2023
@afc163 afc163 merged commit 1c16788 into master Oct 20, 2023
110 checks passed
@afc163 afc163 deleted the fix/remove-useless-disabled-styles-in-upload branch October 20, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants