fix: Button loading={delay: 0} 不显示加载 #45282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45282 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 692 692
Lines 11670 11669 -1
Branches 3117 3116 -1
=========================================
- Hits 11670 11669 -1
☔ View full report in Codecov by Sentry. |
|
来个测试用例 |
kiner-tang
reviewed
Oct 12, 2023
意思是需要验证一下测试用例用来验证本次更改，可以在组件的 tests 目录添加： |
好的，谢谢大佬 |
afc163
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#45273
💡 Background and solution
在
getLoadingConfig中判断delay = 0时，直接设置loading = true📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at c975345
Fixed a button loading icon bug and simplified the delay logic in
components/button/button.tsx.🔍 Walkthrough
🤖 Generated by Copilot at c975345