-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove buffer from src/hdr buffer list if the buffer is killed #193
Open
0x17de
wants to merge
1
commit into
atilaneves:master
Choose a base branch
from
0x17de:update-buffer-list-on-kill-buffer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 297
💛 - Coveralls |
3 similar comments
Pull Request Test Coverage Report for Build 297
💛 - Coveralls |
Pull Request Test Coverage Report for Build 297
💛 - Coveralls |
Pull Request Test Coverage Report for Build 297
💛 - Coveralls |
Looks good, but could you add a test please? I don't want a regression for this to be introduced. |
@atilaneves If you give me some more time I can write some test for that (maybe around late august). It could be that i need ert-async since i need to wait until cmake is successfully run |
@0x17de Sure, it's your fix, so whenever you can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the buffer was killed it should be removed from the list of source and header buffers; Otherwise a new call to
cmake-ide-run-cmake
will cause minor issues since the file is closed while trying to apply new flags.