(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T358207

Unit tests: Add tests to all the ignored base components that are planned to stay
Open, LowPublic
Actions

Description

Description

Our components from the "base" folder were sometimes temporary, so we have jest.config.js configured to ignore them for our coverage calculation.
However, many of these components are gonna stay, so we should remove their paths from the ignore, and add unit tests.

Legend:

  • 🆗 Leave untouched
  • ❌ Remove from ignore: no tests needed
  • ✅ Remove from ignore and write test!!

The components currently appearing in the ignore list:

  • 🆗 Chip.vue: ignore, will be removed in the future
  • 🆗 ChipContainer.vue: ignore, will be removed in the future
  • ✅ CodeEditor.vue: remove from ignore and add tests
  • ❌ Dialog.vue: remove from ignore, component doesn't exist
  • ❌ DialogContainer.vue: remove from ignore, component doesn't exist
  • ✅ ExpandedToggle.vue: remove from ignore and add tests (patch)
  • ❌ LeaveEditorDialog.vue: remove from ignore, component doesn't exist
  • ✅ LocalizedLabel.vue: remove from ignore and add tests (patch)
  • ✅ Pagination.vue: remove from ignore and add tests
  • ❌ PublishDialog.vue: remove from ignore, component isn't there anymore
  • ❌ Select.vue:
  • 🆗 Table.vue: ignore, will be removed in the future
  • ❌ Text.vue: remove from ignore and remove component!!
  • 🆗 Tooltip.vue: ignore, will likely be removed in the future

Completion checklist

Details

SubjectRepoBranchLines +/-
Add test coverage for the CodeEditor componentmediawiki/extensions/WikiLambdamaster+64 -0
Fixit: Remove Text.vue component (not used)mediawiki/extensions/WikiLambdamaster+0 -136
Add test for Pagination componentmediawiki/extensions/WikiLambdamaster+134 -1
Add test for ExpandedToggle componentmediawiki/extensions/WikiLambdamaster+93 -1
Add test for LocalizedLabel componentmediawiki/extensions/WikiLambdamaster+77 -1
Add test for ExpandedToggle componentmediawiki/extensions/WikiLambdamaster+46 -0
Remove mentions of deprecated componentsmediawiki/extensions/WikiLambdamaster+0 -6
Customize query in gerrit

Event Timeline

gengh created this task.Feb 22 2024, 11:39 AM
gengh added a project: Abstract Wikipedia Fix-It tasks.
Jdforrester-WMF triaged this task as Low priority.Feb 22 2024, 5:47 PM
Jdforrester-WMF moved this task from To triage to Backlog on the Abstract Wikipedia team board.
gerritbot added a comment.Mar 27 2024, 4:55 AM

Change #1014702 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Remove mentions of deprecated components

https://gerrit.wikimedia.org/r/1014702

gerritbot added a project: Patch-For-Review.Mar 27 2024, 4:55 AM
ecarg moved this task from Backlog to In Progress on the Abstract Wikipedia team board.Mar 27 2024, 4:57 AM
ecarg subscribed.

The checklist/task will be tackled in separate patches

Jdforrester-WMF updated the task description. (Show Details)Mar 27 2024, 1:43 PM
gerritbot added a comment.Mar 27 2024, 2:53 PM

Change #1014702 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Remove mentions of deprecated components

https://gerrit.wikimedia.org/r/1014702

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Mar 27 2024, 3:00 PM
Jdforrester-WMF updated the task description. (Show Details)Mar 27 2024, 3:16 PM
Jdforrester-WMF assigned this task to ecarg.Apr 1 2024, 6:06 PM
gerritbot added a comment.Apr 4 2024, 4:15 AM

Change #1016913 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Add test for LocalizedLabel component

https://gerrit.wikimedia.org/r/1016913

gerritbot added a comment.Apr 5 2024, 5:32 PM

Change #1017335 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

https://gerrit.wikimedia.org/r/1017335

gerritbot added a comment.Apr 5 2024, 5:32 PM

Change #1017336 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

https://gerrit.wikimedia.org/r/1017336

gerritbot added a comment.Apr 5 2024, 5:33 PM

Change #1017336 abandoned by Ecarg:

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

Reason:

dupe

https://gerrit.wikimedia.org/r/1017336

gerritbot added a comment.Apr 5 2024, 5:34 PM

Change #1017336 restored by Ecarg:

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

https://gerrit.wikimedia.org/r/1017336

gerritbot added a comment.Apr 5 2024, 5:34 PM

Change #1017335 abandoned by Ecarg:

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

Reason:

dupe

https://gerrit.wikimedia.org/r/1017335

gerritbot added a comment.Apr 5 2024, 5:47 PM

Change #1017335 restored by Ecarg:

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

https://gerrit.wikimedia.org/r/1017335

gerritbot added a comment.Apr 5 2024, 6:33 PM

Change #1017336 abandoned by Ecarg:

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

Reason:

dupe

https://gerrit.wikimedia.org/r/1017336

gerritbot added a comment.Apr 10 2024, 12:23 PM

Change #1016913 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add test for LocalizedLabel component

https://gerrit.wikimedia.org/r/1016913

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Apr 10 2024, 1:00 PM
Jdforrester-WMF updated the task description. (Show Details)Apr 10 2024, 2:14 PM
Jdforrester-WMF updated the task description. (Show Details)Apr 10 2024, 2:43 PM
Jdforrester-WMF updated the task description. (Show Details)Apr 11 2024, 4:14 PM
gerritbot added a comment.Apr 11 2024, 8:10 PM

Change #1019117 had a related patch set uploaded (by Ecarg; author: Ecarg):

[mediawiki/extensions/WikiLambda@master] Add test for Pagination component

https://gerrit.wikimedia.org/r/1019117

gerritbot added a comment.Apr 12 2024, 6:37 PM

Change #1017335 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add test for ExpandedToggle component

https://gerrit.wikimedia.org/r/1017335

gerritbot added a comment.Apr 12 2024, 7:08 PM

Change #1019117 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add test for Pagination component

https://gerrit.wikimedia.org/r/1019117

ecarg updated the task description. (Show Details)Apr 12 2024, 8:03 PM
gerritbot added a comment.Apr 15 2024, 9:55 AM

Change #1019693 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fixit: Remove Text.vue component (not used)

https://gerrit.wikimedia.org/r/1019693

gerritbot added a comment.Apr 16 2024, 2:15 PM

Change #1019693 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fixit: Remove Text.vue component (not used)

https://gerrit.wikimedia.org/r/1019693

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.2; 2024-04-23); removed MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Apr 16 2024, 3:00 PM
Jdforrester-WMF moved this task from In Progress to 24Q4 (Apr–Jun) on the Abstract Wikipedia team board.Mon, Apr 29, 5:56 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (24Q4 (Apr–Jun)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to In Progress on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.
gerritbot added a comment.Tue, May 7, 3:44 PM

Change #1028862 had a related patch set uploaded (by Ecarg; author: jenkins-bot):

[mediawiki/extensions/WikiLambda@master] Add test coverage for the CodeEditor component

https://gerrit.wikimedia.org/r/1028862

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL