(Go: >> BACK << -|- >> HOME <<)

Page MenuHomePhabricator

Curation toolbar: Remove 'common' flyout from the tags section
Closed, DeclinedPublic

Description

After the introduction of the 'filter tag' feature, the 'common' tags have fallen out of regular use. Removing the code for this would simplify the codebase.
Files that would need to be changed:

  • modules/ext.pageTriage.views.toolbar/tags.js
  • modules/ext.pageTriage.defaultTagsOptions/ext.pageTriage.defaultTagsOptions.js
  • en.json and qqq.json in i18n/

Event Timeline

Change 973403 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Remove the 'common' category from tags

https://gerrit.wikimedia.org/r/973403

Test wiki created on Patch demo by MPGuy2824 using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/3a96f4de49/w

jsn.sherman changed the task status from Open to In Progress.Nov 27 2023, 8:18 PM
jsn.sherman moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.
jsn.sherman updated the task description. (Show Details)
jsn.sherman moved this task from Ready to Done on the Moderator-Tools-Team (Kanban) board.

Change 973403 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Remove the 'common' category from tags

https://gerrit.wikimedia.org/r/973403

Test wiki on Patch demo by MPGuy2824 using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/3a96f4de49/w/

MPGuy2824 moved this task from Waiting for enwiki deploy to Done on the PageTriage board.
Novem_Linguae claimed this task.
Novem_Linguae moved this task from Done to Code Review on the PageTriage board.
Novem_Linguae added a subscriber: Soda.

Change 983190 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] Toolbar: add "Common" category back to "tag" flyout menu

https://gerrit.wikimedia.org/r/983190

Change 983190 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Toolbar: add "Common" category back to "tag" flyout menu

https://gerrit.wikimedia.org/r/983190

The common section was removed from the toolbar and then re-added after some complaints from the community. I'm not sure if this ticket should be marked as declined or resolved.

Novem_Linguae changed the task status from Resolved to Declined.Jan 15 2024, 4:15 AM

Declined I suppose, since the feature didn't make it in ¯\_(ツ)_/¯