(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T325591

Hard-deprecate manual construction of LinkBatch objects (and make @internal in 1.41)
Closed, ResolvedPublic
Actions

Description

Calling new LinkBatch is deprecated since 1.35, use the LinkBatchFactory to instance a link batch.

https://codesearch.wmcloud.org/search/?q=new%5Cs%2B%5C%5C%3FLinkBatch%5Cb&i=nope&files=&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/FacetedCategorymaster+32 -6
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/FacetedCategoryREL1_41+32 -6
Remove fallback to MediaWikiServices in LinkBatch::__constructmediawiki/coremaster+45 -73
Hard-deprecate manual construction of LinkBatch objectsmediawiki/coremaster+12 -1
parser: Use LinkBatchFactory to create LinkBatch objectsmediawiki/coremaster+12 -4
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/Videomaster+2 -2
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/Favoritesmaster+2 -2
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/Flowmaster+2 -1
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/Polyglotmaster+6 -1
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/Wikibasemaster+40 -10
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/UserPageViewTrackermaster+8 -1
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/CirrusSearchmaster+8 -8
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/FileImportermaster+20 -7
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/Newslettermaster+1 -2
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/FlaggedRevsmaster+14 -6
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/Babelmaster+1 -2
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/CategoryTreemaster+1 -2
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/Flowmaster+6 -5
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/LiquidThreadsmaster+1 -1
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/Collectionmaster+33 -10
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/GlobalContribsmaster+1 -1
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/UnusedRedirectsmaster+6 -1
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/WikimediaMaintenancemaster+3 -2
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/UploadWizardmaster+1 -1
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/MassMessagemaster+2 -4
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/CentralAuthmaster+26 -7
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/Translatemaster+21 -11
Use LinkBatchFactory to create LinkBatch objectsmediawiki/extensions/TranslationNotificationsmaster+12 -4
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Dec 19 2022, 8:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2022, 8:14 PM
gerritbot added a comment.Dec 19 2022, 8:15 PM

Change 869286 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] parser: Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869286

gerritbot added a project: Patch-For-Review.Dec 19 2022, 8:15 PM
gerritbot added a comment.Dec 19 2022, 8:32 PM

Change 869291 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Babel@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869291

gerritbot added a comment.Dec 19 2022, 8:34 PM

Change 869292 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CategoryTree@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869292

gerritbot added a comment.Dec 19 2022, 8:36 PM

Change 869293 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Newsletter@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869293

gerritbot added a comment.Dec 19 2022, 8:40 PM

Change 869294 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Favorites@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869294

gerritbot added a comment.Dec 19 2022, 8:41 PM

Change 869295 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GlobalContribs@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869295

gerritbot added a comment.Dec 19 2022, 8:42 PM

Change 869296 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Polyglot@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869296

gerritbot added a comment.Dec 19 2022, 8:44 PM

Change 869297 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/UnusedRedirects@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869297

gerritbot added a comment.Dec 19 2022, 8:46 PM

Change 869298 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/UserPageViewTracker@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869298

gerritbot added a comment.Dec 19 2022, 8:47 PM

Change 869299 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Video@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869299

gerritbot added a comment.Dec 19 2022, 8:53 PM

Change 869301 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikimediaMaintenance@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869301

gerritbot added a comment.Dec 19 2022, 9:02 PM

Change 869302 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869302

gerritbot added a comment.Dec 19 2022, 9:03 PM

Change 869303 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LiquidThreads@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869303

gerritbot added a comment.Dec 19 2022, 9:04 PM

Change 869304 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MassMessage@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869304

gerritbot added a comment.Dec 19 2022, 9:05 PM

Change 869305 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/UploadWizard@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869305

gerritbot added a comment.Dec 19 2022, 9:12 PM

Change 869306 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/TranslationNotifications@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869306

gerritbot added a comment.Dec 19 2022, 9:17 PM

Change 869307 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FileImporter@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869307

gerritbot added a comment.Dec 19 2022, 9:21 PM

Change 869309 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralAuth@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869309

gerritbot added a comment.Dec 19 2022, 9:27 PM

Change 869310 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CirrusSearch@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869310

gerritbot added a comment.Dec 19 2022, 9:29 PM

Change 869311 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Flow@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869311

gerritbot added a comment.Dec 19 2022, 9:33 PM

Change 869312 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Translate@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869312

gerritbot added a comment.Dec 19 2022, 9:37 PM

Change 869313 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Collection@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869313

gerritbot added a comment.Dec 19 2022, 9:43 PM

Change 869317 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869317

gerritbot added a comment.Dec 20 2022, 5:35 AM

Change 869312 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869312

gerritbot added a comment.Dec 20 2022, 5:35 AM

Change 869306 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869306

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 20 2022, 6:01 AM
gerritbot added a comment.Dec 20 2022, 8:12 AM

Change 869309 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869309

gerritbot added a comment.Dec 20 2022, 8:12 AM

Change 869305 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869305

gerritbot added a comment.Dec 20 2022, 8:12 AM

Change 869304 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869304

gerritbot added a comment.Dec 20 2022, 8:12 AM

Change 869313 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869313

gerritbot added a comment.Dec 20 2022, 8:22 AM

Change 869311 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869311

gerritbot added a comment.Dec 20 2022, 8:22 AM

Change 869303 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869303

gerritbot added a comment.Dec 20 2022, 8:23 AM

Change 869291 merged by jenkins-bot:

[mediawiki/extensions/Babel@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869291

gerritbot added a comment.Dec 20 2022, 8:23 AM

Change 869301 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869301

gerritbot added a comment.Dec 20 2022, 8:23 AM

Change 869297 merged by jenkins-bot:

[mediawiki/extensions/UnusedRedirects@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869297

gerritbot added a comment.Dec 20 2022, 8:23 AM

Change 869292 merged by jenkins-bot:

[mediawiki/extensions/CategoryTree@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869292

gerritbot added a comment.Dec 20 2022, 8:23 AM

Change 869295 merged by jenkins-bot:

[mediawiki/extensions/GlobalContribs@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869295

gerritbot added a comment.Dec 20 2022, 8:23 AM

Change 869293 merged by jenkins-bot:

[mediawiki/extensions/Newsletter@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869293

gerritbot added a comment.Dec 20 2022, 8:23 AM

Change 869302 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869302

Umherirrender mentioned this in rEGCN70fc7be8314a: Use LinkBatchFactory to create LinkBatch objects.Dec 20 2022, 8:25 AM
Umherirrender mentioned this in rEURD68bb02c30e38: Use LinkBatchFactory to create LinkBatch objects.
gerritbot added a comment.Dec 20 2022, 8:31 AM

Change 869307 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869307

gerritbot added a comment.Dec 20 2022, 8:31 AM

Change 869310 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869310

gerritbot added a comment.Dec 20 2022, 8:31 AM

Change 869317 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869317

gerritbot added a comment.Dec 20 2022, 8:44 AM

Change 869298 merged by DannyS712:

[mediawiki/extensions/UserPageViewTracker@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869298

gerritbot added a comment.Dec 20 2022, 5:21 PM

Change 869296 merged by jenkins-bot:

[mediawiki/extensions/Polyglot@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869296

Umherirrender mentioned this in rEPGTc9bc765e78b7: Use LinkBatchFactory to create LinkBatch objects.Dec 20 2022, 6:08 PM
Umherirrender moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.Dec 20 2022, 6:35 PM
Umherirrender updated the task description. (Show Details)Dec 20 2022, 6:39 PM
gerritbot added a comment.Dec 20 2022, 6:46 PM

Change 869833 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Flow@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869833

Umherirrender added a comment.Dec 20 2022, 6:50 PM

https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/5361

gerritbot added a comment.Dec 21 2022, 6:11 AM

Change 869833 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869833

gerritbot added a comment.Dec 22 2022, 7:11 PM

Change 869294 merged by Umherirrender:

[mediawiki/extensions/Favorites@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869294

gerritbot added a comment.Dec 22 2022, 7:11 PM

Change 869299 merged by Umherirrender:

[mediawiki/extensions/Video@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869299

gerritbot added a comment.Jan 28 2023, 3:47 PM

Change 869286 merged by jenkins-bot:

[mediawiki/core@master] parser: Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/869286

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.21; 2023-01-30); removed MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Jan 28 2023, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 28 2023, 4:31 PM
gerritbot added a comment.Mar 7 2023, 9:41 PM

Change 895360 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Hard-deprecate manual construction of LinkBatch objects

https://gerrit.wikimedia.org/r/895360

gerritbot added a project: Patch-For-Review.Mar 7 2023, 9:41 PM
gerritbot added a comment.Mar 10 2023, 5:00 PM

Change 895360 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate manual construction of LinkBatch objects

https://gerrit.wikimedia.org/r/895360

Maintenance_bot removed a project: Patch-For-Review.Mar 10 2023, 5:11 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.27; 2023-03-13); removed MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Mar 10 2023, 6:00 PM
Umherirrender renamed this task from Hard-deprecate manual construction of LinkBatch objects (and make @internal a release later) to Hard-deprecate manual construction of LinkBatch objects (and make @internal in 1.41).Mar 10 2023, 7:03 PM
Umherirrender changed the task status from Open to Stalled.
Umherirrender changed the task status from Stalled to Open.Mar 14 2023, 9:34 PM
gerritbot added a comment.Apr 19 2023, 7:18 PM

Change 910086 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Remove fallback to MediaWikiServices in LinkBatch::__construct

https://gerrit.wikimedia.org/r/910086

gerritbot added a project: Patch-For-Review.Apr 19 2023, 7:18 PM
Umherirrender claimed this task.Apr 19 2023, 7:19 PM
gerritbot added a comment.Apr 20 2023, 1:25 AM

Change 910086 merged by jenkins-bot:

[mediawiki/core@master] Remove fallback to MediaWikiServices in LinkBatch::__construct

https://gerrit.wikimedia.org/r/910086

Maintenance_bot removed a project: Patch-For-Review.Apr 20 2023, 1:29 AM
Umherirrender closed this task as Resolved.Apr 20 2023, 5:01 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 4:01 PM
gerritbot added a comment.Mar 23 2024, 1:43 AM

Change #1013667 had a related patch set uploaded (by Lens0021; author: Lens0021):

[mediawiki/extensions/FacetedCategory@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/1013667

gerritbot added a project: Patch-For-Review.Mar 23 2024, 1:43 AM
gerritbot added a comment.Mar 23 2024, 3:50 PM

Change #1013630 had a related patch set uploaded (by Lens0021; author: Lens0021):

[mediawiki/extensions/FacetedCategory@REL1_41] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/1013630

gerritbot added a comment.Mar 23 2024, 3:51 PM

Change #1013630 merged by Lens0021:

[mediawiki/extensions/FacetedCategory@REL1_41] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/1013630

gerritbot added a comment.Mar 23 2024, 3:51 PM

Change #1013667 merged by Lens0021:

[mediawiki/extensions/FacetedCategory@master] Use LinkBatchFactory to create LinkBatch objects

https://gerrit.wikimedia.org/r/1013667

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL