| • alexhollender_WMF | |
| Jun 10 2022, 2:50 PM |
| F35275753: Screen Shot 2022-06-25 at 6.12.24 PM.png | |
| Jun 26 2022, 1:22 AM |
| F35275752: Screen Shot 2022-06-25 at 6.12.07 PM.png | |
| Jun 26 2022, 1:22 AM |
| F35251997: Screen Shot 2022-06-18 at 6.38.20 PM.png | |
| Jun 19 2022, 1:43 AM |
| F35251996: Screen Shot 2022-06-18 at 6.38.34 PM.png | |
| Jun 19 2022, 1:43 AM |
| F35237546: collapsed search max width.webm | |
| Jun 13 2022, 8:41 PM |
| F35225080: image.png | |
| Jun 10 2022, 2:51 PM |
| F35225072: image.png | |
| Jun 10 2022, 2:50 PM |
The search bar in the sticky header should have a max-width.
prototype: https://di-collapsible-menus.web.app/Brown_bear
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T310366#8013327 |
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T310366#8027319 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix sticky header searchbox width and misc searchbox CSS cleanup | mediawiki/skins/Vector | master | +24 -29 |
@alexhollender_WMF The code originally has the sticky header search bar set to a max width of 500px. Do you want me to change that to 520px?
Also do you mind reminding me, should the collapsed search bar also have a max width? https://jmp.sh/BE9XEAA
Thanks for pointing that out. 520px (including the width of the search bar + the search button) would be great, as it matches the main search bar in the site header.
Also do you mind reminding me, should the collapsed search bar also have a max width? https://jmp.sh/BE9XEAA
Hmm, good question. I think the transition from collapsed to uncollapsed will look better without a max-width there. If it has a max-width, and the screen is wide enough, it ends up feeling like it does a little jump:
Change 805231 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Fix sticky header searchbox width and misc searchbox CSS cleanup
Change 805231 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fix sticky header searchbox width and misc searchbox CSS cleanup
Status: ❓ ✅ PASS ( per T310366#8017429 )
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: The search bar in the sticky header should have a max-width.
@alexhollender_WMF, I get 524px and 522px, not 520px shown in the task description. The search field does have a max-width and doesn't change no matter how wide I make the page. Is this acceptable?
Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: The search bar in the sticky header should have a max-width.
Pass per T310366#8017429