(Go: >> BACK << -|- >> HOME <<)

Page MenuHomePhabricator

Some parameters dropped by Special:GatewayChooser for recurring donations
Closed, ResolvedPublic

Description

Not sure when this started, but I don't see any recurring card donations with utm matching the bundle test on Wednesday 15th, and this issue could cause that

(note that you may need to use fresh private/incognito windows for the links below to avoid caching)

To reproduce:
Visit a Special:GatewayChooser URL with recurring=true e.g.
https://payments.wikimedia.org/index.php/Special:GatewayChooser?amount=2&country=BE&currency=EUR&gateway=ingenico&opt_in=1&payment_method=cc&recurring=true&uselang=fr&variant=monthlyConvert_011&utm_campaign=test&utm_key=test&utm_medium=test&utm_source=test

Expected result:
All parameters are passed through and you end up on a correct payments form
https://payments.wikimedia.org/index.php?title=Special:IngenicoGateway&appeal=JimmyQuote&country=BE&currency=EUR&payment_method=cc&gateway=ingenico&variant=monthlyConvert_011&amount=2&opt_in=1&uselang=fr&utm_campaign=test&utm_key=test&utm_medium=test&utm_source=test

Actual result:
The amount, uselang, and all utm_ parameters are dropped.
https://payments.wikimedia.org/index.php?title=Special:IngenicoGateway&appeal=JimmyQuote&country=BE&currency=EUR&payment_method=cc&recurring=1&gateway=ingenico&variant=monthlyConvert_011

Effects

  • The donor has to select an amount again
  • the form is always in English
  • we are unable to attribute the donation to a banner/email

This does not appear to happen if the initial URL has recurring=false
https://payments.wikimedia.org/index.php/Special:GatewayChooser?amount=2&country=BE&currency=EUR&gateway=ingenico&opt_in=1&payment_method=cc&recurring=false&uselang=fr&variant=monthlyConvert_011&utm_campaign=test&utm_key=test&utm_medium=test&utm_source=test

Event Timeline

Pcoombe triaged this task as Unbreak Now! priority.Jun 17 2022, 2:50 PM

Marking UBN, although the only campaign at the moment with any recurring component is South Africa

Confirming there were recurring transactions which appeared in the Wednesday pretest: {F35249316}

Looking at the utm_source data we have recorded, suggests this started on the 13th. Guessing it's something in this deployment: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/805235

Thanks so much for the detailed report @Pcoombe!! I can confirm that happens locally, too. Digging in now.

Change 806465 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[mediawiki/extensions/DonationInterface@master] Fix GatewayChooser params pass-through

https://gerrit.wikimedia.org/r/806465

Change 806465 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Fix GatewayChooser params pass-through

https://gerrit.wikimedia.org/r/806465

Thanks again @EMartin, @Pcoombe!!! The fix to this now is deployed to production, so everything should be working as expected. :)

XenoRyet set Final Story Points to 2.

Change 808790 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[mediawiki/extensions/DonationInterface@master] Test pass-through of additional params for GatewayChoosre

https://gerrit.wikimedia.org/r/808790

Christianjade1 changed the task status from Resolved to Invalid.Jun 29 2022, 3:35 AM
JJMC89 changed the task status from Invalid to Resolved.Jun 29 2022, 3:38 AM

Hi @Pcoombe and @AndyRussG
The Opt-in parameter is still getting dropped when answered "no". (It works as expected if you answer "Yes')
I noticed it when checking Bundle banners, because I was never seeing the sentence that should appear on payments.wiki when people say No to opt-in ("We will email you a receipt to confirm your donation."). It's happening on all banners and donate.wiki.

Steps to reproduce:
Open banner: https://en.m.wikipedia.org/wiki/Wikipedia?banner=B2122_0615_mlWW_m_p2_sm_twin1&country=NO
Answer No to optin question "Can we follow up and let you know if we need your help again? The support and advice we get from donors in Norway is priceless, but many donors don't let us stay in touch. Will you commit today, this Wednesday, to staying in touch with Wikipedia?"

Expected result:
Payments wiki URL has opt_in=0 and We will email you a receipt to confirm your donation sentence displays below Email Field
https://payments.wikimedia.org/index.php?title=Special%3AAdyenCheckoutGateway&appeal=JimmyQuote&country=NO&currency=NOK&payment_method=cc&gateway=adyen&variant=monthlyConvert_011&uselang=en&amount=500&opt_in=0

Actual result:
Payments wiki URL does not have &opt_in=0 Parameter, We will email you a receipt to confirm your donation, does not display
https://payments.wikimedia.org/index.php?title=Special:AdyenCheckoutGateway&appeal=JimmyQuote&country=NO&currency=NOK&payment_method=cc&gateway=adyen&variant=monthlyConvert_011&uselang=en&amount=500&utm_medium=sitenotice&utm_campaign=test&utm_source=B2122_0615_mlWW_m_p2_sm_twin1_optIn0.no-LP.cc&utm_key=otherAmt_0%7Evw_1901%7Evh_846%7Etime_5

Change 809746 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[mediawiki/extensions/DonationInterface@master] Fix GatewayChooser pass-through '0' value params

https://gerrit.wikimedia.org/r/809746

Thanks so much for finding this and for the thorough report, @HNordeenWMF, it's super helpful! Confirmed this is happening. The attached patch should fix the issue.

Change 809746 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Fix GatewayChooser pass-through '0' value params

https://gerrit.wikimedia.org/r/809746

Change 808790 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Test pass-through of additional params for GatewayChoosre

https://gerrit.wikimedia.org/r/808790

@HNordeenWMF heyyy the fix is deployed, and it looks like it's working now!

XenoRyet changed Final Story Points from 2 to 4.