Monobook p-search-label is tagged with lang=en-GB attribute
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Ciencia_Al_Poder
	Jun 13 2022, 6:49 PM

Description

List of steps to reproduce

Open any page using the Monobook Skin. The user language can be any.
- Example: Spanish Wikipedia, French Wikipedia
Inspect the heading label of the search input, in the sidebar, or view source.

What happens?:

It has a lang="en-GB" property, but the language of the element is not in English:

<h3 id="p-search-label" dir="ltr" lang="en-GB"><label for="searchInput">Buscar</label></h3>

What should have happened instead?:

No lang="en-GB" property should be present.

Software version: This happens since MediaWiki 1.37. This is happening currently on WMF wikis. This didn't happen on MediaWiki 1.36

Subject	Repo	Branch	Lines +/-
Fix hardcoded dir and lang for #p-search-label	mediawiki/skins/MonoBook	REL1_37	+1 -1
Fix hardcoded dir and lang for #p-search-label	mediawiki/skins/MonoBook	REL1_38	+1 -1
Fix hardcoded dir and lang for #p-search-label	mediawiki/skins/MonoBook	master	+1 -1

Not surprising when you find the lang attribute is present in the mustache template :-)

Change 805264 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/skins/MonoBook@master] Fix hardcoded dir and lang for #p-search-label

Change 805264 merged by jenkins-bot:

[mediawiki/skins/MonoBook@master] Fix hardcoded dir and lang for #p-search-label

Change 805161 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/skins/MonoBook@REL1_38] Fix hardcoded dir and lang for #p-search-label

Change 805162 had a related patch set uploaded (by PleaseStand; author: PleaseStand):

[mediawiki/skins/MonoBook@REL1_37] Fix hardcoded dir and lang for #p-search-label

PleaseStand claimed this task.

Change 805161 merged by jenkins-bot:

[mediawiki/skins/MonoBook@REL1_38] Fix hardcoded dir and lang for #p-search-label

Change 805162 merged by jenkins-bot:

[mediawiki/skins/MonoBook@REL1_37] Fix hardcoded dir and lang for #p-search-label