(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T309547

brackets around Lexeme ID in explanation box
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Problem:
We put brackets around the Lexeme ID on the new Special:NewLexeme page in the explanation box. Now that we link the IDs, this looks out of place. Lydia thinks we should remove the brackets as it otherwise also looks like something is missing because in other places we use "label (Q-ID)" and similar patterns a lot.

Screenshots/mockups:

image.png (326×610 px, 43 KB)

Acceptance criteria:

  • brackets around the Lexeme ID in the Lexeme explanation box are removed

Details

SubjectRepoBranchLines +/-
Remove parentheses around lexeme IDmediawiki/extensions/WikibaseLexememaster+1 -1
Customize query in gerrit

Event Timeline

Lydia_Pintscher created this task.May 30 2022, 3:43 PM
Lydia_Pintscher added a subscriber: Erdinc_Ciftci_WMDE.

@Erdinc_Ciftci_WMDE what do you say?

Maintenance_bot added a project: Wikidata.May 30 2022, 4:29 PM
Erdinc_Ciftci_WMDE added a comment.Jun 7 2022, 9:52 AM

I think it's fine to remove them @Lydia_Pintscher

Lydia_Pintscher moved this task from Backlog to milestone x on the Special:NewLexeme revival board.Jun 7 2022, 9:58 AM

Cool.

gerritbot added a comment.Jun 13 2022, 10:22 AM

Change 805092 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Remove parentheses around lexeme ID

https://gerrit.wikimedia.org/r/805092

gerritbot added a project: Patch-For-Review.Jun 13 2022, 10:22 AM
Lucas_Werkmeister_WMDE claimed this task.Jun 13 2022, 10:22 AM
karapayneWMDE set the point value for this task to 1.Jun 14 2022, 9:10 AM
karapayneWMDE moved this task from milestone x to Special:NewLexeme revival - sprint 10 on the Special:NewLexeme revival board.
karapayneWMDE edited projects, added Special:NewLexeme revival (Special:NewLexeme revival - sprint 10); removed Special:NewLexeme revival.
gerritbot added a comment.Jun 14 2022, 9:11 AM

Change 805092 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Remove parentheses around lexeme ID

https://gerrit.wikimedia.org/r/805092

Lucas_Werkmeister_WMDE moved this task from To Do to Test (Verification) on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.Jun 14 2022, 9:12 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 14 2022, 9:30 AM
Michael subscribed.Jun 14 2022, 9:40 AM

This can now be verified on beta: https://wikidata.beta.wmflabs.org/wiki/Special:NewLexemeAlpha

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 14 2022, 10:00 AM
Lydia_Pintscher closed this task as Resolved.Jun 14 2022, 10:44 AM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.

\o/
Fasted ever :P

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits