(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T294977

Investigate: Match the preview area to the wikitext area
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

User Story

When I open the preview editor, I want the preview to match the place inside my wikitext, so that I can easily compare my output to the wikitext markup I am writing.

Acceptance Criteria

  • Output scrolling should match the visible output that maps to the wikitext
  • If scrolling happens in the wikitext box while the preview is open, the output should also scroll and viceversa.

Details

SubjectRepoBranchLines +/-
Realtime Preview: remove the scroll linking between source and previewmediawiki/extensions/WikiEditormaster+0 -34
Realtime preview: match scroll positions between textarea and previewmediawiki/extensions/WikiEditormaster+30 -0
Realtime preview: keep original scroll position when enabling/disablingmediawiki/extensions/WikiEditormaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

• NRodriguez created this task.Nov 3 2021, 8:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 3 2021, 8:37 PM
• NRodriguez updated the task description. (Show Details)Nov 3 2021, 8:41 PM
• NRodriguez moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Nov 8 2021, 4:01 PM
• NRodriguez added a subscriber: nayoub.Nov 10 2021, 12:45 PM

@nayoub and Natalia to sync on interaction patterns for toggling on and off the "scroll and follow" behavior

• NRodriguez renamed this task from Match the preview area to the wikitext area to Investigate: Match the preview area to the wikitext area.Nov 10 2021, 12:47 PM
• NRodriguez set the point value for this task to 2.
ldelench_wmf moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.Nov 10 2021, 12:47 PM
MusikAnimal subscribed.Nov 10 2021, 1:02 PM

Some conversation about using Parsoid to do this "very accurately": T284796#7246062

• NRodriguez updated the task description. (Show Details)Nov 10 2021, 7:19 PM
• NRodriguez moved this task from Up Next (June 3-21) to CommTech-Sprint-14 on the Community-Tech board.Nov 18 2021, 4:14 PM
• NRodriguez edited projects, added Community-Tech (CommTech-Sprint-14); removed Community-Tech.
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-15); removed Community-Tech (CommTech-Sprint-14).Dec 3 2021, 7:48 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-16); removed Community-Tech (CommTech-Sprint-15).Jan 4 2022, 5:08 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-17); removed Community-Tech (CommTech-Sprint-16).Jan 18 2022, 8:13 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-18); removed Community-Tech (CommTech-Sprint-17).Jan 31 2022, 2:33 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-19); removed Community-Tech (CommTech-Sprint-18).Feb 15 2022, 10:22 PM
• JMcLeod_WMF removed a project: Community-Tech (CommTech-Sprint-19).Mar 1 2022, 6:43 PM
• JMcLeod_WMF added a project: Community-Tech (CommTech-Sprint-20).Mar 1 2022, 6:53 PM
• NRodriguez moved this task from Backlog to 🌟Top Priority on the Realtime Preview board.Mar 10 2022, 4:17 PM
• NRodriguez moved this task from 🌟Top Priority to 💪Stretch Goals on the Realtime Preview board.Mar 10 2022, 4:21 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-21); removed Community-Tech (CommTech-Sprint-20).Mar 16 2022, 12:17 PM
• NRodriguez edited projects, added Community-Tech (CommTech-Sprint-23); removed Community-Tech (CommTech-Sprint-21).Mar 23 2022, 9:17 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-24); removed Community-Tech (CommTech-Sprint-23).Apr 25 2022, 4:57 PM
Samwilson subscribed.May 3 2022, 9:18 AM

It sounds like our approach here is going to be to scroll the preview area to the same percentage as the editing box. This can be inaccurate where there's a big discrepancy between wikitext height and rendered HTML height (e.g. large list of infobox parameters, only one of which is rendered; or a tall image, which requires only a single line in wikitext).

Samwilson mentioned this in T302916: Loading the output area to the matching wikitext .May 4 2022, 2:50 AM
HMonroy claimed this task.May 19 2022, 8:43 PM
HMonroy moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-24) board.
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-25); removed Community-Tech (CommTech-Sprint-24).May 24 2022, 6:33 PM
• JMcLeod_WMF moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-25) board.May 24 2022, 6:38 PM
Samwilson claimed this task.May 31 2022, 8:20 AM
Samwilson added a subscriber: HMonroy.
gerritbot added a comment.Jun 1 2022, 5:53 AM

Change 801968 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Realtime preview: match scroll positions between textarea and preview

https://gerrit.wikimedia.org/r/801968

gerritbot added a project: Patch-For-Review.Jun 1 2022, 5:53 AM
gerritbot added a comment.Jun 1 2022, 6:01 AM

Change 801969 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Realtime preview: keep original scroll position when enabling/disabling

https://gerrit.wikimedia.org/r/801969

Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-25) board.Jun 1 2022, 7:35 AM
gerritbot added a comment.Jun 1 2022, 10:03 PM

Change 801969 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime preview: keep original scroll position when enabling/disabling

https://gerrit.wikimedia.org/r/801969

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 1 2022, 11:00 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-26); removed Community-Tech (CommTech-Sprint-25).Jun 6 2022, 1:56 PM
• JMcLeod_WMF moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-26) board.Jun 6 2022, 1:57 PM
• JMcLeod_WMF moved this task from Review/Feedback 💬 to In Development 💻 on the Community-Tech (CommTech-Sprint-26) board.Jun 8 2022, 11:08 AM
Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-26) board.Jun 9 2022, 5:05 AM
gerritbot added a comment.Jun 10 2022, 7:42 PM

Change 801968 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime preview: match scroll positions between textarea and preview

https://gerrit.wikimedia.org/r/801968

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.16; 2022-06-13); removed MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 10 2022, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 10 2022, 8:30 PM
Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-26) board.Jun 10 2022, 10:18 PM
dom_walden subscribed.Jun 14 2022, 7:24 AM

@Samwilson I find the auto-scrolling does not happen when syntax highlighting (CodeMirror) is on. Is this expected?

Samwilson moved this task from QA 🐛 to In Development 💻 on the Community-Tech (CommTech-Sprint-26) board.Jun 14 2022, 7:53 AM

No, that's a bug! Thanks for reminding me. :-) I'll sort it out.

nayoub added a comment.Jun 15 2022, 11:52 PM

Following today's retro, we decided to revert this for now.
cc @NRodriguez

gerritbot added a comment.Jun 17 2022, 3:10 AM

Change 806358 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Realtime Preview: remove the scroll linking between source and preview

https://gerrit.wikimedia.org/r/806358

gerritbot added a project: Patch-For-Review.Jun 17 2022, 3:10 AM
Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-26) board.Jun 17 2022, 3:10 AM
gerritbot added a comment.Jun 17 2022, 5:24 PM

Change 806358 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime Preview: remove the scroll linking between source and preview

https://gerrit.wikimedia.org/r/806358

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.17; 2022-06-20); removed MW-1.39-notes (1.39.0-wmf.16; 2022-06-13).Jun 17 2022, 6:00 PM
Samwilson moved this task from Review/Feedback 💬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-26) board.Jun 17 2022, 10:55 PM

This feature has been added and then removed, so it can skip QA. The bug with not scrolling in CodeMirror is now correct behaviour. :)

• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-27); removed Community-Tech (CommTech-Sprint-26).Jun 21 2022, 1:40 PM
• JMcLeod_WMF moved this task from Ready 🎬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-27) board.Jun 21 2022, 1:42 PM
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-28); removed Community-Tech (CommTech-Sprint-27).Jul 6 2022, 1:22 PM
• JMcLeod_WMF moved this task from Ready 🎬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-28) board.Jul 6 2022, 1:24 PM
• NRodriguez closed this task as Resolved.Jul 6 2022, 6:53 PM

Since this was merely an investigation, not a feature, and the feature was removed, going to mark the investigation part as done. We are deciding NOT to implement this feature in the meantime

Samwilson mentioned this in T327004: Sync the cursor location and real-time preview.Jan 16 2023, 7:58 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits