Error on tokenise method doesn't allow auto-saving or publishing of article
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Jpita
	Jul 8 2019, 3:49 PM

Description

Actions:

start translation
translate math formulas
if autosave works, go back to the dashboard and open the translation again
translate another formula and see if autosave works

error:

VM34:formatted:30702 Uncaught TypeError: Cannot read property 'match' of undefined
    at Object.mw.cx.TranslationTracker.static.tokenise (<anonymous>:884:398)
    at MwCXTranslationTracker.<anonymous> (<anonymous>:893:434)
    at Array.forEach (<anonymous>)
    at MwCXTranslationTracker.mw.cx.TranslationTracker.getUnmodifiedMTPercentageInTranslation (<anonymous>:893:307)
    at MwCXTranslationTracker.mw.cx.TranslationTracker.getTranslationProgress (<anonymous>:893:1)
    at MwCXTranslationTracker.mw.cx.TranslationTracker.init (<anonymous>:885:799)
    at MwCxTranslationController.mw.cx.TranslationController.onSurfaceReady (<anonymous>:881:195)
    at VeInitMwCXTarget.oo.EventEmitter.emit (<anonymous>:69:486)
    at VeInitMwCXTarget.ve.init.mw.Target.surfaceReady (<anonymous>:561:346)
    at VeInitMwCXTarget.ve.init.mw.CXTarget.surfaceReady (<anonymous>:355:645)

Method: mw.cx.TranslationTracker.static.tokenise
article: https://en.wikipedia.org/wiki/Proof_that_%CF%80_is_irrational
Translation: en to pt
https://pt.wikipedia.org/wiki/Special:ContentTranslation?page=Proof+that+%CF%80+is+irrational&from=en&to=pt&targettitle=User%3ADvpita%2FProof+that+%CF%80+is+irrational

Details

Subject	Repo	Branch	Lines +/-
Prevent js error in mw.cx.TranslationTracker#tokenise	mediawiki/extensions/ContentTranslation	master	+3 -0
Update cxserver to 2019-07-29-154005-production	operations/deployment-charts	master	+4 -4
Do not pass Math content to MT engines	mediawiki/services/cxserver	master	+118 -21

Customize query in gerrit

Related Objects

Mentioned In: rDEPLOYCHARTSc6709f548855: Update cxserver to 2019-07-29-154005-production
T220790: Restore using updated content only when no user data is lost, using the original version as a fallback
Mentioned Here: T222699: Edits in mw:Extension/Math content is not saved
T225118: Math formula should not be checked for unmodified content issues
T214256: CX2 shows </img> instead of math formulas
T106915: Use Sentry in production

Event Timeline

• Jpita created this task.Jul 8 2019, 3:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2019, 3:49 PM

Pginer-WMF added a project: ContentTranslation.Jul 8 2019, 3:54 PM

• Petar.petkovic mentioned this in T220790: Restore using updated content only when no user data is lost, using the original version as a fallback.Jul 9 2019, 1:02 AM

Pginer-WMF triaged this task as Medium priority.Jul 9 2019, 8:02 AM

also happening when I translate this article https://en.wikipedia.org/wiki/Chronology_of_Gabon from en to es
Steps:

open translation
translate one paragraph from each of the sections
wait for autosave
go back to "all translations"
load the translation again
an error appears on the console, autosave stops working, publishing doesn't work

@Petar.petkovic do we have any data on how many times this error occurs?

In T227493#5316961, @Jpita wrote:

@Petar.petkovic do we have any data on how many times this error occurs?

No, I don't have data, only clues on what could be the underlying problem. If this ends up in priority backlog, I'll gladly pick it up.

@Petar.petkovic do you think it is possible to have metrics on logstash/kibana for javascript errors?

In T227493#5317021, @Jpita wrote:

@Petar.petkovic do you think it is possible to have metrics on logstash/kibana for javascript errors?

I don't deal with logging much, it's better to ask @Amire80 who does analytics mostly.

There is no logging of client side errors currently, unfortunately. See T106915: Use Sentry in production for an epic about it. It's coming but I don't know when. Thus we have no idea how common this is other than what we notice ourselves or what users might report.

@Nikerabbit

Thus we have no idea how common this is other than what we notice ourselves or what users might report.

This is what I'm worried about, because I've been finding this error every day for the last days.
BUT I don't know what's the normal user flow, if it involves doing a translation in one go or start a translation and going back to it in order to finish it at a later date

Pginer-WMF moved this task from Needs Triage to Bugs on the ContentTranslation board.Jul 15 2019, 3:30 PM

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-July-September) board.Jul 16 2019, 8:41 AM

I was not able to reproduce the case of https://en.wikipedia.org/wiki/Chronology_of_Gabon from en to es. But I was able to reproduce with https://en.wikipedia.org/wiki/Proof_that_%CF%80_is_irrational en to pt.

The corresponding section looked liked like this:

So, I can add a null/undefined check to prevent the js error, but I think we need to lookinto the problem of why the Math was adapted like this.

Change 525238 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Prevent js error in mw.cx.TranslationTracker#tokenize

https://gerrit.wikimedia.org/r/525238

gerritbot added a project: Patch-For-Review.Jul 24 2019, 9:20 AM

Found that if I used Yandex instead of Google, the above section translated correctly

In T227493#5360436, @santhosh wrote:

This example seems a case of T214256: CX2 shows </img> instead of math formulas. Once the current ticket is solved, it may be good to check if T214256 got also resolved as a result.

• Petar.petkovic moved this task from Priority backlog to In Review on the Language-Team (Language-2019-July-September) board.Jul 24 2019, 10:54 AM

yes, I think the math support need to improve and that can fix both. First thing to do is avoid sending math sections to MT engines so that they don't mangle it.

Change 525264 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] WIP: Do not pass Math content to MT engines

https://gerrit.wikimedia.org/r/525264

In T227493#5360832, @santhosh wrote:

yes, I think the math support need to improve and that can fix both. First thing to do is avoid sending math sections to MT engines so that they don't mangle it.

Tickets that may be relevant:

Change 525264 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Do not pass Math content to MT engines

https://gerrit.wikimedia.org/r/525264

Change 526311 had a related patch set uploaded (by KartikMistry; owner: KartikMistry):
[operations/deployment-charts@master] Update cxserver to 2019-07-29-154005-production

https://gerrit.wikimedia.org/r/526311

Change 526311 merged by KartikMistry:
[operations/deployment-charts@master] Update cxserver to 2019-07-29-154005-production

https://gerrit.wikimedia.org/r/526311

KartikMistry mentioned this in rDEPLOYCHARTSc6709f548855: Update cxserver to 2019-07-29-154005-production.Jul 30 2019, 10:59 AM

• Petar.petkovic merged a task: T230108: Translation publication fails due to js error.Aug 9 2019, 11:56 AM

• Petar.petkovic added a subscriber: Andrei_Stroe.

Change 525238 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Prevent js error in mw.cx.TranslationTracker#tokenise

https://gerrit.wikimedia.org/r/525238

Nikerabbit removed a project: Patch-For-Review.Sep 23 2019, 7:39 AM

Nikerabbit moved this task from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 23 2019, 8:01 AM

• Jpita closed this task as Resolved.Sep 26 2019, 3:58 PM

• Jpita moved this task from Needs QA to Done on the Language-Team (Language-2019-July-September) board.

	F29860362: image.png
	Jul 24 2019, 9:42 AM

	F29860318: image.png
	Jul 24 2019, 9:18 AM

Error on tokenise method doesn't allow auto-saving or publishing of articleClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Error on tokenise method doesn't allow auto-saving or publishing of article
Closed, ResolvedPublic
Actions