Maniphest T200646

Communicate session has expired on dashboard when switching between lists
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Petar.petkovic
	Jul 29 2018, 2:48 PM

Description

When user's session expires and one tries switching between the lists on Content Translation dashboard, JS errors occur, and empty lists are displayed, leaving users without much clue about what happened.

Switching to translation lists after session has expired

cx2-switching-lists-error-translationlist.png (144×700 px, 20 KB)

jQuery.Deferred exception: Cannot read property 'contenttranslation' of undefined TypeError: Cannot read property 'contenttranslation' of undefined
    at http://cx2-testing.wmflabs.org/extensions/ContentTranslation/modules/dashboard/ext.cx.translationlist.js?79764:72:24
    at mightThrow (http://cx2-testing.wmflabs.org/load.php?debug=true&lang=en&modules=jquery%7Cmediawiki.base&only=scripts&skin=vector&version=069i1tc:3583:29)
    at process (http://cx2-testing.wmflabs.org/load.php?debug=true&lang=en&modules=jquery%7Cmediawiki.base&only=scripts&skin=vector&version=069i1tc:3651:12) undefined

Switching to suggestion lists after session has expired

cx2-switching-lists-error-suggestionlist.png (427×699 px, 61 KB)

jQuery.Deferred exception: Cannot read property 'contenttranslation' of undefined TypeError: Cannot read property 'contenttranslation' of undefined
    at http://cx2-testing.wmflabs.org/extensions/ContentTranslation/modules/dashboard/ext.cx.recommendtool.client.js?80968:57:39
    at mightThrow (http://cx2-testing.wmflabs.org/load.php?debug=true&lang=en&modules=jquery%7Cmediawiki.base&only=scripts&skin=vector&version=069i1tc:3583:29)
    at process (http://cx2-testing.wmflabs.org/load.php?debug=true&lang=en&modules=jquery%7Cmediawiki.base&only=scripts&skin=vector&version=069i1tc:3651:12) undefined
jQuery.Deferred exception: Cannot read property 'contenttranslation' of undefined TypeError: Cannot read property 'contenttranslation' of undefined
    at http://cx2-testing.wmflabs.org/extensions/ContentTranslation/modules/dashboard/ext.cx.recommendtool.client.js?80968:57:39
    at mightThrow (http://cx2-testing.wmflabs.org/load.php?debug=true&lang=en&modules=jquery%7Cmediawiki.base&only=scripts&skin=vector&version=069i1tc:3583:29)
    at process (http://cx2-testing.wmflabs.org/load.php?debug=true&lang=en&modules=jquery%7Cmediawiki.base&only=scripts&skin=vector&version=069i1tc:3651:12) undefined
jQuery.Deferred exception: Cannot read property 'contenttranslation' of undefined TypeError: Cannot read property 'contenttranslation' of undefined
    at http://cx2-testing.wmflabs.org/extensions/ContentTranslation/modules/dashboard/ext.cx.recommendtool.client.js?80968:57:39
    at mightThrow (http://cx2-testing.wmflabs.org/load.php?debug=true&lang=en&modules=jquery%7Cmediawiki.base&only=scripts&skin=vector&version=069i1tc:3583:29)
    at process (http://cx2-testing.wmflabs.org/load.php?debug=true&lang=en&modules=jquery%7Cmediawiki.base&only=scripts&skin=vector&version=069i1tc:3651:12) undefined

Proposed solution

T192066 proposes to display the login dialog when the session expires on translation view, and we could utilize the same approach for the dashboard as well:

CX-error-session-dialog.png (720×1 px, 215 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Display dialog when user session expires	mediawiki/extensions/ContentTranslation	master	+89 -17

Customize query in gerrit

Related Objects

Mentioned In: T204778: [betalabs] Content Translation page elements overlap system popup message
T201416: Refactor code for dashboard lists
T200648: Communicate session has expired on dashboard for actions on list items
Mentioned Here: T192066: CX2: Communicate session has expired on translation view

Event Timeline

• Petar.petkovic renamed this task from CX2: Communicate session has expired on dashboard to Communicate session has expired on dashboard.Jul 29 2018, 2:48 PM

• Petar.petkovic created this task.

• Petar.petkovic moved this task from Needs Triage to Bugs on the ContentTranslation board.Jul 29 2018, 2:50 PM

• Petar.petkovic renamed this task from Communicate session has expired on dashboard to Communicate session has expired on dashboard when switching between lists.Jul 29 2018, 3:00 PM

• Petar.petkovic mentioned this in T200648: Communicate session has expired on dashboard for actions on list items.Jul 29 2018, 3:08 PM

Change 448153 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Display dialog when user session expires

https://gerrit.wikimedia.org/r/448153

gerritbot added a project: Patch-For-Review.Jul 29 2018, 7:18 PM

• Petar.petkovic added a project: Language-2018-July-September.Jul 29 2018, 7:19 PM

• Petar.petkovic moved this task from Backlog to In Review on the Language-2018-July-September board.

• Petar.petkovic mentioned this in T201416: Refactor code for dashboard lists.Aug 7 2018, 1:28 PM

Change 448153 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Display dialog when user session expires

https://gerrit.wikimedia.org/r/448153

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptAug 28 2018, 11:28 AM

• Petar.petkovic removed a project: Patch-For-Review.Aug 28 2018, 11:29 AM

• Petar.petkovic moved this task from In Review to QA on the Language-2018-July-September board.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).Aug 28 2018, 12:00 PM

@Pginer-WMF - please take a quick look. The screenshot from Proposed solution looks different from the following screenshot in cx2. Also, using the term "list" may be confusing to some users.

Screen Shot 2018-08-31 at 4.32.00 PM.png (394×534 px, 39 KB)

I checked the functionality - all works, so if the design is ok, you may mark the ticket as Resolved.

In T200646#4549951, @Etonkovidova wrote:

@Pginer-WMF - please take a quick look. The screenshot from Proposed solution looks different from the following screenshot in cx2. Also, using the term "list" may be confusing to some users.

I checked the functionality - all works, so if the design is ok, you may mark the ticket as Resolved.

The design was not actually provided by @Pginer-WMF for this ticket. I have reused the image which he created for T192066, just to illustrate the point. That is the reason text is different.
Button is blue because of the changes in OOUI library.

Looks good to me.

• Petar.petkovic removed a subscriber: gerritbot.Sep 3 2018, 3:01 PM

• Petar.petkovic moved this task from QA to Done on the Language-2018-July-September board.Sep 5 2018, 7:26 AM

Pginer-WMF mentioned this in T204778: [betalabs] Content Translation page elements overlap system popup message.Sep 30 2019, 9:08 AM

	F25576733: Screen Shot 2018-08-31 at 4.32.00 PM.png
	Aug 31 2018, 11:44 PM

	F24310795: cx2-switching-lists-error-translationlist.png
	Jul 29 2018, 2:48 PM

	F24310796: cx2-switching-lists-error-suggestionlist.png
	Jul 29 2018, 2:48 PM

Communicate session has expired on dashboard when switching between listsClosed, ResolvedPublicActions