(Go: >> BACK << -|- >> HOME <<)
Page MenuHomePhabricator
Create Task
Maniphest T188071

Correct the link cache usage for VE in CX2
Closed, ResolvedPublic
Actions

Description

Currently, all links are pointing to the local wiki, irrespective of source or target languages since the link cache behavior is inherited from VE. For CX, irrespective of current wiki, the links should have metadata fetched from configured source or target wikis(both can be different from local wiki).

In https://gerrit.wikimedia.org/r/#/c/378666/ an initial exploration was done to use the link metadata from the cxserver and avoiding link cache usage. But it was stuck at that time due to non-technical reasons. We should continue that exploration and fix this important framework component.

(This is the reason behind all links in CX2 showing in red color in source and target column)

Details

SubjectRepoBranchLines +/-
CX2: Use the cxserver supplied link information in link inspectormediawiki/extensions/ContentTranslationmaster+72 -25
CX2: Don't use link cache for styling the linksmediawiki/extensions/ContentTranslationmaster+44 -4
Customize query in gerrit

Event Timeline

• santhosh created this task.Feb 23 2018, 6:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2018, 6:25 AM
Pginer-WMF triaged this task as High priority.Feb 23 2018, 7:51 AM
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-2018-Jan-Mar board.
• Petar.petkovic moved this task from Needs Triage to CX2 on the ContentTranslation board.Mar 4 2018, 1:57 AM
• santhosh moved this task from Priority backlog to In Progress on the Language-2018-Jan-Mar board.Mar 8 2018, 8:03 AM
gerritbot subscribed.Mar 8 2018, 10:12 AM

Change 417223 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] CX2: Don't use link cache for styling the links

https://gerrit.wikimedia.org/r/417223

gerritbot added a project: Patch-For-Review.Mar 8 2018, 10:12 AM
gerritbot added a comment.Mar 8 2018, 10:56 AM

Change 417229 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] CX2: Use the cxserver supplied link information in link inspector

https://gerrit.wikimedia.org/r/417229

• Petar.petkovic moved this task from In Progress to In Review on the Language-2018-Jan-Mar board.Mar 9 2018, 1:29 AM
gerritbot added a comment.Mar 12 2018, 8:43 AM

Change 417223 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX2: Don't use link cache for styling the links

https://gerrit.wikimedia.org/r/417223

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)).Mar 12 2018, 9:00 AM
Nikerabbit removed a project: Patch-For-Review.Mar 12 2018, 9:55 AM
Nikerabbit moved this task from In Review to QA on the Language-2018-Jan-Mar board.
Nikerabbit subscribed.

Source column doesn't have an inspector, but I assume that is a separate task.

Nikerabbit moved this task from QA to In Review on the Language-2018-Jan-Mar board.Mar 12 2018, 9:56 AM
Nikerabbit added a project: Patch-For-Review.
gerritbot added a comment.Mar 13 2018, 8:15 AM

Change 417229 merged by Nikerabbit:
[mediawiki/extensions/ContentTranslation@master] CX2: Use the cxserver supplied link information in link inspector

https://gerrit.wikimedia.org/r/417229

Nikerabbit removed a project: Patch-For-Review.Mar 13 2018, 10:42 AM
Nikerabbit moved this task from In Review to QA on the Language-2018-Jan-Mar board.
KartikMistry moved this task from QA to Done on the Language-2018-Jan-Mar board.Mar 15 2018, 7:23 AM
Arrbee closed this task as Resolved.Mar 19 2018, 7:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL